From: Ulrich Hecht <uli+renesas@fpond.eu>
To: linux-renesas-soc@vger.kernel.org, linux-mmc@vger.kernel.org
Cc: niklas.soderlund@ragnatech.se, wsa@the-dreams.de,
yamada.masahiro@socionext.com, geert@linux-m68k.org,
ulf.hansson@linaro.org, magnus.damm@gmail.com,
Ulrich Hecht <uli+renesas@fpond.eu>
Subject: [PATCH 0/2] mmc: tmio: remove Gen2+ workaround and fix up
Date: Tue, 16 Jul 2019 17:01:02 +0200 [thread overview]
Message-ID: <1563289264-26432-1-git-send-email-uli+renesas@fpond.eu> (raw)
Hi!
The second patch in this series removes a workaround that forced eMMC devices
always on and that is no longer required.
Removing it does expose a bug, however, that leads to a clock imbalance due
to the clock being enabled by both PM and the hardware driver. (See
https://www.spinics.net/lists/linux-mmc/msg54009.html for discussion.)
This bug is taken care of by the first patch.
Tested on r8a7790 (Lager), r8a7795 and r8a7796 (Salvator-X) with SD and
eMMC, before and after suspend.
CU
Uli
Ulrich Hecht (2):
mmc: tmio: leave clock handling to PM if enabled
mmc: tmio: remove obsolete PM workaround
drivers/mmc/host/tmio_mmc_core.c | 33 ++++++---------------------------
1 file changed, 6 insertions(+), 27 deletions(-)
--
2.7.4
next reply other threads:[~2019-07-16 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 15:01 Ulrich Hecht [this message]
2019-07-16 15:01 ` [PATCH 1/2] mmc: tmio: leave clock handling to PM if enabled Ulrich Hecht
2019-07-16 19:05 ` Wolfram Sang
2019-07-17 1:13 ` Niklas Söderlund
2019-07-25 13:43 ` Ulf Hansson
2019-07-29 8:44 ` Geert Uytterhoeven
2019-07-16 15:01 ` [PATCH 2/2] mmc: tmio: remove obsolete PM workaround Ulrich Hecht
2019-07-29 8:37 ` Geert Uytterhoeven
2019-07-25 21:15 ` [PATCH 0/2] mmc: tmio: remove Gen2+ workaround and fix up Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563289264-26432-1-git-send-email-uli+renesas@fpond.eu \
--to=uli+renesas@fpond.eu \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).