linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
@ 2023-03-23 18:51 Prabhakar
  2023-03-24  9:34 ` Geert Uytterhoeven
  2023-03-31 18:36 ` Rob Herring
  0 siblings, 2 replies; 9+ messages in thread
From: Prabhakar @ 2023-03-23 18:51 UTC (permalink / raw)
  To: Geert Uytterhoeven, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski
  Cc: Maxime Coquelin, Alexandre Torgue, Chris Brandt, linux-kernel,
	linux-renesas-soc, devicetree, linux-stm32, linux-arm-kernel,
	Prabhakar, Biju Das, Lad Prabhakar

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
SoC. "renesas,r9a07g043-ostm" compatible string will be used on the
RZ/Five SoC so to make this clear, update the comment to include RZ/Five
SoC.

No driver changes are required as generic compatible string
"renesas,ostm" will be used as a fallback on RZ/Five SoC.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 Documentation/devicetree/bindings/timer/renesas,ostm.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
index 7207929e5cd6..8b06a681764e 100644
--- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
@@ -23,7 +23,7 @@ properties:
       - enum:
           - renesas,r7s72100-ostm  # RZ/A1H
           - renesas,r7s9210-ostm   # RZ/A2M
-          - renesas,r9a07g043-ostm # RZ/G2UL
+          - renesas,r9a07g043-ostm # RZ/G2UL and RZ/Five
           - renesas,r9a07g044-ostm # RZ/G2{L,LC}
           - renesas,r9a07g054-ostm # RZ/V2L
       - const: renesas,ostm        # Generic
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
  2023-03-23 18:51 [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC Prabhakar
@ 2023-03-24  9:34 ` Geert Uytterhoeven
  2023-03-24 11:51   ` Lad, Prabhakar
  2023-03-31 18:36 ` Rob Herring
  1 sibling, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-03-24  9:34 UTC (permalink / raw)
  To: Prabhakar
  Cc: Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Maxime Coquelin, Alexandre Torgue,
	Chris Brandt, linux-kernel, linux-renesas-soc, devicetree,
	linux-stm32, linux-arm-kernel, Biju Das, Lad Prabhakar

Hi Prabhakar,

Thanks for your patch!

On Thu, Mar 23, 2023 at 7:56 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
> SoC. "renesas,r9a07g043-ostm" compatible string will be used on the
> RZ/Five SoC so to make this clear, update the comment to include RZ/Five
> SoC.
>
> No driver changes are required as generic compatible string
> "renesas,ostm" will be used as a fallback on RZ/Five SoC.

While this paragraph is true, it doesn't really matter, as you're not
adding a new SoC-specific compatible value.

> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> @@ -23,7 +23,7 @@ properties:
>        - enum:
>            - renesas,r7s72100-ostm  # RZ/A1H
>            - renesas,r7s9210-ostm   # RZ/A2M
> -          - renesas,r9a07g043-ostm # RZ/G2UL
> +          - renesas,r9a07g043-ostm # RZ/G2UL and RZ/Five
>            - renesas,r9a07g044-ostm # RZ/G2{L,LC}
>            - renesas,r9a07g054-ostm # RZ/V2L
>        - const: renesas,ostm        # Generic

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
  2023-03-24  9:34 ` Geert Uytterhoeven
@ 2023-03-24 11:51   ` Lad, Prabhakar
  0 siblings, 0 replies; 9+ messages in thread
From: Lad, Prabhakar @ 2023-03-24 11:51 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Maxime Coquelin, Alexandre Torgue,
	Chris Brandt, linux-kernel, linux-renesas-soc, devicetree,
	linux-stm32, linux-arm-kernel, Biju Das, Lad Prabhakar

Hi Geert,

Thank you for the review.

On Fri, Mar 24, 2023 at 9:35 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> Thanks for your patch!
>
> On Thu, Mar 23, 2023 at 7:56 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
> > SoC. "renesas,r9a07g043-ostm" compatible string will be used on the
> > RZ/Five SoC so to make this clear, update the comment to include RZ/Five
> > SoC.
> >
> > No driver changes are required as generic compatible string
> > "renesas,ostm" will be used as a fallback on RZ/Five SoC.
>
> While this paragraph is true, it doesn't really matter, as you're not
> adding a new SoC-specific compatible value.
>
Agreed, I will keep that in mind for future patches.

Cheers,
Prabhakar

> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> > +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> > @@ -23,7 +23,7 @@ properties:
> >        - enum:
> >            - renesas,r7s72100-ostm  # RZ/A1H
> >            - renesas,r7s9210-ostm   # RZ/A2M
> > -          - renesas,r9a07g043-ostm # RZ/G2UL
> > +          - renesas,r9a07g043-ostm # RZ/G2UL and RZ/Five
> >            - renesas,r9a07g044-ostm # RZ/G2{L,LC}
> >            - renesas,r9a07g054-ostm # RZ/V2L
> >        - const: renesas,ostm        # Generic
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
  2023-03-23 18:51 [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC Prabhakar
  2023-03-24  9:34 ` Geert Uytterhoeven
@ 2023-03-31 18:36 ` Rob Herring
  1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2023-03-31 18:36 UTC (permalink / raw)
  To: Prabhakar
  Cc: Daniel Lezcano, linux-arm-kernel, Lad Prabhakar, linux-stm32,
	linux-renesas-soc, Rob Herring, Alexandre Torgue, Chris Brandt,
	Biju Das, Geert Uytterhoeven, devicetree, Maxime Coquelin,
	Krzysztof Kozlowski, linux-kernel, Thomas Gleixner


On Thu, 23 Mar 2023 18:51:12 +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
> SoC. "renesas,r9a07g043-ostm" compatible string will be used on the
> RZ/Five SoC so to make this clear, update the comment to include RZ/Five
> SoC.
> 
> No driver changes are required as generic compatible string
> "renesas,ostm" will be used as a fallback on RZ/Five SoC.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/timer/renesas,ostm.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
  2024-02-13 10:22 ` Lad, Prabhakar
@ 2024-02-13 13:03   ` Daniel Lezcano
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Lezcano @ 2024-02-13 13:03 UTC (permalink / raw)
  To: Lad, Prabhakar
  Cc: Chris Brandt, Maxime Coquelin, Alexandre Torgue,
	Geert Uytterhoeven, Conor Dooley, Krzysztof Kozlowski,
	Rob Herring, Thomas Gleixner, Magnus Damm, linux-stm32,
	linux-arm-kernel, devicetree, linux-kernel, linux-renesas-soc,
	Biju Das, Lad Prabhakar

On 13/02/2024 11:22, Lad, Prabhakar wrote:
> Hi Daniel,
> 
> On Wed, Nov 15, 2023 at 9:29 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
>>
>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>
>> The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
>> SoC. "renesas,r9a07g043-ostm" compatible string will be used on the RZ/Five
>> SoC so to make this clear and to keep this file consistent, update the
>> comment to include RZ/Five SoC.
>>
>> No driver changes are required as generic compatible string "renesas,ostm"
>> will be used as a fallback on RZ/Five SoC.
>>
>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> ---
>>   Documentation/devicetree/bindings/timer/renesas,ostm.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Gentle ping!

Applied, thanks for the head up

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
  2023-11-15 21:29 Prabhakar
  2023-11-15 21:54 ` Conor Dooley
  2023-11-16 13:48 ` Geert Uytterhoeven
@ 2024-02-13 10:22 ` Lad, Prabhakar
  2024-02-13 13:03   ` Daniel Lezcano
  2 siblings, 1 reply; 9+ messages in thread
From: Lad, Prabhakar @ 2024-02-13 10:22 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Chris Brandt, Maxime Coquelin, Alexandre Torgue,
	Geert Uytterhoeven, Conor Dooley, Krzysztof Kozlowski,
	Rob Herring, Thomas Gleixner, Magnus Damm, linux-stm32,
	linux-arm-kernel, devicetree, linux-kernel, linux-renesas-soc,
	Biju Das, Lad Prabhakar

Hi Daniel,

On Wed, Nov 15, 2023 at 9:29 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
> SoC. "renesas,r9a07g043-ostm" compatible string will be used on the RZ/Five
> SoC so to make this clear and to keep this file consistent, update the
> comment to include RZ/Five SoC.
>
> No driver changes are required as generic compatible string "renesas,ostm"
> will be used as a fallback on RZ/Five SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/timer/renesas,ostm.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Gentle ping!

Cheers,
Prabhakar

> diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> index 7207929e5cd6..8b06a681764e 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> @@ -23,7 +23,7 @@ properties:
>        - enum:
>            - renesas,r7s72100-ostm  # RZ/A1H
>            - renesas,r7s9210-ostm   # RZ/A2M
> -          - renesas,r9a07g043-ostm # RZ/G2UL
> +          - renesas,r9a07g043-ostm # RZ/G2UL and RZ/Five
>            - renesas,r9a07g044-ostm # RZ/G2{L,LC}
>            - renesas,r9a07g054-ostm # RZ/V2L
>        - const: renesas,ostm        # Generic
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
  2023-11-15 21:29 Prabhakar
  2023-11-15 21:54 ` Conor Dooley
@ 2023-11-16 13:48 ` Geert Uytterhoeven
  2024-02-13 10:22 ` Lad, Prabhakar
  2 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-11-16 13:48 UTC (permalink / raw)
  To: Prabhakar
  Cc: Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue,
	Maxime Coquelin, Chris Brandt, Magnus Damm, linux-stm32,
	linux-arm-kernel, devicetree, linux-kernel, linux-renesas-soc,
	Biju Das, Lad Prabhakar

On Wed, Nov 15, 2023 at 10:29 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
> SoC. "renesas,r9a07g043-ostm" compatible string will be used on the RZ/Five
> SoC so to make this clear and to keep this file consistent, update the
> comment to include RZ/Five SoC.
>
> No driver changes are required as generic compatible string "renesas,ostm"
> will be used as a fallback on RZ/Five SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
  2023-11-15 21:29 Prabhakar
@ 2023-11-15 21:54 ` Conor Dooley
  2023-11-16 13:48 ` Geert Uytterhoeven
  2024-02-13 10:22 ` Lad, Prabhakar
  2 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2023-11-15 21:54 UTC (permalink / raw)
  To: Prabhakar
  Cc: Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	Alexandre Torgue, Maxime Coquelin, Chris Brandt, Magnus Damm,
	linux-stm32, linux-arm-kernel, devicetree, linux-kernel,
	linux-renesas-soc, Biju Das, Lad Prabhakar

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

On Wed, Nov 15, 2023 at 09:29:08PM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
> SoC. "renesas,r9a07g043-ostm" compatible string will be used on the RZ/Five
> SoC so to make this clear and to keep this file consistent, update the
> comment to include RZ/Five SoC.
> 
> No driver changes are required as generic compatible string "renesas,ostm"
> will be used as a fallback on RZ/Five SoC.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor,

> ---
>  Documentation/devicetree/bindings/timer/renesas,ostm.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> index 7207929e5cd6..8b06a681764e 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> @@ -23,7 +23,7 @@ properties:
>        - enum:
>            - renesas,r7s72100-ostm  # RZ/A1H
>            - renesas,r7s9210-ostm   # RZ/A2M
> -          - renesas,r9a07g043-ostm # RZ/G2UL
> +          - renesas,r9a07g043-ostm # RZ/G2UL and RZ/Five
>            - renesas,r9a07g044-ostm # RZ/G2{L,LC}
>            - renesas,r9a07g054-ostm # RZ/V2L
>        - const: renesas,ostm        # Generic
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC
@ 2023-11-15 21:29 Prabhakar
  2023-11-15 21:54 ` Conor Dooley
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Prabhakar @ 2023-11-15 21:29 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	Alexandre Torgue, Maxime Coquelin, Chris Brandt
  Cc: Magnus Damm, linux-stm32, linux-arm-kernel, devicetree,
	linux-kernel, linux-renesas-soc, Prabhakar, Biju Das,
	Lad Prabhakar

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL
SoC. "renesas,r9a07g043-ostm" compatible string will be used on the RZ/Five
SoC so to make this clear and to keep this file consistent, update the
comment to include RZ/Five SoC.

No driver changes are required as generic compatible string "renesas,ostm"
will be used as a fallback on RZ/Five SoC.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 Documentation/devicetree/bindings/timer/renesas,ostm.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
index 7207929e5cd6..8b06a681764e 100644
--- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
@@ -23,7 +23,7 @@ properties:
       - enum:
           - renesas,r7s72100-ostm  # RZ/A1H
           - renesas,r7s9210-ostm   # RZ/A2M
-          - renesas,r9a07g043-ostm # RZ/G2UL
+          - renesas,r9a07g043-ostm # RZ/G2UL and RZ/Five
           - renesas,r9a07g044-ostm # RZ/G2{L,LC}
           - renesas,r9a07g054-ostm # RZ/V2L
       - const: renesas,ostm        # Generic
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-02-13 13:03 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 18:51 [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC Prabhakar
2023-03-24  9:34 ` Geert Uytterhoeven
2023-03-24 11:51   ` Lad, Prabhakar
2023-03-31 18:36 ` Rob Herring
2023-11-15 21:29 Prabhakar
2023-11-15 21:54 ` Conor Dooley
2023-11-16 13:48 ` Geert Uytterhoeven
2024-02-13 10:22 ` Lad, Prabhakar
2024-02-13 13:03   ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).