From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: marek.vasut@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix backlight regulator numbering
Date: Thu, 10 Jan 2019 14:59:15 +0200 [thread overview]
Message-ID: <1816865.hhpKvpXsC4@avalon> (raw)
In-Reply-To: <20190109140045.17449-1-marek.vasut@gmail.com>
Hi Marek,
Thank you for the patch.
On Wednesday, 9 January 2019 16:00:45 EET marek.vasut@gmail.com wrote:
> From: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> There are two regulator1 nodes in the Ebisu DTS right now, one 3.3V for
> the eMMC and one 12V for the backlight. This causes one to be overwritten
> by the other, ultimatelly resulting in inoperable eMMC, which depends on
> the former. Fix this by renumbering the backlight regulator to regulator2.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-renesas-soc@vger.kernel.org
> Reported-by: Simon Horman <horms+renesas@verge.net.au>
> Fixes: 9d16c4a10e07 ("arm64: dts: renesas: r8a77990: ebisu: Add backlight")
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Sorry for breaking this in the first place.
> ---
> arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index
> e0590c0af4c4..89383aa35d65 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -191,7 +191,7 @@
> clock-frequency = <24576000>;
> };
>
> - reg_12p0v: regulator1 {
> + reg_12p0v: regulator2 {
> compatible = "regulator-fixed";
> regulator-name = "D12.0V";
> regulator-min-microvolt = <12000000>;
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2019-01-10 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 14:00 [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix backlight regulator numbering marek.vasut
2019-01-09 15:26 ` Geert Uytterhoeven
2019-01-09 16:58 ` Simon Horman
2019-01-10 10:02 ` Simon Horman
2019-01-10 13:40 ` Marek Vasut
2019-01-10 12:59 ` Laurent Pinchart
2019-01-10 13:40 ` Marek Vasut
2019-07-31 7:56 ` DTC check_duplicate_node_names (was: Re: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix backlight regulator numbering) Geert Uytterhoeven
2019-01-10 12:59 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1816865.hhpKvpXsC4@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=horms+renesas@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).