From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kirsty.vergenet.net ([202.4.237.240]:36137 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbeIQMgu (ORCPT ); Mon, 17 Sep 2018 08:36:50 -0400 Date: Mon, 17 Sep 2018 09:10:42 +0200 From: Simon Horman To: Geert Uytterhoeven Cc: Laurent Pinchart , Laurent Pinchart , Linux-Renesas Subject: Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support Message-ID: <20180917071041.jobxfznnla3mnuga@verge.net.au> References: <20180819194455.25096-1-laurent.pinchart+renesas@ideasonboard.com> <20180906094231.eccvg2asl7kgotu2@verge.net.au> <2032675.nQfVxexfDx@avalon> <20180912102534.vrocfv2mdrjuk2ev@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Sep 12, 2018 at 01:59:53PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Sep 12, 2018 at 12:25 PM Simon Horman wrote: > > On Thu, Sep 06, 2018 at 12:59:20PM +0300, Laurent Pinchart wrote: > > > On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > > > > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > > > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > > > > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > > > > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test > > > > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > > > > >> switch to keys 1-4 and the push buttons to keys A-C. > > > > >> > > > > >> Signed-off-by: Laurent Pinchart > > > > >> > > > > > > > > > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > > > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > > > > GPIOs connected to both? > > > > > > > > Laurent, any thoughts on that? > > > > > > Right now the GPIOs are not wired in DT, and we're thus without a way to > > > interface to both LEDs and push buttons. While I agree that an ideal > > > solution would be to support both, I think that moving from nothing to > > > support for push buttons would be a step forward already. > > > > I tend to agree. Geert, what are your thoughts? > > Fine for me. > > Just one more bikeshedding question: what's most useful, buttons or LEDs? ;-) Lets go with the buttons. Applied for v4.20.