From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53771C43387 for ; Sun, 16 Dec 2018 20:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10790217FA for ; Sun, 16 Dec 2018 20:17:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="DRe3VPcj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730855AbeLPURq (ORCPT ); Sun, 16 Dec 2018 15:17:46 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:58969 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730828AbeLPURq (ORCPT ); Sun, 16 Dec 2018 15:17:46 -0500 Received: from penelope.horms.nl (ip4dab7138.direct-adsl.nl [77.171.113.56]) by kirsty.vergenet.net (Postfix) with ESMTPA id A022725B764; Mon, 17 Dec 2018 07:17:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1544991464; bh=enJeW2vUocrAUdUmQJ5gPVF5e8D39t5ZITxE7NGL4p4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRe3VPcjXF6kMSO0VQDERNZT5WszbKVs485gkTDBm0dW9cu+woMlwIPZczaXkjPI/ DaM1NWBcTj79kemvjF5uTfo2rGgxKCVHh1eRgM5hqPw3VCx8W8OpJ+lU9TenOLi8Rj 5oxs1rtj4hS6Q5zlt7MZWle8RRrJw5E10fqD/140= Received: by penelope.horms.nl (Postfix, from userid 7100) id 901EBE211F6; Sun, 16 Dec 2018 12:17:41 -0800 (PST) Date: Sun, 16 Dec 2018 21:17:41 +0100 From: Simon Horman To: Fabrizio Castro Cc: Rob Herring , Geert Uytterhoeven , Mark Rutland , Magnus Damm , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Chris Paterson , Biju Das Subject: Re: [PATCH 02/17] arm64: dts: renesas: r8a774c0: Add I2C and IIC-DVFS support Message-ID: <20181216201741.qqwmc44ogqifl52e@verge.net.au> References: <1544780260-27590-1-git-send-email-fabrizio.castro@bp.renesas.com> <1544780260-27590-3-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544780260-27590-3-git-send-email-fabrizio.castro@bp.renesas.com> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Fri, Dec 14, 2018 at 09:37:25AM +0000, Fabrizio Castro wrote: > Add the I2C[0-7] and IIC Bus Interface for DVFS (IIC for DVFS) > devices nodes to the r8a774c0 device tree. > > Signed-off-by: Fabrizio Castro Thanks Fabrizo for this patch, it looks good to me with the exception of one minor question I have below. > --- > arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 143 ++++++++++++++++++++++++++++++ > 1 file changed, 143 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi > index 96a71e3..bf08aba 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi > @@ -271,6 +271,149 @@ > resets = <&cpg 407>; > }; > > + i2c0: i2c@e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6500000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 931>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 931>; > + dmas = <&dmac1 0x91>, <&dmac1 0x90>, > + <&dmac2 0x91>, <&dmac2 0x90>; > + dma-names = "tx", "rx", "tx", "rx"; > + i2c-scl-internal-delay-ns = <110>; > + status = "disabled"; > + }; > + > + i2c1: i2c@e6508000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6508000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 930>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 930>; > + dmas = <&dmac1 0x93>, <&dmac1 0x92>, > + <&dmac2 0x93>, <&dmac2 0x92>; > + dma-names = "tx", "rx", "tx", "rx"; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c2: i2c@e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6510000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 929>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 929>; > + dmas = <&dmac1 0x95>, <&dmac1 0x94>, > + <&dmac2 0x95>, <&dmac2 0x94>; > + dma-names = "tx", "rx", "tx", "rx"; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c3: i2c@e66d0000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66d0000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 928>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 928>; > + dmas = <&dmac0 0x97>, <&dmac0 0x96>; > + dma-names = "tx", "rx"; > + i2c-scl-internal-delay-ns = <110>; > + status = "disabled"; > + }; > + > + i2c4: i2c@e66d8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66d8000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 927>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 927>; > + dmas = <&dmac0 0x99>, <&dmac0 0x98>; > + dma-names = "tx", "rx"; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c5: i2c@e66e0000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66e0000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 919>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 919>; > + dmas = <&dmac0 0x9b>, <&dmac0 0x9a>; > + dma-names = "tx", "rx"; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c6: i2c@e66e8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe66e8000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 918>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 918>; > + dmas = <&dmac0 0x9d>, <&dmac0 0x9c>; > + dma-names = "tx", "rx"; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c7: i2c@e6690000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a774c0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6690000 0 0x40>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 1003>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 1003>; > + i2c-scl-internal-delay-ns = <6>; > + status = "disabled"; > + }; > + > + i2c_dvfs: i2c@e60b0000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a774c0"; > + reg = <0 0xe60b0000 0 0x15>; My reading of the documentation is that 0x31 would be a more appropriate size for the register window. > + interrupts = ; > + clocks = <&cpg CPG_MOD 926>; > + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>; > + resets = <&cpg 926>; > + dmas = <&dmac0 0x11>, <&dmac0 0x10>; > + dma-names = "tx", "rx"; > + status = "disabled"; > + }; > + > hscif0: serial@e6540000 { > compatible = "renesas,hscif-r8a774c0", > "renesas,rcar-gen3-hscif", > -- > 2.7.4 >