From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422DAC43387 for ; Fri, 4 Jan 2019 08:57:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0CF22184B for ; Fri, 4 Jan 2019 08:57:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=verge.net.au header.i=@verge.net.au header.b="NFctYiaQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726749AbfADI5Z (ORCPT ); Fri, 4 Jan 2019 03:57:25 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:49070 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbfADI5Z (ORCPT ); Fri, 4 Jan 2019 03:57:25 -0500 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id 6066525BDE3; Fri, 4 Jan 2019 19:57:23 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1546592243; bh=yDmIWpHVK29vRL1ktAmsAFbLBUbGquJX6bKnk0udasA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NFctYiaQf9aJJ1qDuJXrRVxIgMpSqpSAjFlYaAcauX1SdUcmW8j0tHxLrceaAFTdI TwBKtnoWgw4PYDy+6iVu/aHjlbXOxuIXIJXnQXN/Z/NOoskdzty3agFLbvb94/ux+I GrVjZI3peUtzpDwopd2wssvkoyg4dVDZyxPCmC18= Received: by reginn.horms.nl (Postfix, from userid 7100) id 7154E940376; Fri, 4 Jan 2019 09:57:21 +0100 (CET) Date: Fri, 4 Jan 2019 09:57:21 +0100 From: Simon Horman To: Geert Uytterhoeven Cc: Linux-Renesas , Linux ARM , Magnus Damm Subject: Re: [PATCH v2] arm64: defconfig: Enable R-Car thermal driver Message-ID: <20190104085720.36ccxhtcbyyzgfrk@verge.net.au> References: <20190102095154.25839-1-horms+renesas@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Wed, Jan 02, 2019 at 11:45:37AM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 2, 2019 at 10:53 AM Simon Horman wrote: > > Enable the R-Car thermal driver as a built-in. > > > > This driver is used in conjunction with the R-Car V3M (r8a77970), > > E3 (r8a77990) and D3 (r8a77995) SoCs. > > > [v2] Enable as a built-in rather than a module as this seems > > safer from the point of view of protecting equipment from > > overheating. > > Shouldn't the above paragraph be moved below the ---? I have recently come to believe that its a matter of taste. And I think in this case it captures important information that is worthy of inclusion in the changelog. > > Signed-off-by: Simon Horman > > Reviewed-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >