From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Chris Paterson <Chris.Paterson2@renesas.com>
Subject: Re: [PATCH v2 1/2] pinctrl: sh-pfc: r8a7790: initialize TDSEL register for ES1.0
Date: Tue, 8 Jan 2019 16:07:19 +0100 [thread overview]
Message-ID: <20190108150719.ehb4e5m4ahqluz7h@verge.net.au> (raw)
In-Reply-To: <20190107221320.14930-2-wsa+renesas@sang-engineering.com>
On Mon, Jan 07, 2019 at 11:13:19PM +0100, Wolfram Sang wrote:
> Documentation for ES1.0 says that some bits in TDSEL must be set (ch
> 5.3.39 in R-Car H2 v0.91). However, the reset value of the register is
> 0, so software has to do it. Add this to the kernel driver to ensure
> this is really done independent of firmware versions and use
> whitelisting for ES versions known to need this.
>
> This is needed for some SD cards supporting SDR104 transfer mode. For
> me, TDSEL was not initialized by the firmware and I had problems with
> the card when re-inserting it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2019-01-08 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 22:13 [PATCH v2 0/2] pinctrl: sh-pfc: gen2: initialize TDSEL register for ES1.0 Wolfram Sang
2019-01-07 22:13 ` [PATCH v2 1/2] pinctrl: sh-pfc: r8a7790: " Wolfram Sang
2019-01-08 15:07 ` Simon Horman [this message]
2019-01-09 8:34 ` Geert Uytterhoeven
2019-01-07 22:13 ` [PATCH v2 2/2] pinctrl: sh-pfc: r8a7794: " Wolfram Sang
2019-01-08 15:07 ` Simon Horman
2019-01-09 8:35 ` Geert Uytterhoeven
2019-01-08 11:18 ` [PATCH v2 0/2] pinctrl: sh-pfc: gen2: " Chris Paterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108150719.ehb4e5m4ahqluz7h@verge.net.au \
--to=horms@verge.net.au \
--cc=Chris.Paterson2@renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).