tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git master head: 0fb1d5198b4f389136cbd14013d9e4ae57560481 commit: 268312285e2bc2161b5017d1dbade43af9f17483 [20/21] Merge branch 'gmsl/for-renesas-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar into renesas-drivers config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 268312285e2bc2161b5017d1dbade43af9f17483 # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'ipu3_vb2_start_streaming': >> drivers/staging/media/ipu3/ipu3-v4l2.c:495:27: error: passing argument 1 of 'media_pipeline_start' from incompatible pointer type [-Werror=incompatible-pointer-types] r = media_pipeline_start(&node->vdev.entity, &imgu_pipe->pipeline); ^ In file included from include/media/media-device.h:26:0, from include/media/media-request.h:20, from include/media/v4l2-ctrls.h:23, from drivers/staging/media/ipu3/ipu3.h:10, from drivers/staging/media/ipu3/ipu3-v4l2.c:10: include/media/media-entity.h:1030:18: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *' __must_check int media_pipeline_start(struct media_pad *pad, ^~~~~~~~~~~~~~~~~~~~ >> drivers/staging/media/ipu3/ipu3-v4l2.c:519:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types] media_pipeline_stop(&node->vdev.entity); ^ In file included from include/media/media-device.h:26:0, from include/media/media-request.h:20, from include/media/v4l2-ctrls.h:23, from drivers/staging/media/ipu3/ipu3.h:10, from drivers/staging/media/ipu3/ipu3-v4l2.c:10: include/media/media-entity.h:1055:6: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *' void media_pipeline_stop(struct media_pad *pad); ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/ipu3/ipu3-v4l2.c: In function 'ipu3_vb2_stop_streaming': drivers/staging/media/ipu3/ipu3-v4l2.c:556:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types] media_pipeline_stop(&node->vdev.entity); ^ In file included from include/media/media-device.h:26:0, from include/media/media-request.h:20, from include/media/v4l2-ctrls.h:23, from drivers/staging/media/ipu3/ipu3.h:10, from drivers/staging/media/ipu3/ipu3-v4l2.c:10: include/media/media-entity.h:1055:6: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *' void media_pipeline_stop(struct media_pad *pad); ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/media_pipeline_start +495 drivers/staging/media/ipu3/ipu3-v4l2.c a0ca1627b Yong Zhi 2018-12-06 468 a0ca1627b Yong Zhi 2018-12-06 469 static int ipu3_vb2_start_streaming(struct vb2_queue *vq, unsigned int count) a0ca1627b Yong Zhi 2018-12-06 470 { 51abe041c Bingbu Cao 2018-12-06 471 struct imgu_media_pipe *imgu_pipe; a0ca1627b Yong Zhi 2018-12-06 472 struct imgu_device *imgu = vb2_get_drv_priv(vq); 51abe041c Bingbu Cao 2018-12-06 473 struct device *dev = &imgu->pci_dev->dev; a0ca1627b Yong Zhi 2018-12-06 474 struct imgu_video_device *node = a0ca1627b Yong Zhi 2018-12-06 475 container_of(vq, struct imgu_video_device, vbq); a0ca1627b Yong Zhi 2018-12-06 476 int r; 51abe041c Bingbu Cao 2018-12-06 477 unsigned int pipe; 51abe041c Bingbu Cao 2018-12-06 478 51abe041c Bingbu Cao 2018-12-06 479 dev_dbg(dev, "%s node name %s pipe %d id %u", __func__, 51abe041c Bingbu Cao 2018-12-06 480 node->name, node->pipe, node->id); a0ca1627b Yong Zhi 2018-12-06 481 a0ca1627b Yong Zhi 2018-12-06 482 if (imgu->streaming) { a0ca1627b Yong Zhi 2018-12-06 483 r = -EBUSY; a0ca1627b Yong Zhi 2018-12-06 484 goto fail_return_bufs; a0ca1627b Yong Zhi 2018-12-06 485 } a0ca1627b Yong Zhi 2018-12-06 486 a0ca1627b Yong Zhi 2018-12-06 487 if (!node->enabled) { 51abe041c Bingbu Cao 2018-12-06 488 dev_err(dev, "IMGU node is not enabled"); a0ca1627b Yong Zhi 2018-12-06 489 r = -EINVAL; a0ca1627b Yong Zhi 2018-12-06 490 goto fail_return_bufs; a0ca1627b Yong Zhi 2018-12-06 491 } 51abe041c Bingbu Cao 2018-12-06 492 51abe041c Bingbu Cao 2018-12-06 493 pipe = node->pipe; 51abe041c Bingbu Cao 2018-12-06 494 imgu_pipe = &imgu->imgu_pipe[pipe]; 51abe041c Bingbu Cao 2018-12-06 @495 r = media_pipeline_start(&node->vdev.entity, &imgu_pipe->pipeline); a0ca1627b Yong Zhi 2018-12-06 496 if (r < 0) a0ca1627b Yong Zhi 2018-12-06 497 goto fail_return_bufs; a0ca1627b Yong Zhi 2018-12-06 498 51abe041c Bingbu Cao 2018-12-06 499 a0ca1627b Yong Zhi 2018-12-06 500 if (!ipu3_all_nodes_streaming(imgu, node)) a0ca1627b Yong Zhi 2018-12-06 501 return 0; a0ca1627b Yong Zhi 2018-12-06 502 51abe041c Bingbu Cao 2018-12-06 503 for_each_set_bit(pipe, imgu->css.enabled_pipes, IMGU_MAX_PIPE_NUM) { 51abe041c Bingbu Cao 2018-12-06 504 r = v4l2_subdev_call(&imgu->imgu_pipe[pipe].imgu_sd.subdev, 51abe041c Bingbu Cao 2018-12-06 505 video, s_stream, 1); a0ca1627b Yong Zhi 2018-12-06 506 if (r < 0) a0ca1627b Yong Zhi 2018-12-06 507 goto fail_stop_pipeline; 51abe041c Bingbu Cao 2018-12-06 508 } 51abe041c Bingbu Cao 2018-12-06 509 51abe041c Bingbu Cao 2018-12-06 510 /* Start streaming of the whole pipeline now */ 51abe041c Bingbu Cao 2018-12-06 511 dev_dbg(dev, "IMGU streaming is ready to start"); 51abe041c Bingbu Cao 2018-12-06 512 r = imgu_s_stream(imgu, true); 51abe041c Bingbu Cao 2018-12-06 513 if (!r) 51abe041c Bingbu Cao 2018-12-06 514 imgu->streaming = true; a0ca1627b Yong Zhi 2018-12-06 515 a0ca1627b Yong Zhi 2018-12-06 516 return 0; a0ca1627b Yong Zhi 2018-12-06 517 a0ca1627b Yong Zhi 2018-12-06 518 fail_stop_pipeline: a0ca1627b Yong Zhi 2018-12-06 @519 media_pipeline_stop(&node->vdev.entity); a0ca1627b Yong Zhi 2018-12-06 520 fail_return_bufs: a0ca1627b Yong Zhi 2018-12-06 521 ipu3_return_all_buffers(imgu, node, VB2_BUF_STATE_QUEUED); a0ca1627b Yong Zhi 2018-12-06 522 a0ca1627b Yong Zhi 2018-12-06 523 return r; a0ca1627b Yong Zhi 2018-12-06 524 } a0ca1627b Yong Zhi 2018-12-06 525 :::::: The code at line 495 was first introduced by commit :::::: 51abe041c5ed56efbdd944cbd45d27e2cd711406 media: staging/intel-ipu3: Add dual pipe support :::::: TO: Bingbu Cao :::::: CC: Mauro Carvalho Chehab --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation