Re: [PATCH 0/4] pinctrl: sh-pfc: rcar-gen3: Deduplicate remaining VIN pin definitions

[Jacopo Mondi <jacopo@jmondi.org>]

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

Hi Geert,

On Fri, Jan 11, 2019 at 01:27:01PM +0100, Geert Uytterhoeven wrote:
> 	Hi,
>
> As of commit 50f3f2d73e3426ba ("pinctrl: sh-pfc: Reduce kernel size for
> narrow VIN channels"), the infrastructure is available to avoid
> duplication of pin definitions for narrow Video IN (VIN) channels.
> Make use of his to deduplicate the remaining VIN pin definitions on
> R-Car Gen3 SoCS.
>
> This is similar to what was done before for the wide VIN channels e.g.
> commit 9942a5b52990b8d5 ("pinctrl: sh-pfc: r8a7795: Deduplicate VIN4 pin
> definitions").
>
> This reduces kernel size for an R-Car Gen3 kernel by almost 1 KiB.
>
> I plan to queue these in sh-pfc-for-v5.1.
>
> Thanks!

Thanks for this. I have compared the new tables in the series with the
removed ones (but not against the datasheet, as I assume what was
already in the driver is correct).

Please add:
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Thanks
  j

>
> Geert Uytterhoeven (4):
>   pinctrl: sh-pfc: r8a7795: Deduplicate VIN5 pin definitions
>   pinctrl: sh-pfc: r8a7796: Deduplicate VIN5 pin definitions
>   pinctrl: sh-pfc: r8a77970: Deduplicate VIN[01] pin definitions
>   pinctrl: sh-pfc: r8a77980: Deduplicate VIN1 pin definitions
>
>  drivers/pinctrl/sh-pfc/pfc-r8a7795.c  |  90 ++++++------------
>  drivers/pinctrl/sh-pfc/pfc-r8a7796.c  |  90 ++++++------------
>  drivers/pinctrl/sh-pfc/pfc-r8a77970.c | 128 +++++++++-----------------
>  drivers/pinctrl/sh-pfc/pfc-r8a77980.c |  64 +++++--------
>  4 files changed, 115 insertions(+), 257 deletions(-)
>
> --
> 2.17.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]