From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCC1C43612 for ; Mon, 14 Jan 2019 14:44:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C4DD2086D for ; Mon, 14 Jan 2019 14:44:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="fILeBQjR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbfANOou (ORCPT ); Mon, 14 Jan 2019 09:44:50 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:33888 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbfANOou (ORCPT ); Mon, 14 Jan 2019 09:44:50 -0500 Received: by mail-lf1-f67.google.com with SMTP id p6so15805420lfc.1 for ; Mon, 14 Jan 2019 06:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7u/LtLG4xXiRck2kcwHfI1Xvp/3OjjIYUFQPxEIo9fQ=; b=fILeBQjRrForbqFfFKIhXeICrUBox2JSkfxdupU2aMb2Pxrd18n7WIIh+H1tkq6NCZ 9malKJb+L3c/l7/BH1Yfi73uN+ZKr6x+R1fC6OJan92FszvrZd1a6GJlfogmyvu4zexi F7KoJ+x+gFNh+Jc8wIsMhZxWVqqJMAqok9dH5OI9KE/xPOSsBXYwwZdmwyjqetU6hNf8 fP+htxz6GmrSyum0q5VDc8T3prVIYUe6BfZzB5GMrx1eNVY037eDpRJT+z1arbRx/EST xGWkIB60Z/8AkeqqYk+zSiQpdWQeMudNud7rnOgBpoxPC4dZxMl7ppg0VsBSPnEpnepw Vekw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7u/LtLG4xXiRck2kcwHfI1Xvp/3OjjIYUFQPxEIo9fQ=; b=fw/hCiRs72PgunvYgjlpiM+ODe9K0Z3pNsBSBOsSN+87xaDknRhPmqD/3qArAUOHJA AqsRxrNMuJyq/Cyl+OL1kmXZ6fxaYYZ9Zi8RTDBGq5VyT/hznM7UNdjGmDe+NRZIiX2N ycTQ/U+24z2Vst+oqxteZqkI3oOPK54zlhCN0JYwsPG0F0afranafk5SQPfOokpfIQyD qEW/S5XkbxrwsZ3fVIzuxPkmdYKkubJQPuXY95zyb+d8qyiUskQix5OhG3PafEInutdk W2V5EZZA+T4XzJOqWrGXq6L2tnbR5KLXt3kI0/zbmptuyJ686LJ2QbcQKtJXZDd11Ozb qiTQ== X-Gm-Message-State: AJcUukdr0NKosUaveIDEfXXyFt4n7HCulmwsTb/Hb1MjMvBJrs8YAe52 UmZoxEXaGhpVOYMHqUS3u5+78WKBMk0= X-Google-Smtp-Source: ALg8bN4NOcWNjt5auyFbt7Gl1sTchzPXnE37SKWTMHpkYEEQ68vzdMqPd0MPVF7t+/p0UrvBmPkMkw== X-Received: by 2002:a19:d04d:: with SMTP id h74mr13144988lfg.52.1547477087761; Mon, 14 Jan 2019 06:44:47 -0800 (PST) Received: from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99]) by smtp.gmail.com with ESMTPSA id j197sm114409lfe.24.2019.01.14.06.44.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 06:44:47 -0800 (PST) Date: Mon, 14 Jan 2019 15:44:46 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Kieran Bingham Cc: Koji Matsuoka , Jacopo Mondi , Laurent Pinchart , Steve Longerbeam , linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 2/2] media: i2c: adv748x: Remove PAGE_WAIT Message-ID: <20190114144446.GH30160@bigcity.dyn.berto.se> References: <20190111174141.12594-1-kieran.bingham+renesas@ideasonboard.com> <20190111174141.12594-3-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190111174141.12594-3-kieran.bingham+renesas@ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Kieran, Thanks for your patch. On 2019-01-11 17:41:41 +0000, Kieran Bingham wrote: > The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the > register tables. > > Its only usage was removed, so we can remove the handling and simplify > the code. > > Signed-off-by: Kieran Bingham With the change Laurent points out, Reviewed-by: Niklas Söderlund > --- > drivers/media/i2c/adv748x/adv748x-core.c | 17 ++++++----------- > drivers/media/i2c/adv748x/adv748x.h | 1 - > 2 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 252bdb28b18b..8199e0b20790 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -219,18 +219,13 @@ static int adv748x_write_regs(struct adv748x_state *state, > int ret; > > while (regs->page != ADV748X_PAGE_EOR) { > - if (regs->page == ADV748X_PAGE_WAIT) { > - msleep(regs->value); > - } else { > - ret = adv748x_write(state, regs->page, regs->reg, > - regs->value); > - if (ret < 0) { > - adv_err(state, > - "Error regs page: 0x%02x reg: 0x%02x\n", > - regs->page, regs->reg); > - return ret; > - } > + ret = adv748x_write(state, regs->page, regs->reg, regs->value); > + if (ret < 0) { > + adv_err(state, "Error regs page: 0x%02x reg: 0x%02x\n", > + regs->page, regs->reg); > + return ret; > } > + > regs++; > } > > diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h > index 2f8d751cfbb0..5042f9e94aee 100644 > --- a/drivers/media/i2c/adv748x/adv748x.h > +++ b/drivers/media/i2c/adv748x/adv748x.h > @@ -39,7 +39,6 @@ enum adv748x_page { > ADV748X_PAGE_MAX, > > /* Fake pages for register sequences */ > - ADV748X_PAGE_WAIT, /* Wait x msec */ > ADV748X_PAGE_EOR, /* End Mark */ > }; > > -- > 2.17.1 > -- Regards, Niklas Söderlund