linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: shmobile: r8a7779: HSCIF support
@ 2019-01-18 10:48 Ulrich Hecht
  2019-01-18 10:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins Ulrich Hecht
  2019-01-18 10:48 ` [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes Ulrich Hecht
  0 siblings, 2 replies; 10+ messages in thread
From: Ulrich Hecht @ 2019-01-18 10:48 UTC (permalink / raw)
  To: geert, linux-renesas-soc; +Cc: horms, linux-serial, magnus.damm, Ulrich Hecht

Hi!

This is the r8a7779 portion of the ancient "ARM: dts: r8a777[89]: HSCIF
support" series, this time with PFC support and with the address sizes and
clock indices fixed in the device tree. Thanks to Geert for the review.

This series is untested because I do not have up-close access to a Marzen
board at this time.

CU
Uli


Ulrich Hecht (2):
  pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins
  ARM: dts: r8a7779: Add HSCIF0/1 device nodes

 arch/arm/boot/dts/r8a7779.dtsi       |  26 +++++++++
 drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 106 +++++++++++++++++++++++++++++++++++
 2 files changed, 132 insertions(+)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins
  2019-01-18 10:48 [PATCH 0/2] ARM: shmobile: r8a7779: HSCIF support Ulrich Hecht
@ 2019-01-18 10:48 ` Ulrich Hecht
  2019-01-18 12:03   ` Simon Horman
  2019-01-18 12:16   ` Geert Uytterhoeven
  2019-01-18 10:48 ` [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes Ulrich Hecht
  1 sibling, 2 replies; 10+ messages in thread
From: Ulrich Hecht @ 2019-01-18 10:48 UTC (permalink / raw)
  To: geert, linux-renesas-soc; +Cc: horms, linux-serial, magnus.damm, Ulrich Hecht

Adds HSCIF0 and HSCIF1 pins, groups and functions for R8A7779.

Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 106 +++++++++++++++++++++++++++++++++++
 1 file changed, 106 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
index 64bace1..4ffeeab 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
@@ -1595,6 +1595,80 @@ static const unsigned int ether_magic_pins[] = {
 static const unsigned int ether_magic_mux[] = {
 	ETH_MAGIC_MARK,
 };
+/* - HSCIF0 ----------------------------------------------------------------- */
+static const unsigned int hscif0_data_pins[] = {
+	RCAR_GP_PIN(4, 20), RCAR_GP_PIN(4, 21)
+};
+static const unsigned int hscif0_data_mux[] = {
+	HTX0_MARK, HRX0_MARK
+};
+static const unsigned int hscif0_data_b_pins[] = {
+	RCAR_GP_PIN(3, 12), RCAR_GP_PIN(3, 13)
+};
+static const unsigned int hscif0_data_b_mux[] = {
+	HTX0_B_MARK, HRX0_B_MARK
+};
+static const unsigned int hscif0_ctrl_pins[] = {
+	RCAR_GP_PIN(4, 18), RCAR_GP_PIN(4, 19)
+};
+static const unsigned int hscif0_ctrl_mux[] = {
+	HCTS0_MARK, HRTS0_MARK
+};
+static const unsigned int hscif0_ctrl_b_pins[] = {
+	RCAR_GP_PIN(3, 9), RCAR_GP_PIN(3, 10)
+};
+static const unsigned int hscif0_ctrl_b_mux[] = {
+	HCTS0_B_MARK, HRTS0_B_MARK
+};
+static const unsigned int hscif0_clk_pins[] = {
+	RCAR_GP_PIN(4, 17)
+};
+static const unsigned int hscif0_clk_mux[] = {
+	HSCK0_MARK
+};
+static const unsigned int hscif0_clk_b_pins[] = {
+	RCAR_GP_PIN(3, 11)
+};
+static const unsigned int hscif0_clk_b_mux[] = {
+	HSCK0_B_MARK
+};
+/* - HSCIF1 ----------------------------------------------------------------- */
+static const unsigned int hscif1_data_pins[] = {
+	RCAR_GP_PIN(0, 19), RCAR_GP_PIN(0, 20)
+};
+static const unsigned int hscif1_data_mux[] = {
+	HTX1_MARK, HRX1_MARK
+};
+static const unsigned int hscif1_data_b_pins[] = {
+	RCAR_GP_PIN(2, 2), RCAR_GP_PIN(2, 3)
+};
+static const unsigned int hscif1_data_b_mux[] = {
+	HTX1_B_MARK, HRX1_B_MARK
+};
+static const unsigned int hscif1_ctrl_pins[] = {
+	RCAR_GP_PIN(0, 21), RCAR_GP_PIN(0, 22)
+};
+static const unsigned int hscif1_ctrl_mux[] = {
+	HCTS1_MARK, HRTS1_MARK
+};
+static const unsigned int hscif1_ctrl_b_pins[] = {
+	RCAR_GP_PIN(2, 7), RCAR_GP_PIN(2, 6)
+};
+static const unsigned int hscif1_ctrl_b_mux[] = {
+	HCTS1_B_MARK, HRTS1_B_MARK
+};
+static const unsigned int hscif1_clk_pins[] = {
+	RCAR_GP_PIN(0, 18)
+};
+static const unsigned int hscif1_clk_mux[] = {
+	HSCK1_MARK
+};
+static const unsigned int hscif1_b_clk_pins[] = {
+	RCAR_GP_PIN(2, 4)
+};
+static const unsigned int hscif1_b_clk_mux[] = {
+	HSCK1_B_MARK
+};
 /* - HSPI0 ------------------------------------------------------------------ */
 static const unsigned int hspi0_pins[] = {
 	/* CLK, CS, RX, TX */
@@ -2618,6 +2692,18 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
 	SH_PFC_PIN_GROUP(ether_rmii),
 	SH_PFC_PIN_GROUP(ether_link),
 	SH_PFC_PIN_GROUP(ether_magic),
+	SH_PFC_PIN_GROUP(hscif0_data),
+	SH_PFC_PIN_GROUP(hscif0_data_b),
+	SH_PFC_PIN_GROUP(hscif0_ctrl),
+	SH_PFC_PIN_GROUP(hscif0_ctrl_b),
+	SH_PFC_PIN_GROUP(hscif0_clk),
+	SH_PFC_PIN_GROUP(hscif0_clk_b),
+	SH_PFC_PIN_GROUP(hscif1_data),
+	SH_PFC_PIN_GROUP(hscif1_data_b),
+	SH_PFC_PIN_GROUP(hscif1_ctrl),
+	SH_PFC_PIN_GROUP(hscif1_ctrl_b),
+	SH_PFC_PIN_GROUP(hscif1_clk),
+	SH_PFC_PIN_GROUP(hscif1_clk_b),
 	SH_PFC_PIN_GROUP(hspi0),
 	SH_PFC_PIN_GROUP(hspi1),
 	SH_PFC_PIN_GROUP(hspi1_b),
@@ -2783,6 +2869,24 @@ static const char * const ether_groups[] = {
 	"ether_magic",
 };
 
+static const char * const hscif0_groups[] = {
+	"hscif0_data",
+	"hscif0_data_b",
+	"hscif0_ctrl",
+	"hscif0_ctrl_b",
+	"hscif0_clk",
+	"hscif0_clk_b",
+};
+
+static const char * const hscif1_groups[] = {
+	"hscif1_data",
+	"hscif1_data_b",
+	"hscif1_ctrl",
+	"hscif1_ctrl_b",
+	"hscif1_clk",
+	"hscif1_clk_b",
+};
+
 static const char * const hspi0_groups[] = {
 	"hspi0",
 };
@@ -3005,6 +3109,8 @@ static const struct sh_pfc_function pinmux_functions[] = {
 	SH_PFC_FUNCTION(du0),
 	SH_PFC_FUNCTION(du1),
 	SH_PFC_FUNCTION(ether),
+	SH_PFC_FUNCTION(hscif0),
+	SH_PFC_FUNCTION(hscif1),
 	SH_PFC_FUNCTION(hspi0),
 	SH_PFC_FUNCTION(hspi1),
 	SH_PFC_FUNCTION(hspi2),
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes
  2019-01-18 10:48 [PATCH 0/2] ARM: shmobile: r8a7779: HSCIF support Ulrich Hecht
  2019-01-18 10:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins Ulrich Hecht
@ 2019-01-18 10:48 ` Ulrich Hecht
  2019-01-18 11:58   ` Geert Uytterhoeven
  2019-01-18 12:04   ` Simon Horman
  1 sibling, 2 replies; 10+ messages in thread
From: Ulrich Hecht @ 2019-01-18 10:48 UTC (permalink / raw)
  To: geert, linux-renesas-soc; +Cc: horms, linux-serial, magnus.damm, Ulrich Hecht

Based on Rev. 1.00 of the R-Car H1 datasheet.

Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
---
 arch/arm/boot/dts/r8a7779.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
index 3bc133d..34e468c 100644
--- a/arch/arm/boot/dts/r8a7779.dtsi
+++ b/arch/arm/boot/dts/r8a7779.dtsi
@@ -287,6 +287,32 @@
 		status = "disabled";
 	};
 
+	hscif0: serial@ffe48000 {
+		compatible = "renesas,hscif-r8a7779",
+			     "renesas,rcar-gen1-hscif", "renesas,hscif";
+		reg = <0xffe48000 96>;
+		interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp0_clks R8A7779_CLK_HSCIF0>,
+			 <&cpg_clocks R8A7779_CLK_S>,
+			 <&scif_clk>;
+		clock-names = "fck", "brg_int", "scif_clk";
+		power-domains = <&cpg_clocks>;
+		status = "disabled";
+	};
+
+	hscif1: serial@ffe49000 {
+		compatible = "renesas,hscif-r8a7779",
+			     "renesas,rcar-gen1-hscif", "renesas,hscif";
+		reg = <0xffe49000 96>;
+		interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp0_clks R8A7779_CLK_HSCIF1,
+			 <&cpg_clocks R8A7779_CLK_S>,
+			 <&scif_clk>;
+		clock-names = "fck", "brg_int", "scif_clk";
+		power-domains = <&cpg_clocks>;
+		status = "disabled";
+	};
+
 	pfc: pin-controller@fffc0000 {
 		compatible = "renesas,pfc-r8a7779";
 		reg = <0xfffc0000 0x23c>;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes
  2019-01-18 10:48 ` [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes Ulrich Hecht
@ 2019-01-18 11:58   ` Geert Uytterhoeven
  2019-01-18 12:18     ` Simon Horman
  2019-01-18 12:04   ` Simon Horman
  1 sibling, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-01-18 11:58 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: Linux-Renesas, Simon Horman, open list:SERIAL DRIVERS, Magnus Damm

Hi Uli,

On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote:
> Based on Rev. 1.00 of the R-Car H1 datasheet.
>
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>

Thanks for the update!

> --- a/arch/arm/boot/dts/r8a7779.dtsi
> +++ b/arch/arm/boot/dts/r8a7779.dtsi

> +       hscif1: serial@ffe49000 {
> +               compatible = "renesas,hscif-r8a7779",
> +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> +               reg = <0xffe49000 96>;
> +               interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF1,

Missing closing ">".

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins
  2019-01-18 10:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins Ulrich Hecht
@ 2019-01-18 12:03   ` Simon Horman
  2019-01-18 12:16   ` Geert Uytterhoeven
  1 sibling, 0 replies; 10+ messages in thread
From: Simon Horman @ 2019-01-18 12:03 UTC (permalink / raw)
  To: Ulrich Hecht; +Cc: geert, linux-renesas-soc, linux-serial, magnus.damm

On Fri, Jan 18, 2019 at 11:48:14AM +0100, Ulrich Hecht wrote:
> Adds HSCIF0 and HSCIF1 pins, groups and functions for R8A7779.
> 
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
> ---
>  drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 106 +++++++++++++++++++++++++++++++++++
>  1 file changed, 106 insertions(+)

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes
  2019-01-18 10:48 ` [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes Ulrich Hecht
  2019-01-18 11:58   ` Geert Uytterhoeven
@ 2019-01-18 12:04   ` Simon Horman
  1 sibling, 0 replies; 10+ messages in thread
From: Simon Horman @ 2019-01-18 12:04 UTC (permalink / raw)
  To: Ulrich Hecht; +Cc: geert, linux-renesas-soc, linux-serial, magnus.damm

On Fri, Jan 18, 2019 at 11:48:15AM +0100, Ulrich Hecht wrote:
> Based on Rev. 1.00 of the R-Car H1 datasheet.
> 
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins
  2019-01-18 10:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins Ulrich Hecht
  2019-01-18 12:03   ` Simon Horman
@ 2019-01-18 12:16   ` Geert Uytterhoeven
  1 sibling, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-01-18 12:16 UTC (permalink / raw)
  To: Ulrich Hecht
  Cc: Linux-Renesas, Simon Horman, open list:SERIAL DRIVERS, Magnus Damm

Hi Uli,

On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote:
> Adds HSCIF0 and HSCIF1 pins, groups and functions for R8A7779.
>
> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>

Thanks for your patch!

> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -1595,6 +1595,80 @@ static const unsigned int ether_magic_pins[] = {
>  static const unsigned int ether_magic_mux[] = {
>         ETH_MAGIC_MARK,
>  };
> +/* - HSCIF0 ----------------------------------------------------------------- */
> +static const unsigned int hscif0_data_pins[] = {
> +       RCAR_GP_PIN(4, 20), RCAR_GP_PIN(4, 21)

Can you please add TXD, RXD etc. comments, like are present for all other pin
groups?

> +static const unsigned int hscif1_b_clk_pins[] = {

error: ‘hscif1_clk_b_pins’ undeclared here

hscif1_clk_b_pins

> +       RCAR_GP_PIN(2, 4)
> +};
> +static const unsigned int hscif1_b_clk_mux[] = {

hscif1_clk_b_mux

> +       HSCK1_B_MARK
> +};
>  /* - HSPI0 ------------------------------------------------------------------ */
>  static const unsigned int hspi0_pins[] = {
>         /* CLK, CS, RX, TX */

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes
  2019-01-18 11:58   ` Geert Uytterhoeven
@ 2019-01-18 12:18     ` Simon Horman
  2019-01-18 12:48       ` Geert Uytterhoeven
  0 siblings, 1 reply; 10+ messages in thread
From: Simon Horman @ 2019-01-18 12:18 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Ulrich Hecht, Linux-Renesas, open list:SERIAL DRIVERS, Magnus Damm

On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote:
> Hi Uli,
> 
> On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote:
> > Based on Rev. 1.00 of the R-Car H1 datasheet.
> >
> > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
> 
> Thanks for the update!
> 
> > --- a/arch/arm/boot/dts/r8a7779.dtsi
> > +++ b/arch/arm/boot/dts/r8a7779.dtsi
> 
> > +       hscif1: serial@ffe49000 {
> > +               compatible = "renesas,hscif-r8a7779",
> > +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> > +               reg = <0xffe49000 96>;
> > +               interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> > +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF1,
> 
> Missing closing ">".
> 
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied with that fixed.

Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes
  2019-01-18 12:18     ` Simon Horman
@ 2019-01-18 12:48       ` Geert Uytterhoeven
  2019-01-20  8:30         ` Simon Horman
  0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-01-18 12:48 UTC (permalink / raw)
  To: Simon Horman
  Cc: Ulrich Hecht, Linux-Renesas, open list:SERIAL DRIVERS, Magnus Damm

Hi Simon,

On Fri, Jan 18, 2019 at 1:18 PM Simon Horman <horms@verge.net.au> wrote:
> On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote:
> > On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote:
> > > --- a/arch/arm/boot/dts/r8a7779.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7779.dtsi
> >
> > > +       hscif1: serial@ffe49000 {
> > > +               compatible = "renesas,hscif-r8a7779",
> > > +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> > > +               reg = <0xffe49000 96>;
> > > +               interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> > > +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF1,
> >
> > Missing closing ">".
> >
> > With the above fixed:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks, applied with that fixed.

Thanks!

> Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding?

I believe you were CCed by Greg's bot for

    patch "dt-bindings: serial: sh-sci: Document r8a7778/9 HSCIF
bindings" added to tty-testing

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes
  2019-01-18 12:48       ` Geert Uytterhoeven
@ 2019-01-20  8:30         ` Simon Horman
  0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2019-01-20  8:30 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Ulrich Hecht, Linux-Renesas, open list:SERIAL DRIVERS, Magnus Damm

On Fri, Jan 18, 2019 at 01:48:41PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Jan 18, 2019 at 1:18 PM Simon Horman <horms@verge.net.au> wrote:
> > On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@fpond.eu> wrote:
> > > > --- a/arch/arm/boot/dts/r8a7779.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7779.dtsi
> > >
> > > > +       hscif1: serial@ffe49000 {
> > > > +               compatible = "renesas,hscif-r8a7779",
> > > > +                            "renesas,rcar-gen1-hscif", "renesas,hscif";
> > > > +               reg = <0xffe49000 96>;
> > > > +               interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> > > > +               clocks = <&mstp0_clks R8A7779_CLK_HSCIF1,
> > >
> > > Missing closing ">".
> > >
> > > With the above fixed:
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Thanks, applied with that fixed.
> 
> Thanks!
> 
> > Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding?
> 
> I believe you were CCed by Greg's bot for
> 
>     patch "dt-bindings: serial: sh-sci: Document r8a7778/9 HSCIF
> bindings" added to tty-testing

Thanks, indeed I was.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-01-20  8:30 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 10:48 [PATCH 0/2] ARM: shmobile: r8a7779: HSCIF support Ulrich Hecht
2019-01-18 10:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7779: add HSCIF0/1 pins Ulrich Hecht
2019-01-18 12:03   ` Simon Horman
2019-01-18 12:16   ` Geert Uytterhoeven
2019-01-18 10:48 ` [PATCH 2/2] ARM: dts: r8a7779: Add HSCIF0/1 device nodes Ulrich Hecht
2019-01-18 11:58   ` Geert Uytterhoeven
2019-01-18 12:18     ` Simon Horman
2019-01-18 12:48       ` Geert Uytterhoeven
2019-01-20  8:30         ` Simon Horman
2019-01-18 12:04   ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).