* [PATCH v2] arm64: dts: renesas: r8a77990: ebisu: Enable HS400 of SDHI3
@ 2019-01-18 12:25 Simon Horman
2019-01-18 13:31 ` Geert Uytterhoeven
2019-01-19 22:22 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Simon Horman @ 2019-01-18 12:25 UTC (permalink / raw)
To: linux-renesas-soc
Cc: linux-arm-kernel, Magnus Damm, Wolfram Sang,
Niklas Söderlund, Simon Horman
Enable HS400 of SDHI3 using the corresponding DT property.
No further changes are required.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Tested on top of renesas-devel-20190110-v5.0-rc1
---
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 89383aa35d65..144c0820cf60 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -695,6 +695,7 @@
vmmc-supply = <®_3p3v>;
vqmmc-supply = <®_1p8v>;
mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
bus-width = <8>;
non-removable;
status = "okay";
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: renesas: r8a77990: ebisu: Enable HS400 of SDHI3
2019-01-18 12:25 [PATCH v2] arm64: dts: renesas: r8a77990: ebisu: Enable HS400 of SDHI3 Simon Horman
@ 2019-01-18 13:31 ` Geert Uytterhoeven
2019-01-19 22:22 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-01-18 13:31 UTC (permalink / raw)
To: Simon Horman
Cc: Linux-Renesas, Linux ARM, Magnus Damm, Wolfram Sang,
Niklas Söderlund
Hi Simon,
On Fri, Jan 18, 2019 at 1:25 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> Enable HS400 of SDHI3 using the corresponding DT property.
> No further changes are required.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Using "hdparm -tT /dev/mmcblk0"
HS200:
Timing cached reads: 694 MB in 2.00 seconds = 346.60 MB/sec
Timing buffered disk reads: 434 MB in 3.00 seconds = 144.56 MB/sec
HS400:
Timing cached reads: 696 MB in 2.00 seconds = 348.20 MB/sec
Timing buffered disk reads: 446 MB in 3.00 seconds = 148.65 MB/sec
No real difference.
Note that "dd" gives me very fluctuating results (all for HS400):
root@ebisu:~# dd if=/dev/mmcblk0 of=/dev/null bs=1M count=128 iflag=direct
128+0 records in
128+0 records out
134217728 bytes (134 MB, 128 MiB) copied, 3.20103 s, 41.9 MB/s
root@ebisu:~# dd if=/dev/mmcblk0 of=/dev/null bs=1M count=128 iflag=direct
128+0 records in
128+0 records out
134217728 bytes (134 MB, 128 MiB) copied, 1.15324 s, 116 MB/s
128+0 records in
128+0 records out
134217728 bytes (134 MB, 128 MiB) copied, 1.82701 s, 73.5 MB/s
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: renesas: r8a77990: ebisu: Enable HS400 of SDHI3
2019-01-18 12:25 [PATCH v2] arm64: dts: renesas: r8a77990: ebisu: Enable HS400 of SDHI3 Simon Horman
2019-01-18 13:31 ` Geert Uytterhoeven
@ 2019-01-19 22:22 ` Wolfram Sang
2019-01-21 16:57 ` Simon Horman
1 sibling, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2019-01-19 22:22 UTC (permalink / raw)
To: Simon Horman
Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm, Wolfram Sang,
Niklas Söderlund
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
On Fri, Jan 18, 2019 at 01:25:36PM +0100, Simon Horman wrote:
> Enable HS400 of SDHI3 using the corresponding DT property.
> No further changes are required.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
We might need to find an explanation for the performance numbers,
nontheless this patch is correct.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: renesas: r8a77990: ebisu: Enable HS400 of SDHI3
2019-01-19 22:22 ` Wolfram Sang
@ 2019-01-21 16:57 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2019-01-21 16:57 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm, Wolfram Sang,
Niklas Söderlund
On Sat, Jan 19, 2019 at 11:22:20PM +0100, Wolfram Sang wrote:
> On Fri, Jan 18, 2019 at 01:25:36PM +0100, Simon Horman wrote:
> > Enable HS400 of SDHI3 using the corresponding DT property.
> > No further changes are required.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> We might need to find an explanation for the performance numbers,
> nontheless this patch is correct.
Thanks, I think we can queue this up for mainline and I have done so for
v5.1.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-21 16:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 12:25 [PATCH v2] arm64: dts: renesas: r8a77990: ebisu: Enable HS400 of SDHI3 Simon Horman
2019-01-18 13:31 ` Geert Uytterhoeven
2019-01-19 22:22 ` Wolfram Sang
2019-01-21 16:57 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).