From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings
Date: Tue, 22 Jan 2019 19:13:25 +0200 [thread overview]
Message-ID: <20190122171325.GC26166@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1548170749-12773-2-git-send-email-biju.das@bp.renesas.com>
Hi Biju,
Thank you for the patch.
On Tue, Jan 22, 2019 at 03:25:45PM +0000, Biju Das wrote:
> The internal LVDS encoder now has DT bindings separate from the DU. Port
> the device tree over to the new model.
>
> Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver")
Sorry for the breakage. The DT and DU series raced each other, but I
should have still caught it.
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I expect Simon to pick this up.
> ---
> arch/arm/boot/dts/r8a7743.dtsi | 36 ++++++++++++++++++++++++++++++------
> 1 file changed, 30 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 24e6c2b..de981d6 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -1660,15 +1660,12 @@
>
> du: display@feb00000 {
> compatible = "renesas,du-r8a7743";
> - reg = <0 0xfeb00000 0 0x40000>,
> - <0 0xfeb90000 0 0x1c>;
> - reg-names = "du", "lvds.0";
> + reg = <0 0xfeb00000 0 0x40000>;
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> - <&cpg CPG_MOD 726>;
> - clock-names = "du.0", "du.1", "lvds.0";
> + <&cpg CPG_MOD 723>;
> + clock-names = "du.0", "du.1";
> status = "disabled";
>
> ports {
> @@ -1683,6 +1680,33 @@
> port@1 {
> reg = <1>;
> du_out_lvds0: endpoint {
> + remote-endpoint = <&lvds0_in>;
> + };
> + };
> + };
> + };
> +
> + lvds0: lvds@feb90000 {
> + compatible = "renesas,r8a7743-lvds";
> + reg = <0 0xfeb90000 0 0x1c>;
> + clocks = <&cpg CPG_MOD 726>;
> + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> + resets = <&cpg 726>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + lvds0_in: endpoint {
> + remote-endpoint = <&du_out_lvds0>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + lvds0_out: endpoint {
> };
> };
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-01-22 17:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:25 [PATCH v3 0/5] Add Display support Biju Das
2019-01-22 15:25 ` [PATCH v3 1/5] ARM: dts: r8a7743: Convert to new LVDS DT bindings Biju Das
2019-01-22 17:13 ` Laurent Pinchart [this message]
2019-01-23 9:01 ` Simon Horman
2019-01-22 15:25 ` [PATCH v3 2/5] dt-bindings: display: renesas: lvds: Document r8a7744 bindings Biju Das
2019-01-22 15:44 ` Laurent Pinchart
2019-01-23 8:59 ` Simon Horman
2019-01-30 16:39 ` Rob Herring
2019-02-01 15:16 ` Laurent Pinchart
2019-01-30 16:39 ` Rob Herring
2019-01-22 15:25 ` [PATCH v3 3/5] drm: rcar-du: lvds: Add r8a7744 support Biju Das
2019-01-22 15:45 ` Laurent Pinchart
2019-01-23 8:59 ` Simon Horman
2019-01-22 15:25 ` [PATCH v3 4/5] ARM: dts: r8a7744: Add DU support Biju Das
2019-01-22 17:07 ` Laurent Pinchart
2019-01-23 9:02 ` Simon Horman
2019-01-22 15:25 ` [PATCH v3 5/5] ARM: dts: r8a7744: Add LVDS support Biju Das
2019-01-22 17:14 ` Laurent Pinchart
2019-01-23 9:03 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122171325.GC26166@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).