* [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes
@ 2019-01-25 15:48 Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 1/4] pinctrl: sh-pfc: emev2: Add missing pinmux functions Geert Uytterhoeven
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-01-25 15:48 UTC (permalink / raw)
To: Linus Walleij
Cc: Niklas Söderlund, Sergei Shtylyov, Laurent Pinchart,
linux-renesas-soc, linux-gpio, Geert Uytterhoeven
Hi Linus,
This patch series contains 4 pinmux functions for Renesas SoCs, all
found by validation code that checks the relation between pin groups and
pin functions.
I plan to queue these in sh-pfc-for-v5.1.
Thanks!
Geert Uytterhoeven (4):
pinctrl: sh-pfc: emev2: Add missing pinmux functions
pinctrl: sh-pfc: r8a7791: Fix scifb2_data_c pin group
pinctrl: sh-pfc: r8a7792: Fix vin1_data18_b pin group
pinctrl: sh-pfc: sh73a0: Fix fsic_spdif pin groups
drivers/pinctrl/sh-pfc/pfc-emev2.c | 20 ++++++++++++++++++++
drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 2 +-
drivers/pinctrl/sh-pfc/pfc-r8a7792.c | 1 +
drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 3 ++-
4 files changed, 24 insertions(+), 2 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] pinctrl: sh-pfc: emev2: Add missing pinmux functions
2019-01-25 15:48 [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Geert Uytterhoeven
@ 2019-01-25 15:48 ` Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 2/4] pinctrl: sh-pfc: r8a7791: Fix scifb2_data_c pin group Geert Uytterhoeven
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-01-25 15:48 UTC (permalink / raw)
To: Linus Walleij
Cc: Niklas Söderlund, Sergei Shtylyov, Laurent Pinchart,
linux-renesas-soc, linux-gpio, Geert Uytterhoeven
The err_rst_reqb, ext_clki, lowpwr, and ref_clko pin groups are present,
but no pinmux functions refer to them, hence they can not be selected.
Fixes: 1e7d5d849cf4f0c5 ("sh-pfc: Add emev2 pinmux support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/sh-pfc/pfc-emev2.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/pinctrl/sh-pfc/pfc-emev2.c b/drivers/pinctrl/sh-pfc/pfc-emev2.c
index dc271c3243df5ebf..310c6f3ee7ccda30 100644
--- a/drivers/pinctrl/sh-pfc/pfc-emev2.c
+++ b/drivers/pinctrl/sh-pfc/pfc-emev2.c
@@ -1260,6 +1260,14 @@ static const char * const dtv_groups[] = {
"dtv_b",
};
+static const char * const err_rst_reqb_groups[] = {
+ "err_rst_reqb",
+};
+
+static const char * const ext_clki_groups[] = {
+ "ext_clki",
+};
+
static const char * const iic0_groups[] = {
"iic0",
};
@@ -1282,6 +1290,10 @@ static const char * const lcd_groups[] = {
"yuv3",
};
+static const char * const lowpwr_groups[] = {
+ "lowpwr",
+};
+
static const char * const ntsc_groups[] = {
"ntsc_clk",
"ntsc_data",
@@ -1295,6 +1307,10 @@ static const char * const pwm1_groups[] = {
"pwm1",
};
+static const char * const ref_clko_groups[] = {
+ "ref_clko",
+};
+
static const char * const sd_groups[] = {
"sd_cki",
};
@@ -1388,13 +1404,17 @@ static const struct sh_pfc_function pinmux_functions[] = {
SH_PFC_FUNCTION(cam),
SH_PFC_FUNCTION(cf),
SH_PFC_FUNCTION(dtv),
+ SH_PFC_FUNCTION(err_rst_reqb),
+ SH_PFC_FUNCTION(ext_clki),
SH_PFC_FUNCTION(iic0),
SH_PFC_FUNCTION(iic1),
SH_PFC_FUNCTION(jtag),
SH_PFC_FUNCTION(lcd),
+ SH_PFC_FUNCTION(lowpwr),
SH_PFC_FUNCTION(ntsc),
SH_PFC_FUNCTION(pwm0),
SH_PFC_FUNCTION(pwm1),
+ SH_PFC_FUNCTION(ref_clko),
SH_PFC_FUNCTION(sd),
SH_PFC_FUNCTION(sdi0),
SH_PFC_FUNCTION(sdi1),
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] pinctrl: sh-pfc: r8a7791: Fix scifb2_data_c pin group
2019-01-25 15:48 [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 1/4] pinctrl: sh-pfc: emev2: Add missing pinmux functions Geert Uytterhoeven
@ 2019-01-25 15:48 ` Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 3/4] pinctrl: sh-pfc: r8a7792: Fix vin1_data18_b " Geert Uytterhoeven
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-01-25 15:48 UTC (permalink / raw)
To: Linus Walleij
Cc: Niklas Söderlund, Sergei Shtylyov, Laurent Pinchart,
linux-renesas-soc, linux-gpio, Geert Uytterhoeven
The entry for "scifb2_data_c" in the SCIFB2 pin group array contains a
typo, thus the group cannot be selected.
Fixes: 5088451962389924 ("pinctrl: sh-pfc: r8a7791 PFC support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
index bd363f2e196fcc26..d8b13d4e9bbff7cb 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -5236,7 +5236,7 @@ static const char * const scifb2_groups[] = {
"scifb2_data_b",
"scifb2_clk_b",
"scifb2_ctrl_b",
- "scifb0_data_c",
+ "scifb2_data_c",
"scifb2_clk_c",
"scifb2_data_d",
};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] pinctrl: sh-pfc: r8a7792: Fix vin1_data18_b pin group
2019-01-25 15:48 [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 1/4] pinctrl: sh-pfc: emev2: Add missing pinmux functions Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 2/4] pinctrl: sh-pfc: r8a7791: Fix scifb2_data_c pin group Geert Uytterhoeven
@ 2019-01-25 15:48 ` Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 4/4] pinctrl: sh-pfc: sh73a0: Fix fsic_spdif pin groups Geert Uytterhoeven
2019-01-28 12:24 ` [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-01-25 15:48 UTC (permalink / raw)
To: Linus Walleij
Cc: Niklas Söderlund, Sergei Shtylyov, Laurent Pinchart,
linux-renesas-soc, linux-gpio, Geert Uytterhoeven
The vin1_data18_b pin group itself is present, but it is not listed in
the VIN1 pin group array, and thus cannot be selected.
Fixes: 7dd74bb1f058786e ("pinctrl: sh-pfc: r8a7792: Add VIN pin groups")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/sh-pfc/pfc-r8a7792.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7792.c b/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
index a623459b234e048e..d36da5652de6c6d3 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
@@ -1913,6 +1913,7 @@ static const char * const vin1_groups[] = {
"vin1_data8",
"vin1_data24_b",
"vin1_data20_b",
+ "vin1_data18_b",
"vin1_data16_b",
"vin1_sync",
"vin1_field",
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] pinctrl: sh-pfc: sh73a0: Fix fsic_spdif pin groups
2019-01-25 15:48 [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Geert Uytterhoeven
` (2 preceding siblings ...)
2019-01-25 15:48 ` [PATCH 3/4] pinctrl: sh-pfc: r8a7792: Fix vin1_data18_b " Geert Uytterhoeven
@ 2019-01-25 15:48 ` Geert Uytterhoeven
2019-01-28 12:24 ` [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-01-25 15:48 UTC (permalink / raw)
To: Linus Walleij
Cc: Niklas Söderlund, Sergei Shtylyov, Laurent Pinchart,
linux-renesas-soc, linux-gpio, Geert Uytterhoeven
There are two pin groups for the FSIC SPDIF signal, but the FSIC pin
group array lists only one, and it refers to a nonexistent group.
Fixes: 2ecd4154c906b7d6 ("sh-pfc: sh73a0: Add FSI pin groups and functions")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
index 085770e66895680a..ef3da8bf1d8700fa 100644
--- a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
+++ b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
@@ -3354,7 +3354,8 @@ static const char * const fsic_groups[] = {
"fsic_sclk_out",
"fsic_data_in",
"fsic_data_out",
- "fsic_spdif",
+ "fsic_spdif_0",
+ "fsic_spdif_1",
};
static const char * const fsid_groups[] = {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes
2019-01-25 15:48 [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Geert Uytterhoeven
` (3 preceding siblings ...)
2019-01-25 15:48 ` [PATCH 4/4] pinctrl: sh-pfc: sh73a0: Fix fsic_spdif pin groups Geert Uytterhoeven
@ 2019-01-28 12:24 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2019-01-28 12:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Niklas Söderlund, Sergei Shtylyov,
Laurent Pinchart, linux-renesas-soc, linux-gpio
On Fri, Jan 25, 2019 at 04:48:08PM +0100, Geert Uytterhoeven wrote:
> Hi Linus,
>
> This patch series contains 4 pinmux functions for Renesas SoCs, all
> found by validation code that checks the relation between pin groups and
> pin functions.
>
> I plan to queue these in sh-pfc-for-v5.1.
FWIIW:
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-28 12:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 15:48 [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 1/4] pinctrl: sh-pfc: emev2: Add missing pinmux functions Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 2/4] pinctrl: sh-pfc: r8a7791: Fix scifb2_data_c pin group Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 3/4] pinctrl: sh-pfc: r8a7792: Fix vin1_data18_b " Geert Uytterhoeven
2019-01-25 15:48 ` [PATCH 4/4] pinctrl: sh-pfc: sh73a0: Fix fsic_spdif pin groups Geert Uytterhoeven
2019-01-28 12:24 ` [PATCH 0/4] pinctrl: sh-pfc: Miscellaneous pinmux fixes Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).