Linux-Renesas-SoC Archive on lore.kernel.org
 help / Atom feed
* [PATCH] i2c: sh_mobile: use new clock calculation formulas for Gen2
@ 2019-02-05 17:00 Wolfram Sang
  2019-02-05 19:45 ` Geert Uytterhoeven
  2019-02-08 21:30 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2019-02-05 17:00 UTC (permalink / raw)
  To: linux-i2c; +Cc: linux-renesas-soc, Geert Uytterhoeven, Wolfram Sang

We measured the clock on a Lager and an Ebisu board. The new formula
gives better results for both. So after Gen3, switch to this formula for
all Gen2 SoCs.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-sh_mobile.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 3c1552f14bec..6dfe1b3e2a3b 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -802,14 +802,14 @@ static const struct of_device_id sh_mobile_i2c_dt_ids[] = {
 	{ .compatible = "renesas,iic-r8a7740", .data = &r8a7740_dt_config },
 	{ .compatible = "renesas,iic-r8a774c0", .data = &fast_clock_dt_config },
 	{ .compatible = "renesas,iic-r8a7790", .data = &v2_freq_calc_dt_config },
-	{ .compatible = "renesas,iic-r8a7791", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,iic-r8a7792", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,iic-r8a7793", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,iic-r8a7794", .data = &fast_clock_dt_config },
+	{ .compatible = "renesas,iic-r8a7791", .data = &v2_freq_calc_dt_config },
+	{ .compatible = "renesas,iic-r8a7792", .data = &v2_freq_calc_dt_config },
+	{ .compatible = "renesas,iic-r8a7793", .data = &v2_freq_calc_dt_config },
+	{ .compatible = "renesas,iic-r8a7794", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,iic-r8a7795", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,iic-r8a77990", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,iic-sh73a0", .data = &fast_clock_dt_config },
-	{ .compatible = "renesas,rcar-gen2-iic", .data = &fast_clock_dt_config },
+	{ .compatible = "renesas,rcar-gen2-iic", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,rcar-gen3-iic", .data = &v2_freq_calc_dt_config },
 	{ .compatible = "renesas,rmobile-iic", .data = &default_dt_config },
 	{},
-- 
2.19.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: sh_mobile: use new clock calculation formulas for Gen2
  2019-02-05 17:00 [PATCH] i2c: sh_mobile: use new clock calculation formulas for Gen2 Wolfram Sang
@ 2019-02-05 19:45 ` Geert Uytterhoeven
  2019-02-08 21:30 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-02-05 19:45 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: Linux I2C, Linux-Renesas

Hi Wolfram,

On Tue, Feb 5, 2019 at 6:01 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We measured the clock on a Lager and an Ebisu board. The new formula
> gives better results for both. So after Gen3, switch to this formula for
> all Gen2 SoCs.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

BTW, according to the datasheet, R-Mobile APE6 uses the same formulas
as R-Car Gen2, but you'll be able to verify that soon ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: sh_mobile: use new clock calculation formulas for Gen2
  2019-02-05 17:00 [PATCH] i2c: sh_mobile: use new clock calculation formulas for Gen2 Wolfram Sang
  2019-02-05 19:45 ` Geert Uytterhoeven
@ 2019-02-08 21:30 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2019-02-08 21:30 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-i2c, linux-renesas-soc, Geert Uytterhoeven

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

On Tue, Feb 05, 2019 at 06:00:46PM +0100, Wolfram Sang wrote:
> We measured the clock on a Lager and an Ebisu board. The new formula
> gives better results for both. So after Gen3, switch to this formula for
> all Gen2 SoCs.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 17:00 [PATCH] i2c: sh_mobile: use new clock calculation formulas for Gen2 Wolfram Sang
2019-02-05 19:45 ` Geert Uytterhoeven
2019-02-08 21:30 ` Wolfram Sang

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox