From: Wolfram Sang <wsa@the-dreams.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] mmc: tmio_mmc_core: don't claim spurious interrupts
Date: Sat, 9 Feb 2019 22:40:58 +0100 [thread overview]
Message-ID: <20190209214058.n6qdemed3bcjkefk@ninjato> (raw)
In-Reply-To: <c737228e-fde2-33a0-2fdc-d88f0bfd2a9b@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Sat, Feb 09, 2019 at 10:13:44PM +0300, Sergei Shtylyov wrote:
> I have encountered an interrupt storm during the eMMC chip probing (and
> the chip finally didn't get detected). It turned out that U-Boot left
> the DMAC interrupts enabled while the Linux driver didn't use those.
> The SDHI driver's interrupt handler somehow assumes that, even if an
> SDIO interrupt didn't happen, it should return IRQ_HANDLED. I think that
> if none of the enabled interrupts happened and got handled, we should
> return IRQ_NONE -- that way the kernel IRQ code recoginizes a spurious
> interrupt and masks it off pretty quickly...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Looks OK in general.
> + return ireg ? true : false;
return ireg;
?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-09 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 19:13 [PATCH v2] mmc: tmio_mmc_core: don't claim spurious interrupts Sergei Shtylyov
2019-02-09 21:40 ` Wolfram Sang [this message]
2019-02-10 17:35 ` Sergei Shtylyov
2019-02-10 17:49 ` Wolfram Sang
2019-02-11 16:37 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209214058.n6qdemed3bcjkefk@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).