From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B8CC169C4 for ; Mon, 11 Feb 2019 14:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C39BA2082F for ; Mon, 11 Feb 2019 14:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731509AbfBKOkT (ORCPT ); Mon, 11 Feb 2019 09:40:19 -0500 Received: from mga01.intel.com ([192.55.52.88]:35786 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732032AbfBKOkT (ORCPT ); Mon, 11 Feb 2019 09:40:19 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2019 06:40:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,358,1544515200"; d="scan'208";a="123587720" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga008.fm.intel.com with ESMTP; 11 Feb 2019 06:40:16 -0800 Received: from andy by smile with local (Exim 4.92-RC5) (envelope-from ) id 1gtCkp-0005nG-K6; Mon, 11 Feb 2019 16:40:15 +0200 Date: Mon, 11 Feb 2019 16:40:15 +0200 From: Andy Shevchenko To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Alexandre Belloni , Ludovic Desroches , Jarkko Nikula Subject: Re: [PATCH] i2c: document the SDA hold time binding Message-ID: <20190211144015.GE9224@smile.fi.intel.com> References: <20190211132515.24163-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211132515.24163-1-wsa+renesas@sang-engineering.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Mon, Feb 11, 2019 at 02:25:15PM +0100, Wolfram Sang wrote: > The documentation was forgotten when the feature was added. > > Fixes: 4717be73c284 ("i2c: core: Parse SDA hold time from firmware") > Signed-off-by: Wolfram Sang > --- > > To everyone on CC: I want to confirm here that you use the value really for > t(hd:sta) and not t(hd:dat). I'd be a little confused otherwise... +Cc: Jarkko > > Documentation/devicetree/bindings/i2c/i2c.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt > index 44efafdfd7f5..b7bc4c4cc2e6 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt > @@ -55,6 +55,10 @@ wants to support one of the below features, it should adapt the bindings below. > Number of nanoseconds the SDA signal takes to fall; t(f) in the I2C > specification. > > +- i2c-sda-hold-time-ns > + Number of nanoseconds the SDA signal needs to be held; t(hd:sta) in > + the I2C specification. > + > - interrupts > interrupts used by the device. > > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko