From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/2] i2c: gpio: fault-injector: add 'lose_arbitration' injector
Date: Tue, 19 Feb 2019 14:37:16 +0100 [thread overview]
Message-ID: <20190219133715.yvpitglk4smgqz4z@ninjato> (raw)
In-Reply-To: <CAMuHMdUmtVtyfRLgLo+=kMP_KOzPrzrwcHL6WaUd2tnzKnS0rA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
> > > > > > + wait_for_completion_interruptible(&priv->scl_irq_completion);
> > > > >
> > > > > Error checking/propagation (-ERESTARTSYS)?
> > > >
> > > > Are you sure? ERESTARTSYS belongs to the "These should never be seen by
> > > > user programs." group.
> > >
> > > How else can you inform the user the operation has been interrupted?
> >
> > Definately not by using something which is marked "should never be seen
> > by user programs" :)
> >
> > In the worst case, I'll add:
> > if (ret) ret = -EINTR;
> >
> > I tested the current code with CTRL+C, there we get EOWNERDEAD back to
> > userspace, even with my code not propagating anything. With sending
> > SIGKILL, I got 143 which is not defined. I want to double check the
> > latter first, might be my tests were flaky...
>
> Where's the kernel code that returns EOWNERDEAD?
> Must be hidden in a complex preprocessor macro, as git grep cannot find it :-(
I rather think it is glibc returning it when it discovered that the
owner of a robust mutex was gone:
http://man7.org/linux/man-pages/man3/pthread_mutexattr_setrobust.3.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-19 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 12:41 [PATCH 0/2] i2c: gpio: fault-injector: add two new injectors Wolfram Sang
2019-02-17 12:41 ` [PATCH 1/2] i2c: gpio: fault-injector: add 'lose_arbitration' injector Wolfram Sang
2019-02-18 9:17 ` Geert Uytterhoeven
2019-02-18 20:41 ` Wolfram Sang
2019-02-18 23:48 ` Peter Rosin
2019-02-19 13:13 ` Wolfram Sang
2019-02-19 14:07 ` Peter Rosin
2019-02-19 7:53 ` Geert Uytterhoeven
2019-02-19 13:18 ` Wolfram Sang
2019-02-19 13:33 ` Geert Uytterhoeven
2019-02-19 13:37 ` Wolfram Sang [this message]
2019-02-19 16:26 ` Wolfram Sang
2019-02-17 12:41 ` [PATCH 2/2] i2c: gpio: fault-injector: add 'inject_panic' injector Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219133715.yvpitglk4smgqz4z@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).