From: Wolfram Sang <wsa@the-dreams.de>
To: Gareth Williams <gareth.williams.jx@renesas.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org,
Phil Edworthy <phil.edworthy@renesas.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: designware: Add support for a bus clock
Date: Tue, 19 Feb 2019 21:25:27 +0100 [thread overview]
Message-ID: <20190219202527.rz45advkmpyzvaf4@katana> (raw)
In-Reply-To: <1550589042-11096-3-git-send-email-gareth.williams.jx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
> - if (prepare)
> + if (prepare) {
> + /* Optional bus clock */
> + ret = clk_prepare_enable(dev->busclk);
> + if (ret)
> + return ret;
> +
> return clk_prepare_enable(dev->clk);
This leaves 'busclk' enabled when the other clock fails.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-02-19 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 15:10 [PATCH v2 0/2] dt: i2c: Add support for bus clock Gareth Williams
2019-02-19 15:10 ` [PATCH v2 1/2] dt: snps,designware-i2c: Add clock bindings documentation Gareth Williams
2019-02-19 20:23 ` Wolfram Sang
2019-02-19 15:10 ` [PATCH v2 2/2] i2c: designware: Add support for a bus clock Gareth Williams
2019-02-19 20:25 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219202527.rz45advkmpyzvaf4@katana \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gareth.williams.jx@renesas.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).