From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Takeshi Saito" <takeshi.saito.xv@renesas.com>
Subject: Re: [PATCH] mmc: tmio: fix access width of Block Count Register
Date: Mon, 25 Feb 2019 10:20:59 +0100 [thread overview]
Message-ID: <20190225092059.rypo3kgfbyyrg7in@verge.net.au> (raw)
In-Reply-To: <20190221193805.1427-1-wsa+renesas@sang-engineering.com>
On Thu, Feb 21, 2019 at 08:38:05PM +0100, Wolfram Sang wrote:
> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>
> In R-Car Gen2 or later, the maximum number of transfer blocks are
> changed from 0xFFFF to 0xFFFFFFFF. Therefore, Block Count Register
> should use iowrite32().
>
> If another system (U-boot, Hypervisor OS, etc) uses bit[31:16], this
> value will not be cleared. So, SD/MMC card initialization fails.
>
> So, check for the bigger register and use apropriate write. Also, mark
> the register as extended on Gen2.
>
> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> [wsa: use max_blk_count in if(), add Gen2, update commit message]
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: stable@kernel.org
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2019-02-25 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 19:38 [PATCH] mmc: tmio: fix access width of Block Count Register Wolfram Sang
2019-02-25 9:20 ` Simon Horman [this message]
2019-02-26 8:18 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225092059.rypo3kgfbyyrg7in@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=takeshi.saito.xv@renesas.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).