From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] rcar-csi2: Move setting of Field Detection Control Register
Date: Thu, 7 Mar 2019 01:33:23 +0100 [thread overview]
Message-ID: <20190307003323.GM9239@bigcity.dyn.berto.se> (raw)
In-Reply-To: <f04a3e2a-e06b-144f-ebc3-f29e89f53801@ideasonboard.com>
Hi Kieran,
Thanks for your feedback.
On 2019-02-18 11:19:50 +0000, Kieran Bingham wrote:
> Hi Niklas,
>
> On 18/02/2019 10:03, Niklas Söderlund wrote:
> > Latest datasheet (rev 1.50) clarifies that the FLD register should be
> > set after LINKCNT.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> > drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> > index 50486301c21b4bae..f90b380478775015 100644
> > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> > @@ -545,7 +545,6 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv)
> > rcsi2_write(priv, PHTC_REG, 0);
> >
> > /* Configure */
> > - rcsi2_write(priv, FLD_REG, fld);
> > rcsi2_write(priv, VCDT_REG, vcdt);
> > if (vcdt2)
> > rcsi2_write(priv, VCDT2_REG, vcdt2);
> > @@ -576,6 +575,7 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv)
>
> Hrm ... I'm on linux-media/master and I don't see a function named
> rcsi2_start_receiver.
>
> What base am I missing? I presume there are rework patches here in flight.
Yes it's patches in flight,
[PATCH] rcar-csi2: Use standby mode instead of resetting
>
>
> > rcsi2_write(priv, PHYCNT_REG, phycnt);
> > rcsi2_write(priv, LINKCNT_REG, LINKCNT_MONITOR_EN |
> > LINKCNT_REG_MONI_PACT_EN | LINKCNT_ICLK_NONSTOP);
> > + rcsi2_write(priv, FLD_REG, fld);
>
> However, I can see that this matches the flow chart in figures
> 25.{17,18,19,20}
>
> So
>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Thanks!
>
>
> > rcsi2_write(priv, PHYCNT_REG, phycnt | PHYCNT_SHUTDOWNZ);
> > rcsi2_write(priv, PHYCNT_REG, phycnt | PHYCNT_SHUTDOWNZ | PHYCNT_RSTZ);
> >
> >
>
>
> --
> Regards
> --
> Kieran
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2019-03-07 0:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 10:03 [PATCH 0/3] rcar-csi2: Update start procedures to latest revision of datasheet Niklas Söderlund
2019-02-18 10:03 ` [PATCH 1/3] rcar-csi2: Update V3M and E3 start procedure Niklas Söderlund
2019-02-18 10:40 ` Ulrich Hecht
2019-02-18 10:03 ` [PATCH 2/3] rcar-csi2: Update start procedure for H3 ES2 Niklas Söderlund
2019-02-18 11:01 ` Kieran Bingham
2019-03-07 0:30 ` Niklas Söderlund
2019-02-18 11:12 ` Ulrich Hecht
2019-03-07 0:27 ` Niklas Söderlund
2019-02-18 10:03 ` [PATCH 3/3] rcar-csi2: Move setting of Field Detection Control Register Niklas Söderlund
2019-02-18 10:52 ` Ulrich Hecht
2019-02-18 11:19 ` Kieran Bingham
2019-03-07 0:33 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307003323.GM9239@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).