* [PATCH] pinctrl: sh-pfc: Improve PINMUX_IPSR_PHYS() documentation
@ 2019-03-20 10:44 Geert Uytterhoeven
2019-03-20 14:41 ` Niklas Söderlund
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-03-20 10:44 UTC (permalink / raw)
To: Linus Walleij
Cc: Ulrich Hecht, Laurent Pinchart, linux-renesas-soc, linux-gpio,
Geert Uytterhoeven
- The IPSR field is meant for documentation only,
- The function name refers to the pin function, not to the IPSR field.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in sh-pfc-for-v5.2.
drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
index 2a6abeb62bab659b..7db5819eea7e6e0d 100644
--- a/drivers/pinctrl/sh-pfc/sh_pfc.h
+++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
@@ -418,8 +418,8 @@ extern const struct sh_pfc_soc_info shx3_pinmux_info;
/*
* Describe a pinmux configuration in which a pin is physically multiplexed
* with other pins.
- * - ipsr: IPSR field
- * - fn: Function name, also referring to the IPSR field
+ * - ipsr: IPSR field (unused, for documentation purposes only)
+ * - fn: Function name
* - psel: Physical multiplexing selector
*/
#define PINMUX_IPSR_PHYS(ipsr, fn, psel) \
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: Improve PINMUX_IPSR_PHYS() documentation
2019-03-20 10:44 [PATCH] pinctrl: sh-pfc: Improve PINMUX_IPSR_PHYS() documentation Geert Uytterhoeven
@ 2019-03-20 14:41 ` Niklas Söderlund
0 siblings, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2019-03-20 14:41 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Ulrich Hecht, Laurent Pinchart, linux-renesas-soc,
linux-gpio
Hi Geert,
Thanks for your work.
On 2019-03-20 11:44:46 +0100, Geert Uytterhoeven wrote:
> - The IPSR field is meant for documentation only,
> - The function name refers to the pin function, not to the IPSR field.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> To be queued in sh-pfc-for-v5.2.
>
> drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 2a6abeb62bab659b..7db5819eea7e6e0d 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -418,8 +418,8 @@ extern const struct sh_pfc_soc_info shx3_pinmux_info;
> /*
> * Describe a pinmux configuration in which a pin is physically multiplexed
> * with other pins.
> - * - ipsr: IPSR field
> - * - fn: Function name, also referring to the IPSR field
> + * - ipsr: IPSR field (unused, for documentation purposes only)
> + * - fn: Function name
> * - psel: Physical multiplexing selector
> */
> #define PINMUX_IPSR_PHYS(ipsr, fn, psel) \
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-20 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 10:44 [PATCH] pinctrl: sh-pfc: Improve PINMUX_IPSR_PHYS() documentation Geert Uytterhoeven
2019-03-20 14:41 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).