From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Nguyen An Hoan <na-hoan@jinso.co.jp>
Cc: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
rui.zhang@intel.com, jslaby@suse.com,
wsa+renesas@sang-engineering.com, edubezval@gmail.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kuninori.morimoto.gx@renesas.com,
yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
nv-dung@jinso.co.jp, cv-dong@jinso.co.jp
Subject: Re: [RESEND PATCH] thermal: rcar_gen3_thermal: Fix init value of IRQCTL register
Date: Wed, 27 Mar 2019 10:31:54 +0100 [thread overview]
Message-ID: <20190327093154.GA23466@bigcity.dyn.berto.se> (raw)
In-Reply-To: <1553677398-7896-1-git-send-email-na-hoan@jinso.co.jp>
Hi Hoan,
Thanks for your work, and sorry for dropping the ball on this in v2.
On 2019-03-27 18:03:18 +0900, Nguyen An Hoan wrote:
> From: Hoan Nguyen An <na-hoan@jinso.co.jp>
>
> Fix setting value for IRQCTL register. We are setting the last 6 bits
> of (IRQCTL) to be 1 (0x3f), this is only suitable for H3ES1.*, according
> to Hardware manual values 1 are "setting prohibited" for Gen3.
>
> Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
> drivers/thermal/rcar_gen3_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
> index 88fa41c..2482795 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -307,7 +307,7 @@ static void rcar_gen3_thermal_init(struct rcar_gen3_thermal_tsc *tsc)
>
> usleep_range(1000, 2000);
>
> - rcar_gen3_thermal_write(tsc, REG_GEN3_IRQCTL, 0x3F);
> + rcar_gen3_thermal_write(tsc, REG_GEN3_IRQCTL, 0);
> rcar_gen3_thermal_write(tsc, REG_GEN3_IRQMSK, 0);
> rcar_gen3_thermal_write(tsc, REG_GEN3_IRQEN, IRQ_TEMPD1 | IRQ_TEMP2);
>
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2019-03-27 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 9:03 [RESEND PATCH] thermal: rcar_gen3_thermal: Fix init value of IRQCTL register Nguyen An Hoan
2019-03-27 9:31 ` Niklas Söderlund [this message]
2019-03-27 9:34 ` Yoshihiro Shimoda
2019-03-28 7:06 ` Wolfram Sang
2019-03-28 8:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327093154.GA23466@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=cv-dong@jinso.co.jp \
--cc=edubezval@gmail.com \
--cc=geert+renesas@glider.be \
--cc=h-inayoshi@jinso.co.jp \
--cc=jslaby@suse.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=na-hoan@jinso.co.jp \
--cc=nv-dung@jinso.co.jp \
--cc=rui.zhang@intel.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).