From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-watchdog@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: [PATCH v3 00/16] watchdog: refactor init_timeout and update users
Date: Fri, 19 Apr 2019 20:15:45 +0200 [thread overview]
Message-ID: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> (raw)
When trying to add DT support to the DA9063 WDT, I didn't want to add yet
another error message when watchdog_init_timeout fails. The core could do this
with more detail, and also much more consistent. So, I refactored this routine
and removed error strings from its callers. Note that DA9063 support is not
added here but was sent seperately[1]. This series has been tested using the
renesas_wdt driver on a Renesas Salvator-XS board (R-Car M3N) and build bot is
happy, too.
A branch (based on Guenter's watchdog-next) for testing can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/wdt-handover
Changes since V2:
* refactored patch 2 to use pr_* instead of dev_* and fall back to wdt
'identity' if there is no dev attached. Thanks Jerry for the report!
* added rev tag to patch 1 (thanks Guenter for the discussion!)
* added ack tag to patch 5 (thanks William!)
Changes since V1:
* return -EINVAL if DT supplied a value of '0' [patch 1]
* update kdoc to mention that DT cannot be '0' but module_param can be
[patch 1]
* add Guenter's Rev-by to all patches except patch 1
* add driver maintainers to CC this time
I think we are ready to go now?
Thanks,
Wolfram
[1] https://patchwork.kernel.org/patch/10899801/
Wolfram Sang (16):
watchdog: refactor watchdog_init_timeout
watchdog: add error messages when initializing timeout fails
watchdog: cadence_wdt: drop warning after calling
watchdog_init_timeout
watchdog: cadence_wdt: still probe if user supplied timeout is invalid
watchdog: ebc-c384_wdt: drop warning after calling
watchdog_init_timeout
watchdog: hpwdt: drop warning after calling watchdog_init_timeout
watchdog: i6300esb: drop warning after calling watchdog_init_timeout
watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout
watchdog: ni903x_wdt: drop warning after calling watchdog_init_timeout
watchdog: nic7018_wdt: drop warning after calling
watchdog_init_timeout
watchdog: renesas_wdt: drop warning after calling
watchdog_init_timeout
watchdog: sp5100_tco: drop warning after calling watchdog_init_timeout
watchdog: st_lpc_wdt: drop warning after calling watchdog_init_timeout
watchdog: stm32_iwdg: drop warning after calling watchdog_init_timeout
watchdog: xen_wdt: drop warning after calling watchdog_init_timeout
watchdog: ziirave_wdt: drop warning after calling
watchdog_init_timeout
drivers/watchdog/cadence_wdt.c | 7 +------
drivers/watchdog/ebc-c384_wdt.c | 5 +----
drivers/watchdog/hpwdt.c | 3 +--
drivers/watchdog/i6300esb.c | 5 +----
drivers/watchdog/imx_sc_wdt.c | 5 +----
drivers/watchdog/ni903x_wdt.c | 4 +---
drivers/watchdog/nic7018_wdt.c | 5 +----
drivers/watchdog/renesas_wdt.c | 4 +---
drivers/watchdog/sp5100_tco.c | 4 +---
drivers/watchdog/st_lpc_wdt.c | 4 +---
drivers/watchdog/stm32_iwdg.c | 6 +-----
drivers/watchdog/watchdog_core.c | 42 ++++++++++++++++++++++++++--------------
drivers/watchdog/xen_wdt.c | 4 +---
drivers/watchdog/ziirave_wdt.c | 6 +-----
14 files changed, 41 insertions(+), 63 deletions(-)
--
2.11.0
next reply other threads:[~2019-04-19 18:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 18:15 Wolfram Sang [this message]
2019-04-19 18:15 ` [PATCH v3 01/16] watchdog: refactor watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 02/16] watchdog: add error messages when initializing timeout fails Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 03/16] watchdog: cadence_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 04/16] watchdog: cadence_wdt: still probe if user supplied timeout is invalid Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 05/16] watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 06/16] watchdog: hpwdt: " Wolfram Sang
2019-04-19 21:18 ` Jerry Hoemann
2019-04-19 18:15 ` [PATCH v3 07/16] watchdog: i6300esb: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 08/16] watchdog: imx_sc_wdt: " Wolfram Sang
2019-04-29 10:15 ` Uwe Kleine-König
2019-04-29 12:37 ` Guenter Roeck
2019-04-29 13:19 ` Uwe Kleine-König
2019-04-19 18:15 ` [PATCH v3 09/16] watchdog: ni903x_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 10/16] watchdog: nic7018_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 11/16] watchdog: renesas_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 12/16] watchdog: sp5100_tco: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 13/16] watchdog: st_lpc_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 14/16] watchdog: stm32_iwdg: " Wolfram Sang
2019-04-19 18:16 ` [PATCH v3 15/16] watchdog: xen_wdt: " Wolfram Sang
2019-04-19 18:16 ` [PATCH v3 16/16] watchdog: ziirave_wdt: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419181601.7412-1-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).