From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/4] pinctrl: sh-pfc: Correct printk level of group referral warning
Date: Fri, 26 Apr 2019 11:21:39 +0200 [thread overview]
Message-ID: <20190426092139.5mwjtmm5fnpek6bb@verge.net.au> (raw)
In-Reply-To: <20190425095542.726-2-geert+renesas@glider.be>
On Thu, Apr 25, 2019 at 11:55:39AM +0200, Geert Uytterhoeven wrote:
> Fixes: 6161b39a14380815 ("pinctrl: sh-pfc: Validate pinmux tables at runtime when debugging")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This looks good to me
Reviewed-by: Simon Horman <simon.horman@netronome.com>
But I do wonder if "referred" should be "referenced"
> ---
> drivers/pinctrl/sh-pfc/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
> index 3f989f5cb021ecbc..18d7f6d9402093d4 100644
> --- a/drivers/pinctrl/sh-pfc/core.c
> +++ b/drivers/pinctrl/sh-pfc/core.c
> @@ -803,8 +803,8 @@ static void sh_pfc_check_info(const struct sh_pfc_soc_info *info)
> info->groups[i].name);
> sh_pfc_errors++;
> } else if (refcnts[i] > 1) {
> - pr_err("%s: group %s referred by %u functions\n",
> - drvname, info->groups[i].name, refcnts[i]);
> + pr_warn("%s: group %s referred by %u functions\n",
> + drvname, info->groups[i].name, refcnts[i]);
> sh_pfc_warnings++;
> }
> }
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-04-26 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 9:55 [PATCH 0/4] pinctrl: sh-pfc: Run-time debug code fixes and enhancements Geert Uytterhoeven
2019-04-25 9:55 ` [PATCH 1/4] pinctrl: sh-pfc: Correct printk level of group referral warning Geert Uytterhoeven
2019-04-26 9:21 ` Simon Horman [this message]
2019-04-29 8:38 ` Geert Uytterhoeven
2019-04-29 8:49 ` Simon Horman
2019-04-25 9:55 ` [PATCH 2/4] pinctrl: sh-pfc: Mark run-time debug code __init Geert Uytterhoeven
2019-04-26 9:29 ` Simon Horman
2019-04-25 9:55 ` [PATCH 3/4] pinctrl: sh-pfc: Add check for empty pinmux groups/functions Geert Uytterhoeven
2019-04-26 9:34 ` Simon Horman
2019-04-26 9:42 ` Geert Uytterhoeven
2019-04-26 9:53 ` Simon Horman
2019-04-25 9:55 ` [PATCH 4/4] pinctrl: sh-pfc: Validate pin tables at runtime Geert Uytterhoeven
2019-04-26 9:36 ` Simon Horman
2019-05-03 7:25 ` [PATCH 0/4] pinctrl: sh-pfc: Run-time debug code fixes and enhancements Linus Walleij
2019-05-03 7:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426092139.5mwjtmm5fnpek6bb@verge.net.au \
--to=horms@verge.net.au \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).