From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/3] pinctrl: sh-pfc: Add SH_PFC_PIN_CFG_PULL_UP_DOWN shorthand
Date: Fri, 26 Apr 2019 11:48:00 +0200 [thread overview]
Message-ID: <20190426094800.rxzvoox7dzfqsmms@verge.net.au> (raw)
In-Reply-To: <20190425095946.1259-3-geert+renesas@glider.be>
On Thu, Apr 25, 2019 at 11:59:45AM +0200, Geert Uytterhoeven wrote:
> It is very common for a pin to support both pull-up and pull-down
> functionality. Hence add a shorthand SH_PFC_PIN_CFG_PULL_UP_DOWN.
> This not only reduces typing, but also avoids the need for several line
> breaks, and makes many overly long lines shorter, improving
> readability.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2019-04-26 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 9:59 [PATCH 0/3] pinctrl: sh-pfc: Miscellaneous improvements Geert Uytterhoeven
2019-04-25 9:59 ` [PATCH 1/3] pinctrl: sh-pfc: Rename 2-parameter CPU_ALL_PORT() variant Geert Uytterhoeven
2019-04-26 9:47 ` Simon Horman
2019-04-25 9:59 ` [PATCH 2/3] pinctrl: sh-pfc: Add SH_PFC_PIN_CFG_PULL_UP_DOWN shorthand Geert Uytterhoeven
2019-04-26 9:48 ` Simon Horman [this message]
2019-04-25 9:59 ` [PATCH 3/3] pinctrl: sh-pfc: Move PIN_NONE to shared header file Geert Uytterhoeven
2019-04-26 9:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426094800.rxzvoox7dzfqsmms@verge.net.au \
--to=horms@verge.net.au \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).