linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N
@ 2019-04-25  1:25 Cao Van Dong
  2019-04-25  1:25 ` [PATCH v2 1/5] clk: renesas: r8a779{5|6|65}: Add TPU clock Cao Van Dong
                   ` (6 more replies)
  0 siblings, 7 replies; 18+ messages in thread
From: Cao Van Dong @ 2019-04-25  1:25 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan, cv-dong

This series adds tpu support for r8a7795/r8a7796/r8a77965 SoCs.
Based on the renesas-drivers-2019-04-02-v5.1-rc3 tag of renesas-drivers tree.
For test, after booting, I found the device was registered in the booting log.

Cao Van Dong (5):
  clk: renesas: r8a779{5|6|65}: Add TPU clock
  arm64: dts: renesas: r8a7795: Add TPU support
  arm64: dts: renesas: r8a7796: Add TPU support
  arm64: dts: renesas: r8a77965: Add TPU support
  dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings

 Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt |  3 +++
 arch/arm64/boot/dts/renesas/r8a7795.dtsi                  | 11 +++++++++++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi                  | 11 +++++++++++
 arch/arm64/boot/dts/renesas/r8a77965.dtsi                 | 11 +++++++++++
 drivers/clk/renesas/r8a7795-cpg-mssr.c                    |  1 +
 drivers/clk/renesas/r8a7796-cpg-mssr.c                    |  1 +
 drivers/clk/renesas/r8a77965-cpg-mssr.c                   |  1 +
 7 files changed, 39 insertions(+)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/5] clk: renesas: r8a779{5|6|65}: Add TPU clock
  2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
@ 2019-04-25  1:25 ` Cao Van Dong
  2019-04-26  8:39   ` Geert Uytterhoeven
  2019-04-25  1:25 ` [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support Cao Van Dong
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 18+ messages in thread
From: Cao Van Dong @ 2019-04-25  1:25 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan, cv-dong

This patch adds TPU clock to R-car r8a7795/r8a7796/r8a77965 Socs.

Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
---
 drivers/clk/renesas/r8a7795-cpg-mssr.c  | 1 +
 drivers/clk/renesas/r8a7796-cpg-mssr.c  | 1 +
 drivers/clk/renesas/r8a77965-cpg-mssr.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c
index 9e9a6f2..28522c1 100644
--- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
@@ -138,6 +138,7 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
 	DEF_MOD("cmt2",			 301,	R8A7795_CLK_R),
 	DEF_MOD("cmt1",			 302,	R8A7795_CLK_R),
 	DEF_MOD("cmt0",			 303,	R8A7795_CLK_R),
+	DEF_MOD("tpu0",			 304,	R8A7795_CLK_S3D4),
 	DEF_MOD("scif2",		 310,	R8A7795_CLK_S3D4),
 	DEF_MOD("sdif3",		 311,	R8A7795_CLK_SD3),
 	DEF_MOD("sdif2",		 312,	R8A7795_CLK_SD2),
diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index d8e9af5..e4f5db4 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -134,6 +134,7 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
 	DEF_MOD("cmt2",			 301,	R8A7796_CLK_R),
 	DEF_MOD("cmt1",			 302,	R8A7796_CLK_R),
 	DEF_MOD("cmt0",			 303,	R8A7796_CLK_R),
+	DEF_MOD("tpu0",			 304,	R8A7796_CLK_S3D4),
 	DEF_MOD("scif2",		 310,	R8A7796_CLK_S3D4),
 	DEF_MOD("sdif3",		 311,	R8A7796_CLK_SD3),
 	DEF_MOD("sdif2",		 312,	R8A7796_CLK_SD2),
diff --git a/drivers/clk/renesas/r8a77965-cpg-mssr.c b/drivers/clk/renesas/r8a77965-cpg-mssr.c
index 8f87e31..46d5a50 100644
--- a/drivers/clk/renesas/r8a77965-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a77965-cpg-mssr.c
@@ -132,6 +132,7 @@ static const struct mssr_mod_clk r8a77965_mod_clks[] __initconst = {
 	DEF_MOD("cmt2",			301,	R8A77965_CLK_R),
 	DEF_MOD("cmt1",			302,	R8A77965_CLK_R),
 	DEF_MOD("cmt0",			303,	R8A77965_CLK_R),
+	DEF_MOD("tpu0",			304,	R8A77965_CLK_S3D4),
 	DEF_MOD("scif2",		310,	R8A77965_CLK_S3D4),
 	DEF_MOD("sdif3",		311,	R8A77965_CLK_SD3),
 	DEF_MOD("sdif2",		312,	R8A77965_CLK_SD2),
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support
  2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
  2019-04-25  1:25 ` [PATCH v2 1/5] clk: renesas: r8a779{5|6|65}: Add TPU clock Cao Van Dong
@ 2019-04-25  1:25 ` Cao Van Dong
  2019-05-03  9:25   ` Geert Uytterhoeven
  2019-05-07  5:44   ` Cao Van Dong
  2019-04-25  1:25 ` [PATCH v2 3/5] arm64: dts: renesas: r8a7796: " Cao Van Dong
                   ` (4 subsequent siblings)
  6 siblings, 2 replies; 18+ messages in thread
From: Cao Van Dong @ 2019-04-25  1:25 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan, cv-dong

Add tpu device node to dtsi for TPU support on r8a7795 SoC.

Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 55472b2..612761e 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1380,6 +1380,17 @@
 			status = "disabled";
 		};
 
+		tpu: pwm@e6e80000 {
+			compatible = "renesas,tpu-r8a7795", "renesas,tpu";
+			reg = <0 0xe6e80000 0 0x148>;
+			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 304>;
+			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+			resets = <&cpg 304>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		msiof0: spi@e6e90000 {
 			compatible = "renesas,msiof-r8a7795",
 				     "renesas,rcar-gen3-msiof";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 3/5] arm64: dts: renesas: r8a7796: Add TPU support
  2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
  2019-04-25  1:25 ` [PATCH v2 1/5] clk: renesas: r8a779{5|6|65}: Add TPU clock Cao Van Dong
  2019-04-25  1:25 ` [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support Cao Van Dong
@ 2019-04-25  1:25 ` Cao Van Dong
  2019-05-03  9:26   ` Geert Uytterhoeven
  2019-05-07  5:45   ` Cao Van Dong
  2019-04-25  1:25 ` [PATCH v2 4/5] arm64: dts: renesas: r8a77965: " Cao Van Dong
                   ` (3 subsequent siblings)
  6 siblings, 2 replies; 18+ messages in thread
From: Cao Van Dong @ 2019-04-25  1:25 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan, cv-dong

Add tpu device node to dtsi for TPU support on r8a7796 SoC.

Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index d5e2f4a..a5c6a99 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1319,6 +1319,17 @@
 			status = "disabled";
 		};
 
+		tpu: pwm@e6e80000 {
+			compatible = "renesas,tpu-r8a7796", "renesas,tpu";
+			reg = <0 0xe6e80000 0 0x148>;
+			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 304>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			resets = <&cpg 304>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		msiof0: spi@e6e90000 {
 			compatible = "renesas,msiof-r8a7796",
 				     "renesas,rcar-gen3-msiof";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 4/5] arm64: dts: renesas: r8a77965: Add TPU support
  2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
                   ` (2 preceding siblings ...)
  2019-04-25  1:25 ` [PATCH v2 3/5] arm64: dts: renesas: r8a7796: " Cao Van Dong
@ 2019-04-25  1:25 ` Cao Van Dong
  2019-05-03  9:28   ` Geert Uytterhoeven
  2019-04-25  1:25 ` [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings Cao Van Dong
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 18+ messages in thread
From: Cao Van Dong @ 2019-04-25  1:25 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan, cv-dong

Add tpu device node to dtsi for TPU support on r8a77965 SoC.

Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index d8b8172..d83a2d1 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1125,6 +1125,17 @@
 			status = "disabled";
 		};
 
+		tpu: pwm@e6e80000 {
+			compatible = "renesas,tpu-r8a77965", "renesas,tpu";
+			reg = <0 0xe6e80000 0 0x148>;
+			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 304>;
+			power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+			resets = <&cpg 304>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		msiof0: spi@e6e90000 {
 			compatible = "renesas,msiof-r8a77965",
 				     "renesas,rcar-gen3-msiof";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings
  2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
                   ` (3 preceding siblings ...)
  2019-04-25  1:25 ` [PATCH v2 4/5] arm64: dts: renesas: r8a77965: " Cao Van Dong
@ 2019-04-25  1:25 ` Cao Van Dong
  2019-05-01 20:02   ` Rob Herring
                     ` (2 more replies)
  2019-04-26  9:41 ` [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Simon Horman
  2019-05-08 10:08 ` Simon Horman
  6 siblings, 3 replies; 18+ messages in thread
From: Cao Van Dong @ 2019-04-25  1:25 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan, cv-dong

Document the R-Car H3/M3-W/M3-N (R8A779{5|6|65}) SoC in the Renesas TPU bindings.

Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
---
 Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
index 848a92b..054ce4a 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
@@ -9,6 +9,9 @@ Required Properties:
     - "renesas,tpu-r8a7744": for R8A7744 (RZ/G1N) compatible PWM controller.
     - "renesas,tpu-r8a7745": for R8A7745 (RZ/G1E) compatible PWM controller.
     - "renesas,tpu-r8a7790": for R8A7790 (R-Car H2) compatible PWM controller.
+    - "renesas,tpu-r8a7795": for R8A7795 (R-Car H3) compatible PWM controller.
+    - "renesas,tpu-r8a7796": for R8A7796 (R-Car M3-W) compatible PWM controller.
+    - "renesas,tpu-r8a77965": for R8A77965 (R-Car M3-N) compatible PWM controller.
     - "renesas,tpu-r8a77970": for R8A77970 (R-Car V3M) compatible PWM
 			      controller.
     - "renesas,tpu-r8a77980": for R8A77980 (R-Car V3H) compatible PWM
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/5] clk: renesas: r8a779{5|6|65}: Add TPU clock
  2019-04-25  1:25 ` [PATCH v2 1/5] clk: renesas: r8a779{5|6|65}: Add TPU clock Cao Van Dong
@ 2019-04-26  8:39   ` Geert Uytterhoeven
  0 siblings, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2019-04-26  8:39 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: Linux-Renesas, Simon Horman, Geert Uytterhoeven, Mark Brown,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Mark Rutland, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Yoshihiro Shimoda, Kuninori Morimoto, 稲吉,
	Hoan Nguyen An

On Thu, Apr 25, 2019 at 3:25 AM Cao Van Dong <cv-dong@jinso.co.jp> wrote:
> This patch adds TPU clock to R-car r8a7795/r8a7796/r8a77965 Socs.
>
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in clk-renesas-for-v5.3.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N
  2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
                   ` (4 preceding siblings ...)
  2019-04-25  1:25 ` [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings Cao Van Dong
@ 2019-04-26  9:41 ` Simon Horman
  2019-05-07  5:48   ` Cao Van Dong
  2019-05-08 10:08 ` Simon Horman
  6 siblings, 1 reply; 18+ messages in thread
From: Simon Horman @ 2019-04-26  9:41 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: linux-renesas-soc, geert+renesas, broonie, devicetree,
	mark.rutland, daniel.lezcano, tglx, robh, yoshihiro.shimoda.uh,
	kuninori.morimoto.gx, h-inayoshi, na-hoan

Hi,

On Thu, Apr 25, 2019 at 10:25:12AM +0900, Cao Van Dong wrote:
> This series adds tpu support for r8a7795/r8a7796/r8a77965 SoCs.
> Based on the renesas-drivers-2019-04-02-v5.1-rc3 tag of renesas-drivers tree.
> For test, after booting, I found the device was registered in the booting log.

Could you clarify some details of this test.

Looking at the DTS patches I see 'status = "disabled";' for each
of the newly added devices. So I would not expect them to be probed
at run-time without some extra tweaking.

> 
> Cao Van Dong (5):
>   clk: renesas: r8a779{5|6|65}: Add TPU clock
>   arm64: dts: renesas: r8a7795: Add TPU support
>   arm64: dts: renesas: r8a7796: Add TPU support
>   arm64: dts: renesas: r8a77965: Add TPU support
>   dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings
> 
>  Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt |  3 +++
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi                  | 11 +++++++++++
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi                  | 11 +++++++++++
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi                 | 11 +++++++++++
>  drivers/clk/renesas/r8a7795-cpg-mssr.c                    |  1 +
>  drivers/clk/renesas/r8a7796-cpg-mssr.c                    |  1 +
>  drivers/clk/renesas/r8a77965-cpg-mssr.c                   |  1 +
>  7 files changed, 39 insertions(+)
> 
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings
  2019-04-25  1:25 ` [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings Cao Van Dong
@ 2019-05-01 20:02   ` Rob Herring
  2019-05-03  9:25   ` Geert Uytterhoeven
  2019-05-08 10:07   ` Simon Horman
  2 siblings, 0 replies; 18+ messages in thread
From: Rob Herring @ 2019-05-01 20:02 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh,
	yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan,
	cv-dong

On Thu, 25 Apr 2019 10:25:17 +0900, Cao Van Dong wrote:
> Document the R-Car H3/M3-W/M3-N (R8A779{5|6|65}) SoC in the Renesas TPU bindings.
> 
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
> ---
>  Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support
  2019-04-25  1:25 ` [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support Cao Van Dong
@ 2019-05-03  9:25   ` Geert Uytterhoeven
  2019-05-07  5:44   ` Cao Van Dong
  1 sibling, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2019-05-03  9:25 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: Linux-Renesas, Simon Horman, Geert Uytterhoeven, Mark Brown,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Mark Rutland, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Yoshihiro Shimoda, Kuninori Morimoto, 稲吉,
	Hoan Nguyen An

On Thu, Apr 25, 2019 at 3:25 AM Cao Van Dong <cv-dong@jinso.co.jp> wrote:
> Add tpu device node to dtsi for TPU support on r8a7795 SoC.
>
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings
  2019-04-25  1:25 ` [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings Cao Van Dong
  2019-05-01 20:02   ` Rob Herring
@ 2019-05-03  9:25   ` Geert Uytterhoeven
  2019-05-08 10:07   ` Simon Horman
  2 siblings, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2019-05-03  9:25 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: Linux-Renesas, Simon Horman, Mark Brown,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Mark Rutland, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Yoshihiro Shimoda, Kuninori Morimoto, 稲吉,
	Hoan Nguyen An

On Thu, Apr 25, 2019 at 3:25 AM Cao Van Dong <cv-dong@jinso.co.jp> wrote:
> Document the R-Car H3/M3-W/M3-N (R8A779{5|6|65}) SoC in the Renesas TPU bindings.
>
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 3/5] arm64: dts: renesas: r8a7796: Add TPU support
  2019-04-25  1:25 ` [PATCH v2 3/5] arm64: dts: renesas: r8a7796: " Cao Van Dong
@ 2019-05-03  9:26   ` Geert Uytterhoeven
  2019-05-07  5:45   ` Cao Van Dong
  1 sibling, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2019-05-03  9:26 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: Linux-Renesas, Simon Horman, Mark Brown,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Mark Rutland, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Yoshihiro Shimoda, Kuninori Morimoto, 稲吉,
	Hoan Nguyen An

On Thu, Apr 25, 2019 at 3:25 AM Cao Van Dong <cv-dong@jinso.co.jp> wrote:
> Add tpu device node to dtsi for TPU support on r8a7796 SoC.
>
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 4/5] arm64: dts: renesas: r8a77965: Add TPU support
  2019-04-25  1:25 ` [PATCH v2 4/5] arm64: dts: renesas: r8a77965: " Cao Van Dong
@ 2019-05-03  9:28   ` Geert Uytterhoeven
  0 siblings, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2019-05-03  9:28 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: Linux-Renesas, Simon Horman, Geert Uytterhoeven, Mark Brown,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Mark Rutland, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Yoshihiro Shimoda, Kuninori Morimoto, 稲吉,
	Hoan Nguyen An

On Thu, Apr 25, 2019 at 3:25 AM Cao Van Dong <cv-dong@jinso.co.jp> wrote:
> Add tpu device node to dtsi for TPU support on r8a77965 SoC.
>
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support
  2019-04-25  1:25 ` [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support Cao Van Dong
  2019-05-03  9:25   ` Geert Uytterhoeven
@ 2019-05-07  5:44   ` Cao Van Dong
  1 sibling, 0 replies; 18+ messages in thread
From: Cao Van Dong @ 2019-05-07  5:44 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan

On 2019/04/25 10:25, Cao Van Dong wrote:
> Add tpu device node to dtsi for TPU support on r8a7795 SoC.
>
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
> ---
>   arch/arm64/boot/dts/renesas/r8a7795.dtsi | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 55472b2..612761e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -1380,6 +1380,17 @@
>   			status = "disabled";
>   		};
>   
> +		tpu: pwm@e6e80000 {
> +			compatible = "renesas,tpu-r8a7795", "renesas,tpu";
> +			reg = <0 0xe6e80000 0 0x148>;
> +			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 304>;
> +			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> +			resets = <&cpg 304>;
> +			#pwm-cells = <3>;
> +			status = "disabled";
> +		};
> +
>   		msiof0: spi@e6e90000 {
>   			compatible = "renesas,msiof-r8a7795",
>   				     "renesas,rcar-gen3-msiof";
Tested-by: Cao Van Dong <cv-dong@jinso.co.jp>

Thank you,
Dong

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 3/5] arm64: dts: renesas: r8a7796: Add TPU support
  2019-04-25  1:25 ` [PATCH v2 3/5] arm64: dts: renesas: r8a7796: " Cao Van Dong
  2019-05-03  9:26   ` Geert Uytterhoeven
@ 2019-05-07  5:45   ` Cao Van Dong
  1 sibling, 0 replies; 18+ messages in thread
From: Cao Van Dong @ 2019-05-07  5:45 UTC (permalink / raw)
  To: linux-renesas-soc, horms+renesas, geert+renesas, broonie,
	devicetree, mark.rutland, daniel.lezcano, tglx, robh
  Cc: yoshihiro.shimoda.uh, kuninori.morimoto.gx, h-inayoshi, na-hoan

On 2019/04/25 10:25, Cao Van Dong wrote:
> Add tpu device node to dtsi for TPU support on r8a7796 SoC.
>
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>
> ---
>   arch/arm64/boot/dts/renesas/r8a7796.dtsi | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index d5e2f4a..a5c6a99 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -1319,6 +1319,17 @@
>   			status = "disabled";
>   		};
>   
> +		tpu: pwm@e6e80000 {
> +			compatible = "renesas,tpu-r8a7796", "renesas,tpu";
> +			reg = <0 0xe6e80000 0 0x148>;
> +			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 304>;
> +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> +			resets = <&cpg 304>;
> +			#pwm-cells = <3>;
> +			status = "disabled";
> +		};
> +
>   		msiof0: spi@e6e90000 {
>   			compatible = "renesas,msiof-r8a7796",
>   				     "renesas,rcar-gen3-msiof";
Tested-by: Cao Van Dong <cv-dong@jinso.co.jp>

Thank you,
Dong

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N
  2019-04-26  9:41 ` [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Simon Horman
@ 2019-05-07  5:48   ` Cao Van Dong
  0 siblings, 0 replies; 18+ messages in thread
From: Cao Van Dong @ 2019-05-07  5:48 UTC (permalink / raw)
  To: Simon Horman
  Cc: linux-renesas-soc, geert+renesas, broonie, devicetree,
	mark.rutland, daniel.lezcano, tglx, robh, yoshihiro.shimoda.uh,
	kuninori.morimoto.gx, h-inayoshi, na-hoan

Dear Simon-san,

On 2019/04/26 18:41, Simon Horman wrote:
> Hi,
>
> On Thu, Apr 25, 2019 at 10:25:12AM +0900, Cao Van Dong wrote:
>> This series adds tpu support for r8a7795/r8a7796/r8a77965 SoCs.
>> Based on the renesas-drivers-2019-04-02-v5.1-rc3 tag of renesas-drivers tree.
>> For test, after booting, I found the device was registered in the booting log.
> Could you clarify some details of this test.
>
> Looking at the DTS patches I see 'status = "disabled";' for each
> of the newly added devices. So I would not expect them to be probed
> at run-time without some extra tweaking.
Test procedure:
   - Apply patch series "[PATCH 0/4] pinctrl: sh-pfc: r8a7795/6/65: Add 
TPU pins, groups and functions".
   - Make sure switches { SW29-[1-2] are switched off or SW31-[1-4] are 
switched off(only for Salvator-xs) }.
   - Enable TPU and pin control in DTS (salvator-x/xs.dtsi):

     +
     +&tpu {
     +       pinctrl-0 = <&tpu_pins>;
     +       pinctrl-names = "default";
     +
     +       status = "okay";
     +};
     +
     +&pfc {
     +       tpu_pins: tpu {
     +               groups = "tpu_to2", "tpu_to3";
     +               function = "tpu";
     +       };
     +};

   - Exercise userspace PWM control for pwm[2,3] of 
/sys/class/pwm/pwmchip1/ .
   - Inspect PWM signals on the input side of { CN29-[58,60] or 
SW31-[1,2] (only for Salvator-xs) } using an oscilloscope.

Thank you,
Dong
>> Cao Van Dong (5):
>>    clk: renesas: r8a779{5|6|65}: Add TPU clock
>>    arm64: dts: renesas: r8a7795: Add TPU support
>>    arm64: dts: renesas: r8a7796: Add TPU support
>>    arm64: dts: renesas: r8a77965: Add TPU support
>>    dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings
>>
>>   Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt |  3 +++
>>   arch/arm64/boot/dts/renesas/r8a7795.dtsi                  | 11 +++++++++++
>>   arch/arm64/boot/dts/renesas/r8a7796.dtsi                  | 11 +++++++++++
>>   arch/arm64/boot/dts/renesas/r8a77965.dtsi                 | 11 +++++++++++
>>   drivers/clk/renesas/r8a7795-cpg-mssr.c                    |  1 +
>>   drivers/clk/renesas/r8a7796-cpg-mssr.c                    |  1 +
>>   drivers/clk/renesas/r8a77965-cpg-mssr.c                   |  1 +
>>   7 files changed, 39 insertions(+)
>>
>> -- 
>> 2.7.4
>>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings
  2019-04-25  1:25 ` [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings Cao Van Dong
  2019-05-01 20:02   ` Rob Herring
  2019-05-03  9:25   ` Geert Uytterhoeven
@ 2019-05-08 10:07   ` Simon Horman
  2 siblings, 0 replies; 18+ messages in thread
From: Simon Horman @ 2019-05-08 10:07 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: linux-renesas-soc, geert+renesas, broonie, devicetree,
	mark.rutland, daniel.lezcano, tglx, robh, yoshihiro.shimoda.uh,
	kuninori.morimoto.gx, h-inayoshi, na-hoan

On Thu, Apr 25, 2019 at 10:25:17AM +0900, Cao Van Dong wrote:
> Document the R-Car H3/M3-W/M3-N (R8A779{5|6|65}) SoC in the Renesas TPU bindings.
> 
> Signed-off-by: Cao Van Dong <cv-dong@jinso.co.jp>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N
  2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
                   ` (5 preceding siblings ...)
  2019-04-26  9:41 ` [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Simon Horman
@ 2019-05-08 10:08 ` Simon Horman
  6 siblings, 0 replies; 18+ messages in thread
From: Simon Horman @ 2019-05-08 10:08 UTC (permalink / raw)
  To: Cao Van Dong
  Cc: linux-renesas-soc, geert+renesas, broonie, devicetree,
	mark.rutland, daniel.lezcano, tglx, robh, yoshihiro.shimoda.uh,
	kuninori.morimoto.gx, h-inayoshi, na-hoan

On Thu, Apr 25, 2019 at 10:25:12AM +0900, Cao Van Dong wrote:
> This series adds tpu support for r8a7795/r8a7796/r8a77965 SoCs.
> Based on the renesas-drivers-2019-04-02-v5.1-rc3 tag of renesas-drivers tree.
> For test, after booting, I found the device was registered in the booting log.
> 
> Cao Van Dong (5):
>   clk: renesas: r8a779{5|6|65}: Add TPU clock
>   arm64: dts: renesas: r8a7795: Add TPU support
>   arm64: dts: renesas: r8a7796: Add TPU support
>   arm64: dts: renesas: r8a77965: Add TPU support
>   dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings

Thanks,

I have applied the dts patches for inclusion in v5.3 based on
a) Testing by Geert and yourself; and
b) A belief that the hardware is very similar on the SoCs covered
   by this patchset

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2019-05-08 10:08 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25  1:25 [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Cao Van Dong
2019-04-25  1:25 ` [PATCH v2 1/5] clk: renesas: r8a779{5|6|65}: Add TPU clock Cao Van Dong
2019-04-26  8:39   ` Geert Uytterhoeven
2019-04-25  1:25 ` [PATCH v2 2/5] arm64: dts: renesas: r8a7795: Add TPU support Cao Van Dong
2019-05-03  9:25   ` Geert Uytterhoeven
2019-05-07  5:44   ` Cao Van Dong
2019-04-25  1:25 ` [PATCH v2 3/5] arm64: dts: renesas: r8a7796: " Cao Van Dong
2019-05-03  9:26   ` Geert Uytterhoeven
2019-05-07  5:45   ` Cao Van Dong
2019-04-25  1:25 ` [PATCH v2 4/5] arm64: dts: renesas: r8a77965: " Cao Van Dong
2019-05-03  9:28   ` Geert Uytterhoeven
2019-04-25  1:25 ` [PATCH v2 5/5] dt-bindings: pwm: renesas: tpu: Document R8A779{5|6|65} bindings Cao Van Dong
2019-05-01 20:02   ` Rob Herring
2019-05-03  9:25   ` Geert Uytterhoeven
2019-05-08 10:07   ` Simon Horman
2019-04-26  9:41 ` [PATCH v2 0/5] Add TPU support for R-Car H3/M3-W/M3-N Simon Horman
2019-05-07  5:48   ` Cao Van Dong
2019-05-08 10:08 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).