* [PATCH] dmaengine: rcar-dmac: Update copyright information @ 2019-04-10 18:26 Niklas Söderlund 2019-04-11 8:49 ` Simon Horman 2019-04-26 11:54 ` Vinod Koul 0 siblings, 2 replies; 12+ messages in thread From: Niklas Söderlund @ 2019-04-10 18:26 UTC (permalink / raw) To: dmaengine; +Cc: linux-renesas-soc, Hiroyuki Yokoyama, Niklas Söderlund From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com> Update copyright and string for Gen3. Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/dma/sh/rcar-dmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c index 2b4f256981695662..580ca1454fe8cf27 100644 --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c @@ -1,8 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Renesas R-Car Gen2 DMA Controller Driver + * Renesas R-Car Gen2/Gen3 DMA Controller Driver * - * Copyright (C) 2014 Renesas Electronics Inc. + * Copyright (C) 2014-2019 Renesas Electronics Inc. * * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com> */ -- 2.21.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-04-10 18:26 [PATCH] dmaengine: rcar-dmac: Update copyright information Niklas Söderlund @ 2019-04-11 8:49 ` Simon Horman 2019-04-11 15:17 ` Niklas Söderlund 2019-04-26 11:54 ` Vinod Koul 1 sibling, 1 reply; 12+ messages in thread From: Simon Horman @ 2019-04-11 8:49 UTC (permalink / raw) To: Niklas Söderlund; +Cc: dmaengine, linux-renesas-soc, Hiroyuki Yokoyama On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote: > From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com> > > Update copyright and string for Gen3. > > Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > drivers/dma/sh/rcar-dmac.c | 4 ++-- Not strictly related, but is it appropriate to: 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/ 2. Remove drivers/dma/sh/sudmac.c which appears unused ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-04-11 8:49 ` Simon Horman @ 2019-04-11 15:17 ` Niklas Söderlund 2019-04-24 12:22 ` Geert Uytterhoeven 0 siblings, 1 reply; 12+ messages in thread From: Niklas Söderlund @ 2019-04-11 15:17 UTC (permalink / raw) To: Simon Horman; +Cc: dmaengine, linux-renesas-soc, Hiroyuki Yokoyama On 2019-04-11 10:49:37 +0200, Simon Horman wrote: > On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote: > > From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com> > > > > Update copyright and string for Gen3. > > > > Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Thanks. > > > --- > > drivers/dma/sh/rcar-dmac.c | 4 ++-- > > Not strictly related, but is it appropriate to: > > 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/ > 2. Remove drivers/dma/sh/sudmac.c which appears unused I let someone with a better grasp of history answer this one. From my side removing drivers which are unused seems like a good idea :-) -- Regards, Niklas Söderlund ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-04-11 15:17 ` Niklas Söderlund @ 2019-04-24 12:22 ` Geert Uytterhoeven 2019-04-25 3:52 ` Yoshihiro Shimoda 0 siblings, 1 reply; 12+ messages in thread From: Geert Uytterhoeven @ 2019-04-24 12:22 UTC (permalink / raw) To: Niklas Söderlund, Yoshihiro Shimoda Cc: Simon Horman, dmaengine, Linux-Renesas, Hiroyuki Yokoyama Hi Niklas, Shimoda-san, On Thu, Apr 11, 2019 at 5:18 PM Niklas Söderlund <niklas.soderlund@ragnatech.se> wrote: > On 2019-04-11 10:49:37 +0200, Simon Horman wrote: > > On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote: > > Not strictly related, but is it appropriate to: > > > > 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/ That may make sense... > > 2. Remove drivers/dma/sh/sudmac.c which appears unused > > I let someone with a better grasp of history answer this one. From my > side removing drivers which are unused seems like a good idea :-) There seem to be some (half-baked?) interaction between sudmac.c and drivers/usb/gadget/udc/r8a66597-udc.c and drivers/usb/renesas_usbhs/fifo.c. These don't seem to be used at all on Renesas ARM platforms, but CONFIG_USB_R8A66597_HCD is enabled in shmobile_defconfig and multi_v7_defconfig? Shimoda-san: can you please enlighten us? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-04-24 12:22 ` Geert Uytterhoeven @ 2019-04-25 3:52 ` Yoshihiro Shimoda 2019-04-26 11:53 ` Vinod Koul 0 siblings, 1 reply; 12+ messages in thread From: Yoshihiro Shimoda @ 2019-04-25 3:52 UTC (permalink / raw) To: Geert Uytterhoeven, Niklas Söderlund Cc: Simon Horman, dmaengine, Linux-Renesas, HIROYUKI YOKOYAMA Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, April 24, 2019 9:22 PM > > Hi Niklas, Shimoda-san, > > On Thu, Apr 11, 2019 at 5:18 PM Niklas Söderlund > <niklas.soderlund@ragnatech.se> wrote: > > On 2019-04-11 10:49:37 +0200, Simon Horman wrote: > > > On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote: > > > Not strictly related, but is it appropriate to: > > > > > > 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/ > > That may make sense... > > > > 2. Remove drivers/dma/sh/sudmac.c which appears unused > > > > I let someone with a better grasp of history answer this one. From my > > side removing drivers which are unused seems like a good idea :-) > > There seem to be some (half-baked?) interaction between sudmac.c and > drivers/usb/gadget/udc/r8a66597-udc.c and drivers/usb/renesas_usbhs/fifo.c. > These don't seem to be used at all on Renesas ARM platforms, but > CONFIG_USB_R8A66597_HCD is enabled in shmobile_defconfig and > multi_v7_defconfig? > > Shimoda-san: can you please enlighten us? > Thanks! Sure. - SH4A / sh7757 has SUDMAC. (any other Renesas ARM platforms don't have it). # sh7757 is not public product though... - At first, I added this SUDMAC support into r8a66597-udc. - But, our direction is changed by some reason. So, we use renesas_usbhs driver anyway. - The renesas_usbhs supports dmaengine, so I added dma/sh/sudmac driver. - However, for some reasons (maybe I'm busy for other projects?), I didn't add using the sudmac support into arch/sh/kernel/cpu/sh4a/setup-sh7757.c. - So, no one uses both r8a66597-udc and sudmac now. From 2013 (added the sudmac driver) to now, since no one integrated the sudmac for sh7757, I think we can remove the driver. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-04-25 3:52 ` Yoshihiro Shimoda @ 2019-04-26 11:53 ` Vinod Koul 2019-05-09 12:55 ` Simon Horman 0 siblings, 1 reply; 12+ messages in thread From: Vinod Koul @ 2019-04-26 11:53 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Geert Uytterhoeven, Niklas Söderlund, Simon Horman, dmaengine, Linux-Renesas, HIROYUKI YOKOYAMA On 25-04-19, 03:52, Yoshihiro Shimoda wrote: > Hi Geert-san, > > > From: Geert Uytterhoeven, Sent: Wednesday, April 24, 2019 9:22 PM > > > > Hi Niklas, Shimoda-san, > > > > On Thu, Apr 11, 2019 at 5:18 PM Niklas Söderlund > > <niklas.soderlund@ragnatech.se> wrote: > > > On 2019-04-11 10:49:37 +0200, Simon Horman wrote: > > > > On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote: > > > > Not strictly related, but is it appropriate to: > > > > > > > > 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/ > > > > That may make sense... > > > > > > 2. Remove drivers/dma/sh/sudmac.c which appears unused > > > > > > I let someone with a better grasp of history answer this one. From my > > > side removing drivers which are unused seems like a good idea :-) > > > > There seem to be some (half-baked?) interaction between sudmac.c and > > drivers/usb/gadget/udc/r8a66597-udc.c and drivers/usb/renesas_usbhs/fifo.c. > > These don't seem to be used at all on Renesas ARM platforms, but > > CONFIG_USB_R8A66597_HCD is enabled in shmobile_defconfig and > > multi_v7_defconfig? > > > > Shimoda-san: can you please enlighten us? > > Thanks! > > Sure. > > - SH4A / sh7757 has SUDMAC. (any other Renesas ARM platforms don't have it). > # sh7757 is not public product though... > - At first, I added this SUDMAC support into r8a66597-udc. > - But, our direction is changed by some reason. So, we use renesas_usbhs driver anyway. > - The renesas_usbhs supports dmaengine, so I added dma/sh/sudmac driver. > - However, for some reasons (maybe I'm busy for other projects?), > I didn't add using the sudmac support into arch/sh/kernel/cpu/sh4a/setup-sh7757.c. > - So, no one uses both r8a66597-udc and sudmac now. > > From 2013 (added the sudmac driver) to now, since no one integrated the sudmac for sh7757, > I think we can remove the driver. And where is the removal patch :) -- ~Vinod ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-04-26 11:53 ` Vinod Koul @ 2019-05-09 12:55 ` Simon Horman 2019-05-10 11:03 ` Yoshihiro Shimoda 0 siblings, 1 reply; 12+ messages in thread From: Simon Horman @ 2019-05-09 12:55 UTC (permalink / raw) To: Vinod Koul Cc: Yoshihiro Shimoda, Geert Uytterhoeven, Niklas Söderlund, dmaengine, Linux-Renesas, HIROYUKI YOKOYAMA On Fri, Apr 26, 2019 at 05:23:43PM +0530, Vinod Koul wrote: > On 25-04-19, 03:52, Yoshihiro Shimoda wrote: > > Hi Geert-san, > > > > > From: Geert Uytterhoeven, Sent: Wednesday, April 24, 2019 9:22 PM > > > > > > Hi Niklas, Shimoda-san, > > > > > > On Thu, Apr 11, 2019 at 5:18 PM Niklas Söderlund > > > <niklas.soderlund@ragnatech.se> wrote: > > > > On 2019-04-11 10:49:37 +0200, Simon Horman wrote: > > > > > On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote: > > > > > Not strictly related, but is it appropriate to: > > > > > > > > > > 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/ > > > > > > That may make sense... > > > > > > > > 2. Remove drivers/dma/sh/sudmac.c which appears unused > > > > > > > > I let someone with a better grasp of history answer this one. From my > > > > side removing drivers which are unused seems like a good idea :-) > > > > > > There seem to be some (half-baked?) interaction between sudmac.c and > > > drivers/usb/gadget/udc/r8a66597-udc.c and drivers/usb/renesas_usbhs/fifo.c. > > > These don't seem to be used at all on Renesas ARM platforms, but > > > CONFIG_USB_R8A66597_HCD is enabled in shmobile_defconfig and > > > multi_v7_defconfig? > > > > > > Shimoda-san: can you please enlighten us? > > > Thanks! > > > > Sure. > > > > - SH4A / sh7757 has SUDMAC. (any other Renesas ARM platforms don't have it). > > # sh7757 is not public product though... > > - At first, I added this SUDMAC support into r8a66597-udc. > > - But, our direction is changed by some reason. So, we use renesas_usbhs driver anyway. > > - The renesas_usbhs supports dmaengine, so I added dma/sh/sudmac driver. > > - However, for some reasons (maybe I'm busy for other projects?), > > I didn't add using the sudmac support into arch/sh/kernel/cpu/sh4a/setup-sh7757.c. > > - So, no one uses both r8a66597-udc and sudmac now. > > > > From 2013 (added the sudmac driver) to now, since no one integrated the sudmac for sh7757, > > I think we can remove the driver. > > And where is the removal patch :) Sorry for the delay, I have just posted [PATCH] dmaengine: sudmac: remove unused driver Shimoda-san, can we go further and also: 1. Remove the r8a66597-udc driver, which also seems unused 2. Remove (minimal) sudmac integration from usbhs ? ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-05-09 12:55 ` Simon Horman @ 2019-05-10 11:03 ` Yoshihiro Shimoda 2019-05-13 12:20 ` Simon Horman 0 siblings, 1 reply; 12+ messages in thread From: Yoshihiro Shimoda @ 2019-05-10 11:03 UTC (permalink / raw) To: Simon Horman Cc: Geert Uytterhoeven, Niklas Söderlund, dmaengine, Linux-Renesas, HIROYUKI YOKOYAMA, Vinod Koul Hi Simon-san, > From: Simon Horman, Sent: Thursday, May 9, 2019 9:55 PM > <snip> > Shimoda-san, can we go further and also: > > 1. Remove the r8a66597-udc driver, which also seems unused > 2. Remove (minimal) sudmac integration from usbhs ? I think so. I'll do both. About the 2, I'll do it when adding RZ/A2 support from Chris-san is applied. Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-05-10 11:03 ` Yoshihiro Shimoda @ 2019-05-13 12:20 ` Simon Horman 2019-06-04 4:20 ` Yoshihiro Shimoda 0 siblings, 1 reply; 12+ messages in thread From: Simon Horman @ 2019-05-13 12:20 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Geert Uytterhoeven, Niklas Söderlund, dmaengine, Linux-Renesas, HIROYUKI YOKOYAMA, Vinod Koul On Fri, May 10, 2019 at 11:03:48AM +0000, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Thursday, May 9, 2019 9:55 PM > > > <snip> > > Shimoda-san, can we go further and also: > > > > 1. Remove the r8a66597-udc driver, which also seems unused > > 2. Remove (minimal) sudmac integration from usbhs ? > > I think so. I'll do both. > About the 2, I'll do it when adding RZ/A2 support from Chris-san is applied. Thanks Shimoda-san, much appreciated. ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-05-13 12:20 ` Simon Horman @ 2019-06-04 4:20 ` Yoshihiro Shimoda 2019-06-04 9:38 ` Simon Horman 0 siblings, 1 reply; 12+ messages in thread From: Yoshihiro Shimoda @ 2019-06-04 4:20 UTC (permalink / raw) To: Simon Horman; +Cc: Linux-Renesas Hi Simon-san again, (clean up on CC) This is just a record. > From: Simon Horman, Sent: Monday, May 13, 2019 9:20 PM <snip> > > > Shimoda-san, can we go further and also: > > > > > > 1. Remove the r8a66597-udc driver, which also seems unused I overlooked that some SuperH platforms used this driver like below. So, I will not submit removing this driver patch at this time. $ git grep -l r8a66597_udc arch/sh/boards/mach-ecovec24/setup.c arch/sh/boards/mach-kfr2r09/setup.c arch/sh/boards/mach-se/7724/setup.c > > > 2. Remove (minimal) sudmac integration from usbhs ? I have submitted a patch like below: https://patchwork.kernel.org/patch/10974161/ Best regards, Yoshihiro Shimoda ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-06-04 4:20 ` Yoshihiro Shimoda @ 2019-06-04 9:38 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2019-06-04 9:38 UTC (permalink / raw) To: Yoshihiro Shimoda; +Cc: Linux-Renesas On Tue, Jun 04, 2019 at 04:20:52AM +0000, Yoshihiro Shimoda wrote: > Hi Simon-san again, > (clean up on CC) > > This is just a record. > > > From: Simon Horman, Sent: Monday, May 13, 2019 9:20 PM > <snip> > > > > Shimoda-san, can we go further and also: > > > > > > > > 1. Remove the r8a66597-udc driver, which also seems unused > > I overlooked that some SuperH platforms used this driver like below. > So, I will not submit removing this driver patch at this time. > > $ git grep -l r8a66597_udc > arch/sh/boards/mach-ecovec24/setup.c > arch/sh/boards/mach-kfr2r09/setup.c > arch/sh/boards/mach-se/7724/setup.c Thanks for looking into this. I agree we should keep the r8a66597-udc driver for now. > > > > 2. Remove (minimal) sudmac integration from usbhs ? > > I have submitted a patch like below: > https://patchwork.kernel.org/patch/10974161/ Thanks! ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dmaengine: rcar-dmac: Update copyright information 2019-04-10 18:26 [PATCH] dmaengine: rcar-dmac: Update copyright information Niklas Söderlund 2019-04-11 8:49 ` Simon Horman @ 2019-04-26 11:54 ` Vinod Koul 1 sibling, 0 replies; 12+ messages in thread From: Vinod Koul @ 2019-04-26 11:54 UTC (permalink / raw) To: Niklas Söderlund; +Cc: dmaengine, linux-renesas-soc, Hiroyuki Yokoyama On 10-04-19, 20:26, Niklas Söderlund wrote: > From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com> > > Update copyright and string for Gen3. Applied, thanks -- ~Vinod ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-06-04 9:38 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-04-10 18:26 [PATCH] dmaengine: rcar-dmac: Update copyright information Niklas Söderlund 2019-04-11 8:49 ` Simon Horman 2019-04-11 15:17 ` Niklas Söderlund 2019-04-24 12:22 ` Geert Uytterhoeven 2019-04-25 3:52 ` Yoshihiro Shimoda 2019-04-26 11:53 ` Vinod Koul 2019-05-09 12:55 ` Simon Horman 2019-05-10 11:03 ` Yoshihiro Shimoda 2019-05-13 12:20 ` Simon Horman 2019-06-04 4:20 ` Yoshihiro Shimoda 2019-06-04 9:38 ` Simon Horman 2019-04-26 11:54 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).