From: Simon Horman <horms@verge.net.au>
To: Ulrich Hecht <uli@fpond.eu>
Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, wsa@the-dreams.de, magnus.damm@gmail.com
Subject: Re: [PATCH] ravb: implement MTU change while device is up
Date: Mon, 13 May 2019 14:18:07 +0200 [thread overview]
Message-ID: <20190513121807.cutayiact3qdbxt4@verge.net.au> (raw)
In-Reply-To: <344020243.1186987.1557415941124@webmail.strato.com>
On Thu, May 09, 2019 at 05:32:21PM +0200, Ulrich Hecht wrote:
>
> > On May 9, 2019 at 12:10 PM Simon Horman <horms@verge.net.au> wrote:
> >
> >
> > On Thu, May 09, 2019 at 08:57:44AM +0200, Ulrich Hecht wrote:
> > >
> > > > On May 8, 2019 at 6:52 PM Niklas Söderlund <niklas.soderlund@ragnatech.se> wrote:
> > > >
> > > >
> > > > Hi Sergei,
> > > >
> > > > On 2019-05-08 18:59:01 +0300, Sergei Shtylyov wrote:
> > > > > Hello!
> > > > >
> > > > > On 05/08/2019 06:21 PM, Ulrich Hecht wrote:
> > > > >
> > > > > > Uses the same method as various other drivers: shut the device down,
> > > > > > change the MTU, then bring it back up again.
> > > > > >
> > > > > > Tested on Renesas D3 Draak board.
> > > > > >
> > > > > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
> > > > >
> > > > > You should have CC'ed me (as an reviewer for the Renesas drivers).
> > >
> > > Sorry, will do next time.
> > >
> > > > >
> > > > > How about the code below instead?
> > > > >
> > > > > if (netif_running(ndev))
> > > > > ravb_close(ndev);
> > > > >
> > > > > ndev->mtu = new_mtu;
> > > > > netdev_update_features(ndev);
> > > >
> > > > Is there a need to call netdev_update_features() even if the if is not
> > > > running?
> > >
> > > In my testing, it didn't seem so.
> >
> > That may be because your testing doesn't cover cases where it would make
> > any difference.
>
> Cases other than changing the MTU while the device is up?
I was thinking of cases where listeners are registered for the
notifier that netdev_update_features() triggers.
next prev parent reply other threads:[~2019-05-13 12:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 15:21 [PATCH] ravb: implement MTU change while device is up Ulrich Hecht
2019-05-08 15:59 ` Sergei Shtylyov
2019-05-08 16:52 ` Niklas Söderlund
2019-05-09 6:57 ` Ulrich Hecht
2019-05-09 10:10 ` Simon Horman
2019-05-09 15:32 ` Ulrich Hecht
2019-05-13 12:18 ` Simon Horman [this message]
2019-05-20 12:09 ` Wolfram Sang
2019-05-22 11:59 ` Simon Horman
2019-05-23 1:02 ` Ulrich Hecht
2019-05-08 16:50 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513121807.cutayiact3qdbxt4@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=uli@fpond.eu \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).