From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B30C04AB4 for ; Tue, 14 May 2019 15:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A38F720879 for ; Tue, 14 May 2019 15:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726025AbfENPab (ORCPT ); Tue, 14 May 2019 11:30:31 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:42752 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfENPab (ORCPT ); Tue, 14 May 2019 11:30:31 -0400 Received: from svr-orw-mbx-01.mgc.mentorg.com ([147.34.90.201]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hQZNp-0002lK-D1 from George_Davis@mentor.com ; Tue, 14 May 2019 08:30:25 -0700 Received: from localhost (147.34.91.1) by svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 14 May 2019 08:30:23 -0700 Date: Tue, 14 May 2019 11:30:22 -0400 From: "George G. Davis" To: Geert Uytterhoeven CC: Eugeniu Rosca , Simon Horman , Wolfram Sang , Greg Kroah-Hartman , Jiri Slaby , "open list:SERIAL DRIVERS" , open list , Chris Brandt , Ulrich Hecht , Andy Lowe , Linux-Renesas , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Magnus Damm , Rob Herring , Mark Rutland , stable Subject: Re: [PATCH v2] serial: sh-sci: disable DMA for uart_console Message-ID: <20190514153021.GC18528@mam-gdavis-lt> References: <1557762446-23811-1-git-send-email-george_davis@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello Geert, On Tue, May 14, 2019 at 10:28:34AM +0200, Geert Uytterhoeven wrote: > Hi George, > > On Mon, May 13, 2019 at 5:48 PM George G. Davis wrote: > > As noted in commit 84b40e3b57ee ("serial: 8250: omap: Disable DMA for > > console UART"), UART console lines use low-level PIO only access functions > > which will conflict with use of the line when DMA is enabled, e.g. when > > the console line is also used for systemd messages. So disable DMA > > support for UART console lines. > > > > Fixes: https://patchwork.kernel.org/patch/10929511/ > > I don't think this is an appropriate reference, as it points to a patch that > was never applied. I included it as a link to an upstream problem report similar to other commits that I previewed. The link provides the extra context that I was perhaps to lazy to note in the commit header. > As the problem has basically existed forever, Agreed > IMHO no Fixes tag > is needed. I've dropped the Fixes line. > > Reported-by: Michael Rodin > > Tested-by: Eugeniu Rosca > > Reviewed-by: Simon Horman > > Reviewed-by: Wolfram Sang > > Cc: stable@vger.kernel.org > > Signed-off-by: George G. Davis > > --- > > v2: Clarify comment regarding DMA support on kernel console, > > add {Tested,Reviewed}-by:, and Cc: linux-stable lines. > > Thanks for the update! Thanks! I'll submit v3 later today. > Reviewed-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, George