Re: [PATCH] media: fdp1: Support M3N and E3 platforms

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Kieran,

Thank you for the patch.

On Wed, May 15, 2019 at 04:39:12PM +0100, Kieran Bingham wrote:
> New Gen3 R-Car platforms incorporate the FDP1 with an updated version
> register. No code change is required to support these targets, but they
> will currently report an error stating that the device can not be
> identified.
> 
> Update the driver to match against the new device types.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
>  drivers/media/platform/rcar_fdp1.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index 6bda1eee9170..4f103be215d3 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -257,6 +257,8 @@ MODULE_PARM_DESC(debug, "activate debug info");
>  #define FD1_IP_H3_ES1			0x02010101
>  #define FD1_IP_M3W			0x02010202
>  #define FD1_IP_H3			0x02010203
> +#define FD1_IP_M3N			0x02010204
> +#define FD1_IP_E3			0x02010205
>  
>  /* LUTs */
>  #define FD1_LUT_DIF_ADJ			0x1000
> @@ -2365,6 +2367,12 @@ static int fdp1_probe(struct platform_device *pdev)
>  	case FD1_IP_H3:
>  		dprintk(fdp1, "FDP1 Version R-Car H3\n");
>  		break;
> +	case FD1_IP_M3N:
> +		dprintk(fdp1, "FDP1 Version R-Car M3N\n");
> +		break;
> +	case FD1_IP_E3:
> +		dprintk(fdp1, "FDP1 Version R-Car E3\n");
> +		break;
>  	default:
>  		dev_err(fdp1->dev, "FDP1 Unidentifiable (0x%08x)\n",
>  				hw_version);

-- 
Regards,

Laurent Pinchart