From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C971C04AAF for ; Thu, 16 May 2019 11:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0381B20645 for ; Thu, 16 May 2019 11:21:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UhxHcJHS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfEPLVs (ORCPT ); Thu, 16 May 2019 07:21:48 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33612 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbfEPLVp (ORCPT ); Thu, 16 May 2019 07:21:45 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F7462FD; Thu, 16 May 2019 13:21:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1558005703; bh=Od9FJhOCAF6iWV0Sudo2Dd31NOffbbeZHA5QWn6iBLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UhxHcJHS3SHnGvEF9YiMoSLkUJGu5z6K52yaP6vGPEHTgX84RMStPcGuCNKPtJ0Yq lgNoL6XlVAg/xELWUXoHSuc081PGmKBKkcoIv/xkh108wRcXdvQupTRvLbozSn6Dzp 1E3yK4jFcIfK+PIZmvKANoWJOB57QUc8zFAl8s3c= Date: Thu, 16 May 2019 14:21:27 +0300 From: Laurent Pinchart To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Ulrich Hecht , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ulrich Hecht Subject: Re: [PATCH v2 3/8] rcar-vin: Allow interrupting lock when trying to open the video device Message-ID: <20190516112127.GA14820@pendragon.ideasonboard.com> References: <20190516011417.10590-1-niklas.soderlund+renesas@ragnatech.se> <20190516011417.10590-4-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190516011417.10590-4-niklas.soderlund+renesas@ragnatech.se> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Niklas, Thank you for the patch. On Thu, May 16, 2019 at 03:14:12AM +0200, Niklas Söderlund wrote: > The user should be allowed to break waiting for the lock when opening > the video device. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c > index 0841f1a0bfd7ba3a..f67cef97b89a3bd4 100644 > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > @@ -821,7 +821,9 @@ static int rvin_open(struct file *file) > struct rvin_dev *vin = video_drvdata(file); > int ret; > > - mutex_lock(&vin->lock); > + ret = mutex_lock_interruptible(&vin->lock); > + if (ret) > + return ret; > > file->private_data = vin; > -- Regards, Laurent Pinchart