From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3D5C04AAF for ; Thu, 16 May 2019 11:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9999C20833 for ; Thu, 16 May 2019 11:45:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eoJqV1iV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727905AbfEPLpl (ORCPT ); Thu, 16 May 2019 07:45:41 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34666 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727832AbfEPLpk (ORCPT ); Thu, 16 May 2019 07:45:40 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DA152FD; Thu, 16 May 2019 13:45:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1558007138; bh=FaWGwPPxKSmmd3IsBWBU6zDpGzQJKlRLkQ6P1zzv1T4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eoJqV1iVQusmigX4QukIKgM3aGt9TSVaxaofN3czHeRKRFEyIfDK8BMdbhcT6QxZ6 5bEdYjr7+JHLP83gFhUEk+mX87jrKxltQVCyHLnV+yVwiMXP0x8RRkSp7WCHOqIsTX eGk7ZjqAgQe5F1ooQIbZfwMVy+9W/VqmYo5GhH8c= Date: Thu, 16 May 2019 14:45:22 +0300 From: Laurent Pinchart To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Ulrich Hecht , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ulrich Hecht Subject: Re: [PATCH v2 7/8] rcar-vin: Fold rvin_initialize_device() into rvin_open() Message-ID: <20190516114522.GF14820@pendragon.ideasonboard.com> References: <20190516011417.10590-1-niklas.soderlund+renesas@ragnatech.se> <20190516011417.10590-8-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190516011417.10590-8-niklas.soderlund+renesas@ragnatech.se> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Niklas, Thank you for the patch. On Thu, May 16, 2019 at 03:14:16AM +0200, Niklas Söderlund wrote: > The function no longer serve a purpose as most tasks it performed have > been refactored, fold what remains of it into the only caller. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Ulrich Hecht > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 ++++----------------- > 1 file changed, 4 insertions(+), 17 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c > index 7c8ba4b310706ceb..169639416121f204 100644 > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > @@ -762,20 +762,6 @@ static int rvin_power_parallel(struct rvin_dev *vin, bool on) > return 0; > } > > -static int rvin_initialize_device(struct file *file) > -{ > - struct rvin_dev *vin = video_drvdata(file); > - int ret; > - > - ret = rvin_power_parallel(vin, true); > - if (ret < 0) > - return ret; > - > - v4l2_ctrl_handler_setup(&vin->ctrl_handler); > - > - return 0; > -} > - > static int rvin_open(struct file *file) > { > struct rvin_dev *vin = video_drvdata(file); > @@ -796,10 +782,11 @@ static int rvin_open(struct file *file) > goto err_pm; > > if (v4l2_fh_is_singular_file(file)) { > - if (rvin_initialize_device(file)) { > - ret = -ENODEV; > + ret = rvin_power_parallel(vin, true); > + if (ret < 0) > goto err_open; > - } > + > + v4l2_ctrl_handler_setup(&vin->ctrl_handler); I think you should handle errors here. > } > > mutex_unlock(&vin->lock); -- Regards, Laurent Pinchart