From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kieran Bingham <kieran@ksquared.org.uk>
Subject: Re: [PATCH v8 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy
Date: Fri, 17 May 2019 19:35:17 +0200 [thread overview]
Message-ID: <20190517173517.GA11396@kunai> (raw)
In-Reply-To: <5cdbe188-6c0b-1ba9-d4a1-2d836c1e9652@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
> The only nit I can find is that you could perhaps sweep the patches
> with sed 's/i2c /I2C /'. But that is indeed a nit, so if you're in
> a hurry...
Valid point. I'd like to fix it as a seperate patch, though. One reason
is that it is needed in far more places in this file, too. The main
reason is that I don't want to introduce some stupid last minute typo
after all these reviews.
> Reviewed-by: Peter Rosin <peda@axentia.se>
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-17 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 21:13 [PATCH v8 0/3] i2c: improve i2c_new_{device|dummy} Wolfram Sang
2019-05-16 21:13 ` [PATCH v8 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy Wolfram Sang
2019-05-17 7:16 ` Peter Rosin
2019-05-17 17:35 ` Wolfram Sang [this message]
2019-05-17 8:02 ` Kieran Bingham
2019-05-17 8:56 ` Bartosz Golaszewski
2019-05-17 17:35 ` Wolfram Sang
2019-05-16 21:13 ` [PATCH v8 2/3] i2c: core: add device-managed version of i2c_new_dummy Wolfram Sang
2019-05-17 7:17 ` Peter Rosin
2019-05-17 8:21 ` Kieran Bingham
2019-05-17 8:57 ` Bartosz Golaszewski
2019-05-17 17:35 ` Wolfram Sang
2019-05-16 21:13 ` [PATCH v8 3/3] mfd: da9063: occupy second I2C address, too Wolfram Sang
2019-05-17 7:17 ` Peter Rosin
2019-05-17 8:57 ` Bartosz Golaszewski
2019-05-17 14:56 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517173517.GA11396@kunai \
--to=wsa@the-dreams.de \
--cc=brgl@bgdev.pl \
--cc=hkallweit1@gmail.com \
--cc=kieran@ksquared.org.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).