From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"open list:DRM DRIVERS FOR RENESAS"
<dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: rcar-du: writeback: include interface header
Date: Sat, 18 May 2019 01:06:47 +0300 [thread overview]
Message-ID: <20190517220647.GA21057@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190517212050.3561-1-kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Fri, May 17, 2019 at 10:20:49PM +0100, Kieran Bingham wrote:
> The new writeback feature is exports functions so that they can
> integrate into the rcar_du_kms module.
>
> The interface functions are defined in the rcar_du_writeback header, but
> it is not included in the object file itself leading to compiler
> warnings for missing prototypes.
>
> Include the header as appropriate.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
And applied to my tree.
> ---
> drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> index 989a0be94131..ae07290bba6a 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> @@ -14,6 +14,7 @@
> #include "rcar_du_crtc.h"
> #include "rcar_du_drv.h"
> #include "rcar_du_kms.h"
> +#include "rcar_du_writeback.h"
>
> /**
> * struct rcar_du_wb_conn_state - Driver-specific writeback connector state
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-05-17 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 21:20 [PATCH] drm: rcar-du: writeback: include interface header Kieran Bingham
2019-05-17 22:06 ` Laurent Pinchart [this message]
2019-05-18 8:42 ` Sergei Shtylyov
2019-05-18 17:11 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517220647.GA21057@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).