Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] drm: rcar-du: writeback: include interface header
@ 2019-05-17 21:20 Kieran Bingham
  2019-05-17 22:06 ` Laurent Pinchart
  2019-05-18  8:42 ` Sergei Shtylyov
  0 siblings, 2 replies; 4+ messages in thread
From: Kieran Bingham @ 2019-05-17 21:20 UTC (permalink / raw)
  To: Laurent Pinchart, linux-renesas-soc
  Cc: Kieran Bingham, David Airlie, Daniel Vetter, dri-devel, linux-kernel

The new writeback feature is exports functions so that they can
integrate into the rcar_du_kms module.

The interface functions are defined in the rcar_du_writeback header, but
it is not included in the object file itself leading to compiler
warnings for missing prototypes.

Include the header as appropriate.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
index 989a0be94131..ae07290bba6a 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
@@ -14,6 +14,7 @@
 #include "rcar_du_crtc.h"
 #include "rcar_du_drv.h"
 #include "rcar_du_kms.h"
+#include "rcar_du_writeback.h"
 
 /**
  * struct rcar_du_wb_conn_state - Driver-specific writeback connector state
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: rcar-du: writeback: include interface header
  2019-05-17 21:20 [PATCH] drm: rcar-du: writeback: include interface header Kieran Bingham
@ 2019-05-17 22:06 ` Laurent Pinchart
  2019-05-18  8:42 ` Sergei Shtylyov
  1 sibling, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2019-05-17 22:06 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: linux-renesas-soc, David Airlie, Daniel Vetter,
	open list:DRM DRIVERS FOR RENESAS, open list

Hi Kieran,

Thank you for the patch.

On Fri, May 17, 2019 at 10:20:49PM +0100, Kieran Bingham wrote:
> The new writeback feature is exports functions so that they can
> integrate into the rcar_du_kms module.
> 
> The interface functions are defined in the rcar_du_writeback header, but
> it is not included in the object file itself leading to compiler
> warnings for missing prototypes.
> 
> Include the header as appropriate.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

And applied to my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> index 989a0be94131..ae07290bba6a 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> @@ -14,6 +14,7 @@
>  #include "rcar_du_crtc.h"
>  #include "rcar_du_drv.h"
>  #include "rcar_du_kms.h"
> +#include "rcar_du_writeback.h"
>  
>  /**
>   * struct rcar_du_wb_conn_state - Driver-specific writeback connector state

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: rcar-du: writeback: include interface header
  2019-05-17 21:20 [PATCH] drm: rcar-du: writeback: include interface header Kieran Bingham
  2019-05-17 22:06 ` Laurent Pinchart
@ 2019-05-18  8:42 ` Sergei Shtylyov
  2019-05-18 17:11   ` Laurent Pinchart
  1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2019-05-18  8:42 UTC (permalink / raw)
  To: Kieran Bingham, Laurent Pinchart, linux-renesas-soc
  Cc: David Airlie, Daniel Vetter, open list:DRM DRIVERS FOR RENESAS,
	open list

Hello!

On 18.05.2019 0:20, Kieran Bingham wrote:

> The new writeback feature is exports functions so that they can
                             ^^ not needed?

> integrate into the rcar_du_kms module.
> 
> The interface functions are defined in the rcar_du_writeback header, but
> it is not included in the object file itself leading to compiler
> warnings for missing prototypes.
> 
> Include the header as appropriate.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: rcar-du: writeback: include interface header
  2019-05-18  8:42 ` Sergei Shtylyov
@ 2019-05-18 17:11   ` Laurent Pinchart
  0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2019-05-18 17:11 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Kieran Bingham, linux-renesas-soc, David Airlie, Daniel Vetter,
	open list:DRM DRIVERS FOR RENESAS, open list

Hi Sergei,

On Sat, May 18, 2019 at 11:42:28AM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 18.05.2019 0:20, Kieran Bingham wrote:
> 
> > The new writeback feature is exports functions so that they can
>                              ^^ not needed?

Good catch. I'll fix it in my branch.

> > integrate into the rcar_du_kms module.
> > 
> > The interface functions are defined in the rcar_du_writeback header, but
> > it is not included in the object file itself leading to compiler
> > warnings for missing prototypes.
> > 
> > Include the header as appropriate.
> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> [...]
> 
> MBR, Sergei

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 21:20 [PATCH] drm: rcar-du: writeback: include interface header Kieran Bingham
2019-05-17 22:06 ` Laurent Pinchart
2019-05-18  8:42 ` Sergei Shtylyov
2019-05-18 17:11   ` Laurent Pinchart

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox