From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A8AC28CC0 for ; Thu, 30 May 2019 13:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 250FE259D7 for ; Thu, 30 May 2019 13:42:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbfE3Nmw (ORCPT ); Thu, 30 May 2019 09:42:52 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:38062 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfE3Nmw (ORCPT ); Thu, 30 May 2019 09:42:52 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hWLKM-0005dG-Lx; Thu, 30 May 2019 21:42:42 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hWLKI-0003fX-HI; Thu, 30 May 2019 21:42:38 +0800 Date: Thu, 30 May 2019 21:42:38 +0800 From: Herbert Xu To: Eric Biggers Cc: linux-crypto@vger.kernel.org, Geert Uytterhoeven , Thomas Gleixner , Daniel Lezcano , Linux Kernel Mailing List , Linux-Renesas , Linux ARM Subject: Re: [PATCH] crypto: jitterentropy - change back to module_init() Message-ID: <20190530134238.y6pwi2ybib5vdk4p@gondor.apana.org.au> References: <20190521183417.GA121164@gmail.com> <20190521184622.37202-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521184622.37202-1-ebiggers@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, May 21, 2019 at 11:46:22AM -0700, Eric Biggers wrote: > From: Eric Biggers > > "jitterentropy_rng" doesn't have any other implementations, nor is it > tested by the crypto self-tests. So it was unnecessary to change it to > subsys_initcall. Also it depends on the main clocksource being > initialized, which may happen after subsys_initcall, causing this error: > > jitterentropy: Initialization failed with host not compliant with requirements: 2 > > Change it back to module_init(). > > Fixes: c4741b230597 ("crypto: run initcalls for generic implementations earlier") > Reported-by: Geert Uytterhoeven > Signed-off-by: Eric Biggers > --- > crypto/jitterentropy-kcapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt