[PATCH 0/2] usb: renesas_usbhs: remove unused features

[PATCH 0/2] usb: renesas_usbhs: remove unused features

[Yoshihiro Shimoda]

This patch series removes unused features of sudmac and controlling
PWEN/EXTLP.

Yoshihiro Shimoda (2):
  usb: renesas_usbhs: remove sudmac support
  usb: renesas_usbhs: remove controlling PWEN/EXTLP support

 drivers/usb/renesas_usbhs/common.c | 4 ----
 drivers/usb/renesas_usbhs/fifo.c   | 5 +----
 include/linux/usb/renesas_usbhs.h  | 2 --
 3 files changed, 1 insertion(+), 10 deletions(-)

-- 
2.7.4

[PATCH 1/2] usb: renesas_usbhs: remove sudmac support

[Yoshihiro Shimoda]

SUDMAC featurer was supported in v3.10, but was never used by
any platform. So, this patch removes it.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/usb/renesas_usbhs/fifo.c  | 5 +----
 include/linux/usb/renesas_usbhs.h | 1 -
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index 452b456..53f8e2f 100644
--- a/drivers/usb/renesas_usbhs/fifo.c
+++ b/drivers/usb/renesas_usbhs/fifo.c
@@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe,
 	}
 
 	/* "base" will be used below  */
-	if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo))
-		usbhs_write(priv, fifo->sel, base);
-	else
-		usbhs_write(priv, fifo->sel, base | MBW_32);
+	usbhs_write(priv, fifo->sel, base | MBW_32);
 
 	/* check ISEL and CURPIPE value */
 	while (timeout--) {
diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h
index 3f53043..a2481f4d 100644
--- a/include/linux/usb/renesas_usbhs.h
+++ b/include/linux/usb/renesas_usbhs.h
@@ -187,7 +187,6 @@ struct renesas_usbhs_driver_param {
 	 * option:
 	 */
 	u32 has_otg:1; /* for controlling PWEN/EXTLP */
-	u32 has_sudmac:1; /* for SUDMAC */
 	u32 has_usb_dmac:1; /* for USB-DMAC */
 	u32 runtime_pwctrl:1;
 	u32 has_cnen:1;
-- 
2.7.4

[PATCH 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support

[Yoshihiro Shimoda]

Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2,
but was never used by any platform. So, this patch remove it.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/usb/renesas_usbhs/common.c | 4 ----
 include/linux/usb/renesas_usbhs.h  | 1 -
 2 files changed, 5 deletions(-)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index c7c9c5d..a501ea6 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -95,10 +95,6 @@ void usbhs_sys_host_ctrl(struct usbhs_priv *priv, int enable)
 {
 	u16 mask = DCFM | DRPD | DPRPU | HSE | USBE;
 	u16 val  = DCFM | DRPD | HSE | USBE;
-	int has_otg = usbhs_get_dparam(priv, has_otg);
-
-	if (has_otg)
-		usbhs_bset(priv, DVSTCTR, (EXTLP | PWEN), (EXTLP | PWEN));
 
 	/*
 	 * if enable
diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h
index a2481f4d..b2cba7c 100644
--- a/include/linux/usb/renesas_usbhs.h
+++ b/include/linux/usb/renesas_usbhs.h
@@ -186,7 +186,6 @@ struct renesas_usbhs_driver_param {
 	/*
 	 * option:
 	 */
-	u32 has_otg:1; /* for controlling PWEN/EXTLP */
 	u32 has_usb_dmac:1; /* for USB-DMAC */
 	u32 runtime_pwctrl:1;
 	u32 has_cnen:1;
-- 
2.7.4

Re: [PATCH 1/2] usb: renesas_usbhs: remove sudmac support

[Sergei Shtylyov]

Hello!

On 04.06.2019 7:09, Yoshihiro Shimoda wrote:

> SUDMAC featurer was supported in v3.10, but was never used by

    Feature?

> any platform. So, this patch removes it.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
[...]

MBR, Sergei

Re: [PATCH 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support

[Geert Uytterhoeven]

Hi Shimoda-san,

On Tue, Jun 4, 2019 at 6:14 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2,
> but was never used by any platform. So, this patch remove it.

Actually it was used, by legacy (pre-DT) board support for kzm9g and
mackerel.
The last user was removed by commit 30f8925a57d8ad49 ("ARM: shmobile:
Remove legacy board code for KZM-A9-GT").

> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] usb: renesas_usbhs: remove sudmac support

[Geert Uytterhoeven]

On Tue, Jun 4, 2019 at 6:14 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> SUDMAC featurer was supported in v3.10, but was never used by
> any platform. So, this patch removes it.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] usb: renesas_usbhs: remove sudmac support

[Simon Horman]

Hi Shimoda-san,

On Tue, Jun 04, 2019 at 01:09:34PM +0900, Yoshihiro Shimoda wrote:
> SUDMAC featurer was supported in v3.10, but was never used by
> any platform. So, this patch removes it.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  drivers/usb/renesas_usbhs/fifo.c  | 5 +----
>  include/linux/usb/renesas_usbhs.h | 1 -
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
> index 452b456..53f8e2f 100644
> --- a/drivers/usb/renesas_usbhs/fifo.c
> +++ b/drivers/usb/renesas_usbhs/fifo.c
> @@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe,
>  	}
>  
>  	/* "base" will be used below  */
> -	if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo))

I believe usbhsf_is_cfifo() will now be unused and should be removed.

With that change feel free to add:

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


> -		usbhs_write(priv, fifo->sel, base);
> -	else
> -		usbhs_write(priv, fifo->sel, base | MBW_32);
> +	usbhs_write(priv, fifo->sel, base | MBW_32);
>  
>  	/* check ISEL and CURPIPE value */
>  	while (timeout--) {
> diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h
> index 3f53043..a2481f4d 100644
> --- a/include/linux/usb/renesas_usbhs.h
> +++ b/include/linux/usb/renesas_usbhs.h
> @@ -187,7 +187,6 @@ struct renesas_usbhs_driver_param {
>  	 * option:
>  	 */
>  	u32 has_otg:1; /* for controlling PWEN/EXTLP */
> -	u32 has_sudmac:1; /* for SUDMAC */
>  	u32 has_usb_dmac:1; /* for USB-DMAC */
>  	u32 runtime_pwctrl:1;
>  	u32 has_cnen:1;
> -- 
> 2.7.4
> 

Re: [PATCH 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support

[Simon Horman]

On Tue, Jun 04, 2019 at 01:09:35PM +0900, Yoshihiro Shimoda wrote:
> Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2,
> but was never used by any platform. So, this patch remove it.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

RE: [PATCH 1/2] usb: renesas_usbhs: remove sudmac support

[Yoshihiro Shimoda]

Hello!

> From: Sergei Shtylyov, Sent: Tuesday, June 4, 2019 5:06 PM
> 
> Hello!
> 
> On 04.06.2019 7:09, Yoshihiro Shimoda wrote:
> 
> > SUDMAC featurer was supported in v3.10, but was never used by
> 
>     Feature?

Oops! I'll revise it on v2.

Best regards,
Yoshihiro Shimoda

RE: [PATCH 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support

[Yoshihiro Shimoda]

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Tuesday, June 4, 2019 6:14 PM
> 
> Hi Shimoda-san,
> 
> On Tue, Jun 4, 2019 at 6:14 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2,
> > but was never used by any platform. So, this patch remove it.
> 
> Actually it was used, by legacy (pre-DT) board support for kzm9g and
> mackerel.
> The last user was removed by commit 30f8925a57d8ad49 ("ARM: shmobile:
> Remove legacy board code for KZM-A9-GT").

Thank you for the comment. I'll revise the commit log on v2.

> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thank you for your review!

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

RE: [PATCH 1/2] usb: renesas_usbhs: remove sudmac support

[Yoshihiro Shimoda]

Hi Simon-san,

> From: Simon Horman, Sent: Tuesday, June 4, 2019 6:36 PM
> 
> Hi Shimoda-san,
> 
> On Tue, Jun 04, 2019 at 01:09:34PM +0900, Yoshihiro Shimoda wrote:
> > SUDMAC featurer was supported in v3.10, but was never used by
> > any platform. So, this patch removes it.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> >  drivers/usb/renesas_usbhs/fifo.c  | 5 +----
> >  include/linux/usb/renesas_usbhs.h | 1 -
> >  2 files changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
> > index 452b456..53f8e2f 100644
> > --- a/drivers/usb/renesas_usbhs/fifo.c
> > +++ b/drivers/usb/renesas_usbhs/fifo.c
> > @@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe,
> >  	}
> >
> >  	/* "base" will be used below  */
> > -	if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo))
> 
> I believe usbhsf_is_cfifo() will now be unused and should be removed.

Good catch! I'll remove the macro on v2.

> With that change feel free to add:
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Thank you for your review!

Best regards,
Yoshihiro Shimoda