From: Tony Lindgren <tony@atomide.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms+renesas@verge.net.au>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
John Stultz <john.stultz@linaro.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Spyridon Papageorgiou <spapageorgiou@de.adit-jv.com>,
Joshua Frkuska <joshua_frkuska@mentor.com>,
"George G . Davis" <george_davis@mentor.com>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
eyalr@ti.com
Subject: Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ
Date: Mon, 10 Jun 2019 01:30:12 -0700 [thread overview]
Message-ID: <20190610083012.GV5447@atomide.com> (raw)
In-Reply-To: <87tvcxncuq.fsf@codeaurora.org>
Hi,
* Kalle Valo <kvalo@codeaurora.org> [190610 07:01]:
> Eugeniu Rosca <erosca@de.adit-jv.com> writes:
>
> > The wl1837mod datasheet [1] says about the WL_IRQ pin:
> >
> > ---8<---
> > SDIO available, interrupt out. Active high. [..]
> > Set to rising edge (active high) on powerup.
> > ---8<---
> >
> > That's the reason of seeing the interrupt configured as:
> > - IRQ_TYPE_EDGE_RISING on HiKey 960/970
> > - IRQ_TYPE_LEVEL_HIGH on a number of i.MX6 platforms
> >
> > We assert that all those platforms have the WL_IRQ pin connected
> > to the SoC _directly_ (confirmed on HiKey 970 [2]).
> >
> > That's not the case for R-Car Kingfisher extension target, which carries
> > a WL1837MODGIMOCT IC. There is an SN74LV1T04DBVR inverter present
> > between the WLAN_IRQ pin of the WL18* chip and the SoC, effectively
> > reversing the requirement quoted from [1]. IOW, in Kingfisher DTS
> > configuration we would need to use IRQ_TYPE_EDGE_FALLING or
> > IRQ_TYPE_LEVEL_LOW.
> >
> > Unfortunately, v4.2-rc1 commit bd763482c82ea2 ("wl18xx: wlan_irq:
> > support platform dependent interrupt types") made a special case out
> > of these interrupt types. After this commit, it is impossible to provide
> > an IRQ configuration via DTS which would describe an inverter present
> > between the WL18* chip and the SoC, generating the need for workarounds
> > like [3].
> >
> > Create a boolean OF property, called "invert-irq" to specify that
> > the WLAN_IRQ pin of WL18* is connected to the SoC via an inverter.
> >
> > This solution has been successfully tested on R-Car H3ULCB-KF-M06 using
> > the DTS configuration [4] combined with the "invert-irq" property.
> >
> > [1] http://www.ti.com/lit/ds/symlink/wl1837mod.pdf
> > [2] https://www.96boards.org/documentation/consumer/hikey/hikey970/hardware-docs/
> > [3] https://github.com/CogentEmbedded/meta-rcar/blob/289fbd4f8354/meta-rcar-gen3-adas/recipes-kernel/linux/linux-renesas/0024-wl18xx-do-not-invert-IRQ-on-WLxxxx-side.patch
> > [4] https://patchwork.kernel.org/patch/10895879/
> > ("arm64: dts: ulcb-kf: Add support for TI WL1837")
> >
> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
>
> Tony&Eyal, do you agree with this?
Yeah if there's some hardware between the WLAN device and the SoC
inverting the interrupt, I don't think we have clear a way to deal
with it short of setting up a separate irqchip that does the
translation.
But in some cases we also do not want to invert the interrupt, so
I think this property should take IRQ_TYPE_EDGE_RISING and
IRQ_TYPE_EDGE_RISING values to override the setting for
the WLAN end of the hardware?
Let's wait a bit longer for comments from Eyal too.
Regards,
Tony
next prev parent reply other threads:[~2019-06-10 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 17:29 [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ Eugeniu Rosca
2019-06-10 7:01 ` Kalle Valo
2019-06-10 8:30 ` Tony Lindgren [this message]
2019-06-11 8:45 ` Geert Uytterhoeven
2019-06-11 9:00 ` Marc Zyngier
2019-06-12 9:45 ` Eugeniu Rosca
[not found] ` <86d0jjglax.wl-marc.zyngier@arm.com>
2019-06-12 15:06 ` Eugeniu Rosca
2019-06-13 4:36 ` Harish Jenny K N
2019-07-24 11:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610083012.GV5447@atomide.com \
--to=tony@atomide.com \
--cc=andrey.gusakov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=erosca@de.adit-jv.com \
--cc=eyalr@ti.com \
--cc=geert@linux-m68k.org \
--cc=george_davis@mentor.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=john.stultz@linaro.org \
--cc=joshua_frkuska@mentor.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=roscaeugeniu@gmail.com \
--cc=spapageorgiou@de.adit-jv.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).