linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: thierry.reding@gmail.com, linux-pwm@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/4] pwm: Add power management descriptions
Date: Thu, 13 Jun 2019 12:04:54 +0200	[thread overview]
Message-ID: <20190613100453.ythhx3lika5cil4q@verge.net.au> (raw)
In-Reply-To: <1559296501-30620-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>

On Fri, May 31, 2019 at 06:54:58PM +0900, Yoshihiro Shimoda wrote:
> This patch adds power management descriptions that consumers should
> implement it.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  Documentation/pwm.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/pwm.txt b/Documentation/pwm.txt
> index 8fbf0aa..ab62f1b 100644
> --- a/Documentation/pwm.txt
> +++ b/Documentation/pwm.txt
> @@ -65,6 +65,10 @@ period). struct pwm_args contains 2 fields (period and polarity) and should
>  be used to set the initial PWM config (usually done in the probe function
>  of the PWM user). PWM arguments are retrieved with pwm_get_args().
>  
> +All consumers should really be reconfiguring the PWM upon resume as
> +appropriate. This is the only way to ensure that everything is resumed in
> +the proper order.
> +
>  Using PWMs with the sysfs interface
>  -----------------------------------
>  
> @@ -141,6 +145,9 @@ The implementation of ->get_state() (a method used to retrieve initial PWM
>  state) is also encouraged for the same reason: letting the PWM user know
>  about the current PWM state would allow him to avoid glitches.
>  
> +Drivers should not implement any power management. In other words,
> +consumers should implement it as described in the "Using PWMs" section.
> +
>  Locking
>  -------
>  
> -- 
> 2.7.4
> 

  reply	other threads:[~2019-06-13 15:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  9:54 [PATCH v3 0/4] pwm: add power management on sysfs and switch to SPDX Yoshihiro Shimoda
2019-05-31  9:54 ` [PATCH v3 1/4] pwm: Add power management descriptions Yoshihiro Shimoda
2019-06-13 10:04   ` Simon Horman [this message]
2019-05-31  9:54 ` [PATCH v3 2/4] pwm: sysfs: Switch to SPDX identifier Yoshihiro Shimoda
2019-06-13 10:05   ` Simon Horman
2019-05-31  9:55 ` [PATCH v3 3/4] pwm: sysfs: Add suspend/resume support Yoshihiro Shimoda
2019-06-13 10:05   ` Simon Horman
2019-05-31  9:55 ` [PATCH v3 4/4] pwm: rcar: Remove " Yoshihiro Shimoda
2019-06-13 10:05   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613100453.ythhx3lika5cil4q@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).