From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7942CC31E4C for ; Fri, 14 Jun 2019 07:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BDDC21721 for ; Fri, 14 Jun 2019 07:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726115AbfFNHQn (ORCPT ); Fri, 14 Jun 2019 03:16:43 -0400 Received: from verein.lst.de ([213.95.11.211]:44697 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbfFNHQn (ORCPT ); Fri, 14 Jun 2019 03:16:43 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 660D968B02; Fri, 14 Jun 2019 09:16:14 +0200 (CEST) Date: Fri, 14 Jun 2019 09:16:14 +0200 From: Christoph Hellwig To: Wolfram Sang Cc: Yoshihiro Shimoda , joro@8bytes.org, axboe@kernel.dk, ulf.hansson@linaro.org, wsa+renesas@sang-engineering.com, hch@lst.de, iommu@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [RFC PATCH v6 1/5] iommu: add an exported function to get minimum page size for a domain Message-ID: <20190614071614.GA8420@lst.de> References: <1560421215-10750-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1560421215-10750-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> <20190613193759.GB6863@kunai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190613193759.GB6863@kunai> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Jun 13, 2019 at 09:37:59PM +0200, Wolfram Sang wrote: > What about making this a 'static inline' in the iommu header file? I'd > think it is simple enough and would save us the EXPORT symbol. Agreed, this seems simple enought for an inline.