From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E38C31E49 for ; Wed, 19 Jun 2019 12:18:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3B2D214AF for ; Wed, 19 Jun 2019 12:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfFSMSN (ORCPT ); Wed, 19 Jun 2019 08:18:13 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:58832 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbfFSMSN (ORCPT ); Wed, 19 Jun 2019 08:18:13 -0400 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id EBC2225AF1B; Wed, 19 Jun 2019 22:18:10 +1000 (AEST) Received: by reginn.horms.nl (Postfix, from userid 7100) id 9217A9409FF; Wed, 19 Jun 2019 14:18:08 +0200 (CEST) Date: Wed, 19 Jun 2019 14:18:08 +0200 From: Simon Horman To: Fabrizio Castro Cc: Geert Uytterhoeven , Geert Uytterhoeven , Rob Herring , Mark Rutland , Magnus Damm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Biju Das , "xu_shunji@hoperun.com" Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support Message-ID: <20190619121808.hnqoeihjch6silcd@verge.net.au> References: <1560518075-2254-1-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Wed, Jun 19, 2019 at 08:16:43AM +0000, Fabrizio Castro wrote: > Hello Geert, > > Thank you for your feedback > > > From: linux-renesas-soc-owner@vger.kernel.org On Behalf Of Geert Uytterhoeven > > Sent: 19 June 2019 08:34 > > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support > > > > Hi Fabrizio, > > > > On Tue, Jun 18, 2019 at 5:56 PM Fabrizio Castro > > wrote: > > > > From: linux-renesas-soc-owner@vger.kernel.org On Behalf Of Geert Uytterhoeven > > > > Sent: 18 June 2019 16:10 > > > > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support > > > > > > > > On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro > > > > wrote: > > > > > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board > > > > > common device tree. > > > > > > > > > > Signed-off-by: Fabrizio Castro > > > > > > > > Thanks for your patch! > > > > > > > > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > > > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > > > > @@ -17,6 +17,30 @@ > > > > > stdout-path = "serial0:115200n8"; > > > > > }; > > > > > > > > > > + leds { > > > > > + compatible = "gpio-leds"; > > > > > + > > > > > + led0 { > > > > > + gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>; > > > > > + label = "LED0"; > > > > > > > > There's no need for a label property, if it matches the node name > > > > (applies to all four LEDs). > > > > > > I could have used the actual names on the schematic, but then I realised that > > > would not have been too helpful due to the corresponding switch names: > > > LED0 - GP6_11 - SW2202 - LED2201 > > > LED1 - GP6_12 - SW2201 - LED2202 > > > LED2 - GP6_13 - SW2203 - LED2203 > > > LED3 - GP0_00 - N/A - LED2402 > > > The first 3 LEDs are found next to the micro USB connector for the debug console, > > > the forth LED is found next to the WiFi and BT LEDs. > > > > > > I thought that using "LEDn" as labels would put a remark on the > > > "desired ordering" of the LEDs (even though there is no actual > > > requirement for that), but as you pointed out it's probably a bit > > > confusing? Do you think I should take the label out? > > > > If the LEDs don't have nice labels on the PCB, I would drop the label > > properties. > > Will do. Simon, do you want me to send an incremental patch for this (this patch > is on devel branch already) or would you rather I sent a v2? Please send an incremental patch, thanks.