From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B47C76191 for ; Thu, 18 Jul 2019 14:02:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77B882173E for ; Thu, 18 Jul 2019 14:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390498AbfGROCb (ORCPT ); Thu, 18 Jul 2019 10:02:31 -0400 Received: from sauhun.de ([88.99.104.3]:45086 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727733AbfGROCb (ORCPT ); Thu, 18 Jul 2019 10:02:31 -0400 Received: from localhost (p54B330C7.dip0.t-ipconnect.de [84.179.48.199]) by pokefinder.org (Postfix) with ESMTPSA id 399802C2868; Thu, 18 Jul 2019 16:02:28 +0200 (CEST) Date: Thu, 18 Jul 2019 16:02:27 +0200 From: Wolfram Sang To: Arnd Bergmann Cc: Marek Vasut , Jonathan Cameron , stable@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Simon Horman , linux-renesas-soc@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Kuninori Morimoto , Rob Herring , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] iio: adc: gyroadc: fix uninitialized return code Message-ID: <20190718140227.GA3813@kunai> References: <20190718135758.2672152-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline In-Reply-To: <20190718135758.2672152-1-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 18, 2019 at 03:57:49PM +0200, Arnd Bergmann wrote: > gcc-9 complains about a blatant uninitialized variable use that > all earlier compiler versions missed: >=20 > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitia= lized in this function [-Wmaybe-uninitialized] >=20 > Return -EINVAL instead here and a few lines above it where > we accidentally return 0 on failure. >=20 > Cc: stable@vger.kernel.org > Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver") > Signed-off-by: Arnd Bergmann Yes, I checked the other error paths, too, and they look proper to me. Reviewed-by: Wolfram Sang --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl0we+8ACgkQFA3kzBSg KbYFExAAiU0knL5icE+gKlWN8Amm/LWljBQpjQBwAEeVxaqs3PWHRxVvXYyp7ahZ nlaDmp9pKn8/iaXdxl3OdN3P5OcuSrE9rMVZ8CGdDWHGUAg6GpeCBASitaL6OhiQ ByF0v2XY2IelOKkwtfjiRdABKC9+p99MeBMfzIyw8ZLHaLvIrJOp2h7ArSl5QAQI JAgOJ4haOKGL3WGFBm1cU1JVq7Zsy8oyiibLhG5b7jStr+QDuXhhpMm/MVripCJ0 516m5K1gxRO+P6yQHVTw5lD+C01fWAobltwgJDmM+0Mn/kCJvtsG497v9pt7neQs VuryNoU+lKcNx9CR6Mbo/PScXdNeQws1cSbO9rRAUZqwgrzYe+1l5sqfddEoP7QJ erreHy0r35a2JlpubcNlk7WFpVxDj8rDueADicLtDDEP9CtHGZahAo1n4u7MpIfC mJgJ1MCCxvp0Nv7S0P2FFwv0Q+WTFgNHiHkppqd4IYXS6G3QMHNHXLr8CVJRupPp RXnkQS2cK0RwXKnGqkha7mCz5hURoGhi5riD0WNU9tIqQAQ9JpAz6SQSHJWAQ14G fyXgEk8sibz0Zj1Vp4WzSmn7bY2Z33gSMlf+LD2WB6xFiPSD2P1p3hz/e3OISaFT YTPXPAHDc0/WIr26/K8CDqM+MBQOhFlJKJpG+YuEPDwzCWZlXJ4= =x53J -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx--