From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF8D9C433FF for ; Thu, 8 Aug 2019 13:24:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C07F92171F for ; Thu, 8 Aug 2019 13:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732643AbfHHNYX (ORCPT ); Thu, 8 Aug 2019 09:24:23 -0400 Received: from mga05.intel.com ([192.55.52.43]:2532 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728327AbfHHNYX (ORCPT ); Thu, 8 Aug 2019 09:24:23 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 06:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="199043407" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga004.fm.intel.com with ESMTP; 08 Aug 2019 06:24:19 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1hviOv-0003YM-Kx; Thu, 08 Aug 2019 16:24:17 +0300 Date: Thu, 8 Aug 2019 16:24:17 +0300 From: Andy Shevchenko To: "Enrico Weigelt, metux IT consult" Cc: Javier Martinez Canillas , Geert Uytterhoeven , Wolfram Sang , Kieran Bingham , Masahiro Yamada , Michal Marek , linux-kbuild , open list , Linux-Renesas , Lee Jones , Alexandre Belloni , Mark Brown Subject: Re: [PATCH RFC] modpost: Support I2C Aliases from OF tables Message-ID: <20190808132417.GU30120@smile.fi.intel.com> References: <20190710193918.31135-1-kieran.bingham+renesas@ideasonboard.com> <0e1b6e0b-1c94-4b00-7fda-c2a303ee3816@redhat.com> <20190731194419.GB4084@kunai> <51451f89-9193-2be6-e724-e9ca44a25f52@redhat.com> <620e0aec-e3d8-7289-6525-b720013e8dfa@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <620e0aec-e3d8-7289-6525-b720013e8dfa@metux.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Aug 08, 2019 at 03:12:47PM +0200, Enrico Weigelt, metux IT consult wrote: > On 06.08.19 19:12, Javier Martinez Canillas wrote: > > > Right, we could add a macro for that. Although it should probably be called > > I2C_OF_MODULE_DEVICE_TABLE() or something like that since is specific to OF. > > At that point it should be completely noop when OF is disabled, so we > also can get rid of many ifdef's. Why? > I've got some patch somewhere for introducing a MODULE_OF_TABLE() macro > as replacement for many MODULE_DEVICE_TABLE(of, ...) cases, which noops > when CONFIG_OF is disabled. (and similar ones for other table types). It's simple wrong to have #ifdef CONFIG_OF without counterpart of_match_ptr(). And taking into consideration that ID table itself doesn't depend to OF at all, why not simple drop that #ifdef and of_match_ptr() all together? -- With Best Regards, Andy Shevchenko