From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFDD1C31E40 for ; Fri, 9 Aug 2019 18:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B33CE214C6 for ; Fri, 9 Aug 2019 18:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfHISwd (ORCPT ); Fri, 9 Aug 2019 14:52:33 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:36940 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbfHISwd (ORCPT ); Fri, 9 Aug 2019 14:52:33 -0400 Received: from penelope.horms.nl (unknown [66.60.152.14]) by kirsty.vergenet.net (Postfix) with ESMTPA id 425AB25AD78; Sat, 10 Aug 2019 04:52:31 +1000 (AEST) Received: by penelope.horms.nl (Postfix, from userid 7100) id 361DBE21A9A; Fri, 9 Aug 2019 20:52:30 +0200 (CEST) Date: Fri, 9 Aug 2019 11:52:30 -0700 From: Simon Horman To: Yoshihiro Shimoda Cc: linus.walleij@linaro.org, geert+renesas@glider.be, linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 2/3] pinctrl: sh-pfc: remove incomplete flag "cfg->type" Message-ID: <20190809185229.mcxph7qkb4xhuuu3@verge.net.au> References: <1565245143-15018-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1565245143-15018-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565245143-15018-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Aug 08, 2019 at 03:19:02PM +0900, Yoshihiro Shimoda wrote: > The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf > support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because > sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin(). > Now if we fix the cfg->type condition, it gets worse because: > - Some drivers might be deferred so that .set_mux() will be called > multiple times. > - In such the case, the sh-pfc driver returns -EBUSY even if > the group is the same, and then that driver fails to probe. > > Since the pinctrl subsystem already has such conditions according > to @set_mux and @gpio_request_enable, this patch just remove > the incomplete flag from sh-pfc/pinctrl.c. > > Fixes: c58d9c1b26e3 ("sh-pfc: Implement generic pinconf support") > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman