From: veeraiyan chidambaram <external.veeraiyan.c@de.adit-jv.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
"REE erosca@DE.ADIT-JV.COM" <erosca@DE.ADIT-JV.COM>,
Veeraiyan Chidambaram <veeraiyan.chidambaram@in.bosch.com>
Subject: Re: [PATCH v2] usb: gadget: udc: renesas_usb3: add suspend event support
Date: Thu, 5 Sep 2019 12:26:16 +0200 [thread overview]
Message-ID: <20190905102616.GA3752@vmlxhi-070.adit-jv.com> (raw)
In-Reply-To: <OSAPR01MB4529159D4DA9764B0688D4A4D8BB0@OSAPR01MB4529.jpnprd01.prod.outlook.com>
Hello Shimoda-san,
Please ignore my previous V2 patch [1] and take V3 patch[2].
sorry for the inconvenience.
[1] https://patchwork.kernel.org/patch/11132433/
[2] https://patchwork.kernel.org/patch/11132489/
Best regards,
Veeraiyan Chidambaram
On Thu, Sep 05, 2019 at 02:09:42AM +0000, Yoshihiro Shimoda wrote:
> Hi Veeraiyan,
>
> Thank you for the patch!
>
> > From: Veeraiyan Chidambaram, Sent: Wednesday, September 4, 2019 11:48 PM
> <snip>
> > --- a/drivers/usb/gadget/udc/renesas_usb3.c
> > +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> > @@ -767,6 +767,20 @@ static void usb3_irq_epc_int_1_resume(struct renesas_usb3 *usb3)
> > usb3_transition_to_default_state(usb3, false);
> > }
> >
> > +static void usb3_irq_epc_int_1_suspend(struct renesas_usb3 *usb3)
> > +{
> > + usb3_disable_irq_1(usb3, USB_INT_1_B2_SPND);
> > +
> > + if (usb3->driver &&
> > + usb3->driver->suspend &&
>
> As I mentioned on v1 patch [1], I'd like to remove these conditions.
> After fixed it,
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> [1] https://patchwork.kernel.org/patch/11129797/#22862513
>
> Best regards,
> Yoshihiro Shimoda
>
> > + usb3->gadget.speed != USB_SPEED_UNKNOWN &&
> > + usb3->gadget.state != USB_STATE_NOTATTACHED) {
> > + if (usb3->driver && usb3->driver->suspend)
> > + usb3->driver->suspend(&usb3->gadget);
> > + usb_gadget_set_state(&usb3->gadget, USB_STATE_SUSPENDED);
> > + }
> > +}
> > +
> > static void usb3_irq_epc_int_1_disable(struct renesas_usb3 *usb3)
> > {
> > usb3_stop_usb3_connection(usb3);
> > @@ -852,6 +866,9 @@ static void usb3_irq_epc_int_1(struct renesas_usb3 *usb3, u32 int_sta_1)
> > if (int_sta_1 & USB_INT_1_B2_RSUM)
> > usb3_irq_epc_int_1_resume(usb3);
> >
> > + if (int_sta_1 & USB_INT_1_B2_SPND)
> > + usb3_irq_epc_int_1_suspend(usb3);
> > +
> > if (int_sta_1 & USB_INT_1_SPEED)
> > usb3_irq_epc_int_1_speed(usb3);
> >
> > --
> > 2.7.4
>
next prev parent reply other threads:[~2019-09-05 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 9:24 [PATCH] usb: gadget: udc: renesas_usb3: add suspend event support Veeraiyan Chidambaram
2019-09-04 12:08 ` Yoshihiro Shimoda
2019-09-04 14:31 ` veeraiyan chidambaram
2019-09-04 14:48 ` [PATCH v2] " Veeraiyan Chidambaram
2019-09-05 2:09 ` Yoshihiro Shimoda
2019-09-05 8:52 ` veeraiyan chidambaram
2019-09-05 10:26 ` veeraiyan chidambaram [this message]
2019-09-05 8:37 Veeraiyan Chidambaram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905102616.GA3752@vmlxhi-070.adit-jv.com \
--to=external.veeraiyan.c@de.adit-jv.com \
--cc=andrew_gabbasov@mentor.com \
--cc=balbi@kernel.org \
--cc=erosca@DE.ADIT-JV.COM \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=veeraiyan.chidambaram@in.bosch.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).