From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Simon Horman <horms@verge.net.au>, Ulrich Hecht <uli@fpond.eu>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com,
Harsha.ManjulaMallikarjun@in.bosch.com,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation
Date: Thu, 5 Sep 2019 14:50:17 +0300 [thread overview]
Message-ID: <20190905115017.GI5035@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190830180108.mlei4wbfn3mktj23@uno.localdomain>
Hi Jacopo,
On Fri, Aug 30, 2019 at 08:01:09PM +0200, Jacopo Mondi wrote:
> On Mon, Aug 26, 2019 at 01:15:50PM +0300, Laurent Pinchart wrote:
> > On Mon, Aug 26, 2019 at 09:59:43AM +0200, Jacopo Mondi wrote:
> >> On Mon, Aug 26, 2019 at 09:34:41AM +0200, Geert Uytterhoeven wrote:
> >>> On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> >>>> Add device tree bindings documentation for the Renesas R-Car Display
> >>>> Unit Color Management Module.
> >>>>
> >>>> CMM is the image enhancement module available on each R-Car DU video
> >>>> channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).
> >>>>
> >>>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> >>>
> >>> Thanks for your patch!
> >>>
> >>>> --- /dev/null
> >>>> +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt
> >>>> @@ -0,0 +1,33 @@
> >>>> +* Renesas R-Car Color Management Module (CMM)
> >>>> +
> >>>> +Renesas R-Car image enhancement module connected to R-Car DU video channels.
> >>>> +
> >>>> +Required properties:
> >>>> + - compatible: shall be one or more of the following:
> >>>> + - "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM.
> >>>> + - "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM.
> >>>> + - "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM.
> >>>> + - "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM.
> >>>> + - "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM.
> >>>
> >>> Please use "renesas,<socype->-cmm" instead of "renesas,cmm-<soctype>".
> >>
> >> I actually copied it from the r-car gpio bindings, and I liked
> >> cmm-<soctype> better. If you prefer I can change it though.
> >>
> >>>> + - "renesas,rcar-gen3-cmm": for a generic R-Car Gen3 compatible CMM.
> >>>> + - "renesas,rcar-gen2-cmm": for a generic R-Car Gen2 compatible CMM.
> >>>> +
> >>>> + When the generic compatible string is specified, the SoC-specific
> >>>> + version corresponding to the platform should be listed first.
> >>>> +
> >>>> + - reg: the address base and length of the memory area where CMM control
> >>>> + registers are mapped to.
> >>>> +
> >>>> + - clocks: phandle and clock-specifier pair to the CMM functional clock
> >>>> + supplier.
> >>>
> >>> Thinking about yaml validation:
> >>>
> >>> power-domains?
> >>> resets?
> >>
> >> They should indeed be documented.
> >
> > How about converting this binding to yaml alreay ? It should be fairly
> > simple.
>
> I'm trying to, and I'm having my portion of fun time at it.
>
> The definition of the schema itself seems good, but I wonder, is this
> the first renesas schema we have? Because it seems to me the schema
> validator is having an hard time to digest the examplea 'clocks' and
> 'power-domains' properties, which have 1 phandle and 2 specifiers and 1
> phandle and 1 specifier respectively for Rensas SoCs.
>
> In other words, if in the example I have:
>
> examples:
> - |
> cmm0: cmm@fea40000 {
> compatible = "renesas,r8a7796-cmm";
> reg = <0 0xfea40000 0 0x1000>;
> clocks = <&cpg 711> <---- 1 phandle + 1 specifier
> resets = <&cpg 711>;
> power-domains = <&sysc>; <---- 1 phandle
> };
>
> The schema validation is good.
>
> While if I use an actual example
> - |
> cmm0: cmm@fea40000 {
> compatible = "renesas,r8a7796-cmm";
> reg = <0 0xfea40000 0 0x1000>;
> clocks = <&cpg CPG_MOD 711> <---- 1 phandle + 2 specifier
> resets = <&cpg 711>;
> power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; <---- 1 phandle
> }; + 1 specfier
>
> The schema validation fails...
> Error: Documentation/devicetree/bindings/display/renesas,cmm.example.dts:20.29-30 syntax error
> FATAL ERROR: Unable to parse input tree
>
> Are clocks properties with > 2 entries and power-domains properties with
> > 1 entries supported?
>
> Because from what I read here:
> https://github.com/robherring/yaml-bindings/blob/master/schemas/clock/clock.yaml
> "The length of a clock specifier is defined by the value of a #clock-cells
> property in the clock provider node."
>
> And that's expected, but is the examples actually validated against the
> clock provider pointed by the phandle? Because in that case, if we had a
> yaml schema for the cpg-mssr provider, it would indeed specify clock-cells=2.
>
> Do we need a schema for cpg-mssr first, or am I doing something else
> wrong?
I think you just need to #include the headers that define CPG_MOD and
R8A7796_PD_ALWAYS_ON.
> >>>> +Example:
> >>>> +--------
> >>>> +
> >>>> + cmm0: cmm@fea40000 {
> >>>> + compatible = "renesas,cmm-r8a7796";
> >>>> + reg = <0 0xfea40000 0 0x1000>;
> >>>> + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> >>>> + clocks = <&cpg CPG_MOD 711>;
> >>>> + resets = <&cpg 711>;
> >>>> + };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-09-05 11:50 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 13:51 [PATCH v3 00/14] drm: rcar-du: Add Color Management Module (CMM) Jacopo Mondi
2019-08-25 13:51 ` [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi
2019-08-26 7:34 ` Geert Uytterhoeven
2019-08-26 7:59 ` Jacopo Mondi
2019-08-26 8:38 ` Geert Uytterhoeven
2019-08-26 10:15 ` Laurent Pinchart
2019-08-30 18:01 ` Jacopo Mondi
2019-09-05 11:50 ` Laurent Pinchart [this message]
2019-09-05 12:05 ` Geert Uytterhoeven
2019-09-05 12:20 ` Laurent Pinchart
2019-09-05 13:28 ` Jacopo Mondi
2019-08-25 13:51 ` [PATCH v3 02/14] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi
2019-08-27 20:29 ` Rob Herring
2019-08-28 7:32 ` Geert Uytterhoeven
2019-08-28 8:28 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units Jacopo Mondi
2019-08-26 7:28 ` Geert Uytterhoeven
2019-08-26 8:00 ` Jacopo Mondi
2019-08-26 22:43 ` Laurent Pinchart
2019-08-27 9:55 ` Jacopo Mondi
2019-08-27 10:12 ` Geert Uytterhoeven
2019-08-25 13:51 ` [PATCH v3 04/14] arm64: dts: renesas: r8a7795: " Jacopo Mondi
2019-08-26 22:45 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 05/14] arm64: dts: renesas: r8a77965: " Jacopo Mondi
2019-08-26 22:45 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 06/14] arm64: dts: renesas: r8a77990: " Jacopo Mondi
2019-08-26 22:47 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 07/14] arm64: dts: renesas: r8a77995: " Jacopo Mondi
2019-08-26 22:47 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 08/14] drm: rcar-du: Add support for CMM Jacopo Mondi
2019-08-26 7:31 ` Geert Uytterhoeven
2019-08-26 8:02 ` Jacopo Mondi
2019-08-27 0:24 ` Laurent Pinchart
2019-08-27 14:56 ` Jacopo Mondi
2019-08-27 15:48 ` Jacopo Mondi
2019-08-27 16:34 ` Laurent Pinchart
2019-09-05 9:57 ` Jacopo Mondi
2019-09-05 11:17 ` Laurent Pinchart
2019-09-05 13:14 ` Jacopo Mondi
2019-09-05 13:39 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 09/14] drm: rcar-du: Claim CMM support for Gen3 SoCs Jacopo Mondi
2019-08-25 13:51 ` [PATCH v3 10/14] drm: rcar-du: kms: Collect CMM instances Jacopo Mondi
2019-08-26 23:51 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 11/14] drm: rcar-du: crtc: Enable and disable CMMs Jacopo Mondi
2019-08-25 13:51 ` [PATCH v3 12/14] drm: rcar-du: crtc: Register GAMMA_LUT properties Jacopo Mondi
2019-08-25 13:51 ` [PATCH v3 13/14] drm: rcar-du: kms: Update CMM in atomic commit tail Jacopo Mondi
2019-08-27 0:00 ` Laurent Pinchart
2019-08-27 0:19 ` Laurent Pinchart
2019-08-27 14:44 ` Jacopo Mondi
2019-08-27 16:38 ` Laurent Pinchart
2019-08-25 13:51 ` [PATCH v3 14/14] drm: rcar-du: Force CMM enablement when resuming Jacopo Mondi
2019-08-27 0:05 ` Laurent Pinchart
2019-09-05 10:58 ` Jacopo Mondi
2019-09-05 11:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905115017.GI5035@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Harsha.ManjulaMallikarjun@in.bosch.com \
--cc=VenkataRajesh.Kalakodima@in.bosch.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=koji.matsuoka.xm@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=muroya@ksk.co.jp \
--cc=robh+dt@kernel.org \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).