From: Simon Horman <horms@verge.net.au>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h)
Date: Fri, 6 Sep 2019 11:34:48 +0200 [thread overview]
Message-ID: <20190906093448.tsgjefgkbgx2udsn@verge.net.au> (raw)
In-Reply-To: <20190905150528.20417-1-andrew.murray@arm.com>
On Thu, Sep 05, 2019 at 04:05:28PM +0100, Andrew Murray wrote:
> Remove unnecessary header include (../pci.h) since it doesn't
> provide any needed symbols.
>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/pci/controller/pcie-rcar.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
> index f6a669a9af41..ee1c38c2fac9 100644
> --- a/drivers/pci/controller/pcie-rcar.c
> +++ b/drivers/pci/controller/pcie-rcar.c
> @@ -30,8 +30,6 @@
> #include <linux/pm_runtime.h>
> #include <linux/slab.h>
>
> -#include "../pci.h"
> -
> #define PCIECAR 0x000010
> #define PCIECCTLR 0x000018
> #define CONFIG_SEND_ENABLE BIT(31)
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-09-06 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 15:05 [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h) Andrew Murray
2019-09-06 9:34 ` Simon Horman [this message]
2019-09-11 22:33 ` Kieran Bingham
2019-09-12 8:19 ` Andrew Murray
2019-09-12 8:38 ` Geert Uytterhoeven
2019-10-15 15:28 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906093448.tsgjefgkbgx2udsn@verge.net.au \
--to=horms@verge.net.au \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).