Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: hch@lst.de, ulf.hansson@linaro.org,
	wsa+renesas@sang-engineering.com, treding@nvidia.com,
	linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mmc: queue: Fix bigger segments usage
Date: Thu, 12 Sep 2019 18:57:14 +0100
Message-ID: <20190912175713.GB919@kunai> (raw)
In-Reply-To: <1568261636-25625-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On Thu, Sep 12, 2019 at 01:13:55PM +0900, Yoshihiro Shimoda wrote:
> The commit 38c38cb73223 ("mmc: queue: use bigger segments if DMA MAP
> layer can merge the segments") always enables the bugger segments

"buffer" :)

> if DMA MAP layer can merge the segments, but some controllers (SDHCI)
> have strictly limitation about the segments size, and then the commit
> breaks on the controllers.
> 
> To fix the issue, this patch adds a new flag MMC_CAP2_MERGE_CAPABLE
> into the struct mmc_host and the bigger segments usage is disabled
> as default.
> 
> Reported-by: Thierry Reding <treding@nvidia.com>
> Fixes: 38c38cb73223 ("mmc: queue: use bigger segments if DMA MAP layer can merge the segments")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

For the record:

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  4:13 [PATCH v2 0/2] " Yoshihiro Shimoda
2019-09-12  4:13 ` [PATCH v2 1/2] " Yoshihiro Shimoda
2019-09-12 17:57   ` Wolfram Sang [this message]
2019-09-12  4:13 ` [PATCH v2 2/2] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP2_MERGE_CAPABLE Yoshihiro Shimoda
2019-09-12 17:57   ` Wolfram Sang
2019-09-12 12:17 ` [PATCH v2 0/2] mmc: queue: Fix bigger segments usage Christoph Hellwig

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190912175713.GB919@kunai \
    --to=wsa@the-dreams.de \
    --cc=hch@lst.de \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=treding@nvidia.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox