linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andy Gross <agross@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Yoshihiro Kaneko <ykaneko0929@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: msm8996: Update simple-pm-bus node name to 'bus'
Date: Mon, 30 Sep 2019 13:29:24 +0200	[thread overview]
Message-ID: <20190930112924.uayeet4rogjmelfg@verge.net.au> (raw)
In-Reply-To: <CAMuHMdU6O-pDRBRXXX1ZU1L4c25POrPcDB_TsbAqA9wzVobtAw@mail.gmail.com>

On Thu, Sep 26, 2019 at 01:58:21PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Sep 24, 2019 at 11:37 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Update simple-pm-bus node name from 'agnoc' to 'bus' reflecting the
> > proposed binding description in json-schema which in turn reflects the ePAR
> > standard - "the name of a node should be somewhat generic, reflecting the
> > function of the device and not its precise programming model."
> >
> > Also drop the unit address as there is neither a reg property nor
> > non-empty ranges.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > v2
> > * New patch
> > ---
> >  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index 96c0a481f454..99f376ebd27e 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -1373,7 +1373,7 @@
> >                         clock-names = "iface", "bus";
> >                 };
> >
> > -               agnoc@0 {
> > +               bus {
> >                         power-domains = <&gcc AGGRE0_NOC_GDSC>;
> >                         compatible = "simple-pm-bus";
> >                         #address-cells = <1>;
> 
> This file is included by arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi,
> which references agnoc@0, so you have to update that one as well,
> to avoid introducing silent breakages.

Thanks, will do.

      reply	other threads:[~2019-09-30 11:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  9:36 [PATCH v3 0/3] dt-bindings: bus: simple-pm-bus, renesas-bsc: convert bindings to json-schema Simon Horman
2019-09-24  9:36 ` [PATCH v3 1/3] dt-bindings: bus: simple-pm-bus: " Simon Horman
2019-09-27 18:38   ` Rob Herring
2019-09-30 11:31     ` Simon Horman
2019-09-24  9:36 ` [PATCH v3 2/3] dt-bindings: bus: renesas-bsc: " Simon Horman
2019-09-24  9:36 ` [PATCH v3 3/3] arm64: dts: qcom: msm8996: Update simple-pm-bus node name to 'bus' Simon Horman
2019-09-24 10:15   ` Sergei Shtylyov
2019-09-24 10:18     ` Sergei Shtylyov
2019-09-26  8:32       ` Simon Horman
2019-09-26  8:38         ` Sergei Shtylyov
2019-09-26 11:58   ` Geert Uytterhoeven
2019-09-30 11:29     ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190930112924.uayeet4rogjmelfg@verge.net.au \
    --to=horms@verge.net.au \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).